public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: Jordan Justen <jordan.l.justen@intel.com>
To: edk2-devel@lists.01.org
Cc: Jordan Justen <jordan.l.justen@intel.com>,
	Andrew Fish <afish@apple.com>,
	Leif Lindholm <leif.lindholm@linaro.org>,
	Michael D Kinney <michael.d.kinney@intel.com>
Subject: [PATCH 3/3] Maintainers.txt: Add Package Reviewer role
Date: Thu, 10 Aug 2017 15:11:29 -0700	[thread overview]
Message-ID: <20170810221129.7383-3-jordan.l.justen@intel.com> (raw)
In-Reply-To: <20170810221129.7383-1-jordan.l.justen@intel.com>

Although everyone is encouraged to review patches and add their
Reviewed-by reply for a patch, with the Package Reviewer role we
identify additional community members that will be Cc'd for patches
made to a package.

A distinction between a Package Maintainer and Reviewer is that
Maintainers will always have source control push access to the package
whereas Reviewers will not. (The Reviewer may have push access if they
are also Package Maintainer for another package.)

Currently we have an limit of 2 Package Maintainers per package, but
the Package Maintainers for each package decide how to manage the
Package Reviewer list.

Cc: Andrew Fish <afish@apple.com>
Cc: Leif Lindholm <leif.lindholm@linaro.org>
Cc: Michael D Kinney <michael.d.kinney@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Jordan Justen <jordan.l.justen@intel.com>
---
 Maintainers.txt | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/Maintainers.txt b/Maintainers.txt
index 92a1fd974f..6317a392e7 100644
--- a/Maintainers.txt
+++ b/Maintainers.txt
@@ -5,7 +5,8 @@ This file provides information about the primary maintainers for
 EDK II.
 
 In general, you should not privately email the maintainer. You should
-email the edk2-devel list, but you can also Cc the maintainer.
+email the edk2-devel list, and Cc the package maintainers and
+reviewers.
 
 Descriptions of section entries:
 
@@ -13,6 +14,8 @@ Descriptions of section entries:
      Patches and questions should be sent to the email list.
   M: Package Maintainer: Cc address for patches and questions. Responsible
      for reviewing and pushing package changes to source control.
+  R: Package Reviewer: Cc address for patches and questions. Reviewers help
+     maintainers review code, but don't have push access.
   W: Web-page with status/info
   T: SCM tree type and location.  Type is one of: git, svn.
   S: Status, one of the following:
-- 
2.14.0



  parent reply	other threads:[~2017-08-10 22:09 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-08-10 22:11 [PATCH 1/3] Maintainers.txt: List Tianocore Stewards Jordan Justen
2017-08-10 22:11 ` [PATCH 2/3] Maintainers.txt: Update Package Maintainer description Jordan Justen
2017-08-10 22:11 ` Jordan Justen [this message]
2017-08-10 23:08 ` [PATCH 1/3] Maintainers.txt: List Tianocore Stewards Leif Lindholm
2017-08-10 23:13 ` Kinney, Michael D
2017-08-10 23:19   ` Andrew Fish
2017-08-16 17:09 ` Leif Lindholm

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170810221129.7383-3-jordan.l.justen@intel.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox