public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: Michael D Kinney <michael.d.kinney@intel.com>
To: edk2-devel@lists.01.org
Cc: Ruiyu Ni <ruiyu.ni@intel.com>, Hao Wu <hao.a.wu@intel.com>,
	Michael Kinney <michael.d.kinney@intel.com>
Subject: [Patch] Nt32/PlatformBootManagerLib: Enable STD_ERROR on all consoles
Date: Mon, 14 Aug 2017 15:29:44 -0700	[thread overview]
Message-ID: <20170814222944.9608-1-michael.d.kinney@intel.com> (raw)

Add STD_ERROR flag to all output consoles that the Nt32
platform supports so all messages sent to the standard
error console device(s) are visible by default.

The Boot Maintenance Manager can be used to manually disable
standard error output to specific console devices.

UEFI Applications and UEFI Drivers are recommended to be
built with DEBUG() and ASSERT() messages sent to the standard
error device using MdePkg/Library/UefiDebugLibStdErr. Prior
to this change, a user would have to use the Boot Maintenance
Manager to configure a standard error console device to make
these messages visible.

Cc: Ruiyu Ni <ruiyu.ni@intel.com>
Cc: Hao Wu <hao.a.wu@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Michael Kinney <michael.d.kinney@intel.com>
---
 Nt32Pkg/Library/PlatformBootManagerLib/PlatformData.c | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/Nt32Pkg/Library/PlatformBootManagerLib/PlatformData.c b/Nt32Pkg/Library/PlatformBootManagerLib/PlatformData.c
index e92f377bd1..e4b400b4a3 100644
--- a/Nt32Pkg/Library/PlatformBootManagerLib/PlatformData.c
+++ b/Nt32Pkg/Library/PlatformBootManagerLib/PlatformData.c
@@ -2,7 +2,7 @@
   Defined the platform specific device path which will be filled to
   ConIn/ConOut variables.
    
-Copyright (c) 2015, Intel Corporation. All rights reserved.<BR>
+Copyright (c) 2015 - 2017, Intel Corporation. All rights reserved.<BR>
 This program and the accompanying materials                          
 are licensed and made available under the terms and conditions of the BSD License         
 which accompanies this distribution.  The full text of the license may be found at        
@@ -137,19 +137,19 @@ NT_ISA_SERIAL_DEVICE_PATH   gNtSerialDevicePath1 = {
 PLATFORM_CONSOLE_CONNECT_ENTRY   gPlatformConsole[] = {
   {
     (EFI_DEVICE_PATH_PROTOCOL *) &gNtSerialDevicePath0,
-    (CONSOLE_OUT | CONSOLE_IN)
+    (CONSOLE_OUT | CONSOLE_IN | STD_ERROR)
   },
   {
     (EFI_DEVICE_PATH_PROTOCOL *) &gNtSerialDevicePath1,
-    (CONSOLE_OUT | CONSOLE_IN)
+    (CONSOLE_OUT | CONSOLE_IN | STD_ERROR)
   },
   {
     (EFI_DEVICE_PATH_PROTOCOL *) &gGopDevicePath0,
-    (CONSOLE_OUT | CONSOLE_IN)
+    (CONSOLE_OUT | CONSOLE_IN | STD_ERROR)
   },
   {
     (EFI_DEVICE_PATH_PROTOCOL *) &gGopDevicePath1,
-    (CONSOLE_OUT | CONSOLE_IN)
+    (CONSOLE_OUT | CONSOLE_IN | STD_ERROR)
   },
   {
     NULL,
-- 
2.13.1.windows.2



             reply	other threads:[~2017-08-14 22:27 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-08-14 22:29 Michael D Kinney [this message]
2017-08-15  1:00 ` [Patch] Nt32/PlatformBootManagerLib: Enable STD_ERROR on all consoles Ni, Ruiyu
2017-08-15  6:26 ` Wang, Sunny (HPS SW)

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170814222944.9608-1-michael.d.kinney@intel.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox