[PATCH v2 0/1] OvmfPkg/build.sh: select the GCC49 toolchain settings for gcc-7.*

[PATCH v2 0/1] OvmfPkg/build.sh: select the GCC49 toolchain settings for gcc-7.*

[Laszlo Ersek]

This is v2 (or more precisely, the OvmfPkg variant) of the patch posted
at <https://lists.01.org/pipermail/edk2-devel/2017-August/013125.html>.
It is meant as a speedy workaround until we figure out and agree on a
workaround that isn't specific to any edk2 platform.

Repo:   https://github.com/lersek/edk2.git
Branch: gcc7_lto_v2

The same testing caveats apply to this version as to v1.

Cc: Alex Williamson <alex.williamson@redhat.com>
Cc: Jordan Justen <jordan.l.justen@intel.com>

Thanks!
Laszlo

Laszlo Ersek (1):
  OvmfPkg/build.sh: select the GCC49 toolchain settings for gcc-7.*

 OvmfPkg/build.sh | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

-- 
2.14.1.3.gb7cf6e02401b

[PATCH v2 1/1] OvmfPkg/build.sh: select the GCC49 toolchain settings for gcc-7.*

[Laszlo Ersek]

When UefiCpuPkg/MpInitLib is built for X64 with gcc-7, using the DEBUG
build target and the GCC5 toolchain settings, a C-language assignment is
miscompiled such that the initial AP startup hangs in CpuMpPei (X64) or
CpuDxe (Ia32X64). See <https://bugzilla.tianocore.org/show_bug.cgi?id=671>
for a detailed analysis of the symptoms, and for mailing list links.

This issue has been reported several times (one example is
<https://bugzilla.tianocore.org/show_bug.cgi?id=657>). Until we (or the
upstream gcc developers) figure out how to dissuade gcc-7 from the
miscompilation, pick the GCC49 toolchain in "build.sh" for gcc-7.*.

Cc: Alex Williamson <alex.williamson@redhat.com>
Cc: Jordan Justen <jordan.l.justen@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Laszlo Ersek <lersek@redhat.com>
---
 OvmfPkg/build.sh | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/OvmfPkg/build.sh b/OvmfPkg/build.sh
index 682155202564..5868d3b8c498 100755
--- a/OvmfPkg/build.sh
+++ b/OvmfPkg/build.sh
@@ -102,7 +102,7 @@ case `uname` in
       4.8.*)
         TARGET_TOOLS=GCC48
         ;;
-      4.9.*|6.[0-2].*)
+      4.9.*|6.[0-2].*|7.*)
         TARGET_TOOLS=GCC49
         ;;
       *)
-- 
2.14.1.3.gb7cf6e02401b

Re: [PATCH v2 1/1] OvmfPkg/build.sh: select the GCC49 toolchain settings for gcc-7.*

[Jordan Justen]

Reviewed-by: Jordan Justen <jordan.l.justen@intel.com>

On 2017-08-15 10:09:14, Laszlo Ersek wrote:
> When UefiCpuPkg/MpInitLib is built for X64 with gcc-7, using the DEBUG
> build target and the GCC5 toolchain settings, a C-language assignment is
> miscompiled such that the initial AP startup hangs in CpuMpPei (X64) or
> CpuDxe (Ia32X64). See <https://bugzilla.tianocore.org/show_bug.cgi?id=671>
> for a detailed analysis of the symptoms, and for mailing list links.
> 
> This issue has been reported several times (one example is
> <https://bugzilla.tianocore.org/show_bug.cgi?id=657>). Until we (or the
> upstream gcc developers) figure out how to dissuade gcc-7 from the
> miscompilation, pick the GCC49 toolchain in "build.sh" for gcc-7.*.
> 
> Cc: Alex Williamson <alex.williamson@redhat.com>
> Cc: Jordan Justen <jordan.l.justen@intel.com>
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Laszlo Ersek <lersek@redhat.com>
> ---
>  OvmfPkg/build.sh | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/OvmfPkg/build.sh b/OvmfPkg/build.sh
> index 682155202564..5868d3b8c498 100755
> --- a/OvmfPkg/build.sh
> +++ b/OvmfPkg/build.sh
> @@ -102,7 +102,7 @@ case `uname` in
>        4.8.*)
>          TARGET_TOOLS=GCC48
>          ;;
> -      4.9.*|6.[0-2].*)
> +      4.9.*|6.[0-2].*|7.*)
>          TARGET_TOOLS=GCC49
>          ;;
>        *)
> -- 
> 2.14.1.3.gb7cf6e02401b
> 

Re: [PATCH v2 1/1] OvmfPkg/build.sh: select the GCC49 toolchain settings for gcc-7.*

[Laszlo Ersek]

On 08/16/17 01:10, Jordan Justen wrote:
> Reviewed-by: Jordan Justen <jordan.l.justen@intel.com>

Thank you, pushed as commit ca56256d5e0b.
Laszlo

> On 2017-08-15 10:09:14, Laszlo Ersek wrote:
>> When UefiCpuPkg/MpInitLib is built for X64 with gcc-7, using the DEBUG
>> build target and the GCC5 toolchain settings, a C-language assignment is
>> miscompiled such that the initial AP startup hangs in CpuMpPei (X64) or
>> CpuDxe (Ia32X64). See <https://bugzilla.tianocore.org/show_bug.cgi?id=671>
>> for a detailed analysis of the symptoms, and for mailing list links.
>>
>> This issue has been reported several times (one example is
>> <https://bugzilla.tianocore.org/show_bug.cgi?id=657>). Until we (or the
>> upstream gcc developers) figure out how to dissuade gcc-7 from the
>> miscompilation, pick the GCC49 toolchain in "build.sh" for gcc-7.*.
>>
>> Cc: Alex Williamson <alex.williamson@redhat.com>
>> Cc: Jordan Justen <jordan.l.justen@intel.com>
>> Contributed-under: TianoCore Contribution Agreement 1.1
>> Signed-off-by: Laszlo Ersek <lersek@redhat.com>
>> ---
>>  OvmfPkg/build.sh | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/OvmfPkg/build.sh b/OvmfPkg/build.sh
>> index 682155202564..5868d3b8c498 100755
>> --- a/OvmfPkg/build.sh
>> +++ b/OvmfPkg/build.sh
>> @@ -102,7 +102,7 @@ case `uname` in
>>        4.8.*)
>>          TARGET_TOOLS=GCC48
>>          ;;
>> -      4.9.*|6.[0-2].*)
>> +      4.9.*|6.[0-2].*|7.*)
>>          TARGET_TOOLS=GCC49
>>          ;;
>>        *)
>> -- 
>> 2.14.1.3.gb7cf6e02401b
>>
> _______________________________________________
> edk2-devel mailing list
> edk2-devel@lists.01.org
> https://lists.01.org/mailman/listinfo/edk2-devel
>