From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wr0-x22a.google.com (mail-wr0-x22a.google.com [IPv6:2a00:1450:400c:c0c::22a]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 717B12095B9D9 for ; Thu, 17 Aug 2017 08:48:57 -0700 (PDT) Received: by mail-wr0-x22a.google.com with SMTP id f8so2949404wrf.3 for ; Thu, 17 Aug 2017 08:51:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to :user-agent; bh=qgCnJ6bemnMNLTGBqoDqbLEFbVAElyHQMZ4sUVYKJzI=; b=gThci1Kqr5gqQCNUdG349hsEqbMzm2LZYIDAvQEOwJF6AhgYeu9n5pT9UfnfXWByms CX/IrMh/NHY+iFwva06bd2IW1i5hAFVomVp2tYTrDJC/EgPGk+JhI0+5dvX5swEYd3eH HTzXntpzn2aRsruDeRMkUxXZ/ZUMe5+oYpq08= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to:user-agent; bh=qgCnJ6bemnMNLTGBqoDqbLEFbVAElyHQMZ4sUVYKJzI=; b=W1reZD5BDf9B1H0rVHGBT2d51/153QkwjECVFpdPHzihurorcaDubt1O0h4MhO2ft7 KA6qHeox2TKyUVyJdbYAdqVbdMvg2G1QkwOFGBNr5DnAF1EalDOG3zRWqn4TV/aUbosE pYqfZfBhHJl+0zrzWxgJoIC9aiL6q6pyXWeGY2emsVYneLPKEjTknsMxtVq+cx2MK4fH 3Wko19+ogWwk9Aq+iL64xRFI8RO6TdaZGxUzjdu5Cl2tAqmVDJbaWXvivSpYN7c5crHB Jvd/NYMUNCnm6QxFV2RRDsmTomm4oH8/MzZTt2RJb3K51k+hcIOOXiriCyY4lw6r09PQ a0VQ== X-Gm-Message-State: AHYfb5ijonGAOlvFYFHKBPNh9EX9mnFE5QRjWBJpOR18w3vsAbTENRN+ SGbZcZwYCfgzB3yN X-Received: by 10.223.153.195 with SMTP id y61mr3444213wrb.41.1502985083289; Thu, 17 Aug 2017 08:51:23 -0700 (PDT) Received: from bivouac.eciton.net (bivouac.eciton.net. [2a00:1098:0:86:1000:23:0:2]) by smtp.gmail.com with ESMTPSA id 62sm2854322wrq.35.2017.08.17.08.51.22 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 17 Aug 2017 08:51:22 -0700 (PDT) Date: Thu, 17 Aug 2017 16:51:20 +0100 From: Leif Lindholm To: Jun Nie Cc: haojian.zhuang@linaro.org, ard.biesheuvel@linaro.org, linaro-uefi@lists.linaro.org, shawn.guo@linaro.org, jason.liu@linaro.org, lersek@redhat.com, edk2-devel@lists.01.org Message-ID: <20170817155120.ubwuhgiabv2qvdtp@bivouac.eciton.net> References: <1502287959-16806-1-git-send-email-jun.nie@linaro.org> <20170810130447.2d42o6gsmeuz7gdb@bivouac.eciton.net> MIME-Version: 1.0 In-Reply-To: User-Agent: NeoMutt/20170113 (1.7.2) Subject: Re: [PATCH 1/4] Platforms: Add Sanchip Zx296718 basic library X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 17 Aug 2017 15:48:57 -0000 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit On Thu, Aug 17, 2017 at 11:42:23PM +0800, Jun Nie wrote: > On 2017年08月10日 21:04, Leif Lindholm wrote: > > > diff --git a/Silicon/Sanchip/Zx296718/Include/Zx296718.h b/Silicon/Sanchip/Zx296718/Include/Zx296718.h > > > new file mode 100644 > > > index 0000000..3ace9ab > > > --- /dev/null > > > +++ b/Silicon/Sanchip/Zx296718/Include/Zx296718.h > > > @@ -0,0 +1,30 @@ > > > +/** @file > > > +* > > > +* Copyright (c) 2016, Linaro Limited. All rights reserved. > > > > Guess 2016-2017 by now? > > > > > +* > > > +* This program and the accompanying materials > > > +* are licensed and made available under the terms and conditions of the BSD License > > > +* which accompanies this distribution. The full text of the license may be found at > > > +* http://opensource.org/licenses/bsd-license.php > > > +* > > > +* THE PROGRAM IS DISTRIBUTED UNDER THE BSD LICENSE ON AN "AS IS" BASIS, > > > +* WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER EXPRESS OR IMPLIED. > > > +* > > > +**/ > > > + > > > +#ifndef __ZX296718_H__ > > > +#define __ZX296718_H__ > > > > Coding style specifies: > > "Every header file must have a ‘#ifndef FILE_NAME_H_’ and ‘#endif’ guard" > > so you could drop 3 of those underscores. > > Will change it. Is there any coding style readme file? Because I find most > of header file use __FILE_NAME_H__ sytle macro. Ah, yes - it helps knowing it exists :) It is the C Coding Standards document on https://github.com/tianocore/tianocore.github.io/wiki/EDK-II-Specifications You will potentially find other documents there useful as well. / Leif