From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wr0-x22e.google.com (mail-wr0-x22e.google.com [IPv6:2a00:1450:400c:c0c::22e]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 60B2D21E79037 for ; Thu, 17 Aug 2017 11:50:57 -0700 (PDT) Received: by mail-wr0-x22e.google.com with SMTP id 5so27037389wrz.5 for ; Thu, 17 Aug 2017 11:53:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to :user-agent; bh=PoG3DymKAj0yjZb3y9O6hazfm5pdBH/PL5VXFrlirAE=; b=AzqN0UZzlxywlsgQJ7uJqW+kxiAWIPxdGZAxRTVDH4L5MsBgo6OMie+ZYcFgWsRyza exhEvU54CfUuFhyurtDowRmQD+mws/7MY0Qv/gHPLWyMFyJq2ltNoqOC8bTrCQTg+grD yubp+f22UeDvqxIw7OsZjc4S8uojkdJy2NElU= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to:user-agent; bh=PoG3DymKAj0yjZb3y9O6hazfm5pdBH/PL5VXFrlirAE=; b=fB6dVYdI3pMzIJtWMwe3S7Fmr+7gt1fuUYIcVNQoYaPryV3M0MMoIJgXTOKZZWZLOC VqoUvg9jwhyZaHBWf7N36BYio4YQgGQ9gZEOy2mEfziOVedER94fq3Xnd13Z9wG67eSQ FKB11ctdF2Uo7XmLOKpClZc1h7dqs1gf4RoBOli1rt+8YaxVpc6Gf0dqds8QZ3aEPvZ2 SircXjpPOf6PU27jtcJ/an1GbyX9dPSHW135TSAf5lI5CSN+jltImQYSykZHrsyXJJ6s EnIT8FP6iDIHPAIaRNqdK5W7TpexSuxNNavdypPDx2q62uIikkqqbupSrDIJeWx+jsjO TDdQ== X-Gm-Message-State: AHYfb5jGo0mPOZ2noY9jDg4UV7aujqKbShiGS1OAR1zo7FkfzOaA5M3r l4ur3Q9FUX/FdPOb X-Received: by 10.223.199.135 with SMTP id l7mr3691841wrg.282.1502996002993; Thu, 17 Aug 2017 11:53:22 -0700 (PDT) Received: from bivouac.eciton.net (bivouac.eciton.net. [2a00:1098:0:86:1000:23:0:2]) by smtp.gmail.com with ESMTPSA id 67sm2270401wrm.29.2017.08.17.11.53.21 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 17 Aug 2017 11:53:22 -0700 (PDT) Date: Thu, 17 Aug 2017 19:53:19 +0100 From: Leif Lindholm To: Jun Nie Cc: haojian.zhuang@linaro.org, ard.biesheuvel@linaro.org, linaro-uefi@lists.linaro.org, shawn.guo@linaro.org, jason.liu@linaro.org, edk2-devel@lists.01.org Message-ID: <20170817185319.lf7ibembmsmmqvyy@bivouac.eciton.net> References: <1502287959-16806-1-git-send-email-jun.nie@linaro.org> <1502287959-16806-3-git-send-email-jun.nie@linaro.org> <20170810144126.nwezbmz5kjmrbqgs@bivouac.eciton.net> <199e58f3-e6d5-6717-1798-4eb48f565f7c@linaro.org> MIME-Version: 1.0 In-Reply-To: <199e58f3-e6d5-6717-1798-4eb48f565f7c@linaro.org> User-Agent: NeoMutt/20170113 (1.7.2) Subject: Re: [PATCH 3/4] Platforms/zx: Add boot manager lib and entries X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 17 Aug 2017 18:50:57 -0000 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit On Thu, Aug 17, 2017 at 11:45:52PM +0800, Jun Nie wrote: > On 2017年08月10日 22:41, Leif Lindholm wrote: > > On Wed, Aug 09, 2017 at 10:12:38PM +0800, Jun Nie wrote: > > > Add boot manager lib and entries, including Android and Grub. > > > > > > Contributed-under: TianoCore Contribution Agreement 1.0 > > > Signed-off-by: Jun Nie > > > --- > > > .../Drivers/Zx296718EvbDxe/Zx296718EvbDxe.c | 105 ++++++ > > > .../Drivers/Zx296718EvbDxe/Zx296718EvbDxe.inf | 66 ++++ > > > .../Library/PlatformBootManagerLib/PlatformBm.c | 404 +++++++++++++++++++++ > > > .../Library/PlatformBootManagerLib/PlatformBm.h | 30 ++ > > > .../PlatformBootManagerLib.inf | 91 +++++ > > > Silicon/Sanchip/SanchipPkg.dec | 29 ++ > > > 6 files changed, 725 insertions(+) > > > create mode 100644 Platform/Sanchip/Zx296718Evb/Drivers/Zx296718EvbDxe/Zx296718EvbDxe.c > > > create mode 100644 Platform/Sanchip/Zx296718Evb/Drivers/Zx296718EvbDxe/Zx296718EvbDxe.inf > > > create mode 100644 Silicon/Sanchip/Library/PlatformBootManagerLib/PlatformBm.c > > > create mode 100644 Silicon/Sanchip/Library/PlatformBootManagerLib/PlatformBm.h > > > create mode 100644 Silicon/Sanchip/Library/PlatformBootManagerLib/PlatformBootManagerLib.inf > > > create mode 100644 Silicon/Sanchip/SanchipPkg.dec > > > > > > diff --git a/Silicon/Sanchip/SanchipPkg.dec b/Silicon/Sanchip/SanchipPkg.dec > > > new file mode 100644 > > > index 0000000..92d439d > > > --- /dev/null > > > +++ b/Silicon/Sanchip/SanchipPkg.dec > > > @@ -0,0 +1,29 @@ > > > +# > > > +# Copyright (C) 2017 Sanechips Technology Co., Ltd. > > > +# Copyright (c) 2017, Linaro Ltd. > > > +# > > > +# This program and the accompanying materials > > > +# are licensed and made available under the terms and conditions of the BSD License > > > +# which accompanies this distribution. The full text of the license may be found at > > > +# http://opensource.org/licenses/bsd-license.php > > > +# > > > +# THE PROGRAM IS DISTRIBUTED UNDER THE BSD LICENSE ON AN "AS IS" BASIS, > > > +# WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER EXPRESS OR IMPLIED. > > > +# > > > + > > > +[Defines] > > > + DEC_SPECIFICATION = 0x00010005 > > > > 0x00010019/1.25. > > > > > + PACKAGE_NAME = SanchipPkg > > > + PACKAGE_GUID = f991248f-9e21-4e4f-b344-eaad28e42ec0 > > > + PACKAGE_VERSION = 0.1 > > > + > > > +[Includes.common] > > > + Include # Root include for the package > > > > This directory does not exist, causing compliation to fail. > > Test shows that this include entry is unnecessary. > > > > > + > > > +[Guids.common] > > > + gSanchipTokenSpaceGuid = { 0x9589ba86, 0x58e6, 0x426c, { 0xbb, 0x39, 0x21, 0xf5, 0x68, 0x78, 0xe4, 0x27 } } > > > + > > > +[PcdsFixedAtBuild.common] > > > + gSanchipTokenSpaceGuid.PcdAndroidBootFile|{ 0x36, 0x8b, 0x73, 0x3a, 0xc5, 0xb9, 0x63, 0x47, 0xab, 0xbd, 0x6c, 0xbd, 0x4b, 0x25, 0xf9, 0xff }|VOID*|0x00000003 > > > > What? > > PcdAndroidBootFile is FileGuid for AndroidBoot app file, as PcdShellFile > Guid in other places. Do you want to hardcode the Guid in PlatformBm.c > library code? But you are not setting it in your platform description file, so what's the point of declaring it here? Also, it does not feel like something that belongs in a platform-specific .dec. It would make a lot more sense to me in edk2 EmbeddedPkg/EmbeddedPkg.dec. / Leif