From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com [66.111.4.25]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 63F2C21D2E634 for ; Sun, 20 Aug 2017 12:31:16 -0700 (PDT) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id B1ED620A76; Sun, 20 Aug 2017 15:33:46 -0400 (EDT) Received: from frontend2 ([10.202.2.161]) by compute1.internal (MEProxy); Sun, 20 Aug 2017 15:33:46 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:date:from:in-reply-to:message-id :references:subject:to:x-me-sender:x-me-sender:x-sasl-enc :x-sasl-enc; s=fm1; bh=miv+aIEn9+4iuCG+xYeufra+GIqE3cpG4w1zmqZeU Xk=; b=awa+sOtU3GytzzFSUccdG2GKM0x8QhykMW9JqkS+xTWHJbX2OXOb0/r7n o6bvmSR9981KPEO+EieCvRv6LM9qY8TFaF63JFy+ZkYFLE9b/O1b7FuA8U+BV6sK QTcIU72S4JN/CAxK2WIB8XNTbu57IJ4Pdjxj/8/BN+Rg9n9DhFiKRWxEXhP8/wBr Rc1YCyyqXo9N//jX7VRUBXl1okoKNzUH3KrfhqGBandNcgyMsMTYzlFd1ifwYy1a K56NVbgCTiopFldFzfDwT9wANb49vUMBD0mY/t5ICXVtfM7tikfHnimp/Mkq34ah 2flQQDPGZfO3VzVv0Y40iQAw0n5Ng== X-ME-Sender: X-Sasl-enc: LqwMryM6bFGXOAE+kxSQica1rXtScy6rUu/HY+I7b01p 1503257626 Received: from localhost.localdomain (c-71-226-23-158.hsd1.fl.comcast.net [71.226.23.158]) by mail.messagingengine.com (Postfix) with ESMTPA id 22B5A24233; Sun, 20 Aug 2017 15:33:46 -0400 (EDT) From: Alan Ott To: leif.lindholm@linaro.org, ard.biesheuvel@linaro.org Cc: edk2-devel@lists.01.org, linaro-uefi@lists.linaro.org, Alan Ott Date: Sun, 20 Aug 2017 15:33:33 -0400 Message-Id: <20170820193335.21471-2-alan@softiron.com> X-Mailer: git-send-email 2.9.3 In-Reply-To: <20170820193335.21471-1-alan@softiron.com> References: <20170820193335.21471-1-alan@softiron.com> Subject: [PATCH v2 edk2-platforms 1/3] Silicon/AMD/Styx: Make PcdSataPortMode 32 bits X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 20 Aug 2017 19:31:16 -0000 Extra bits are needed to accomodate all 14 SATA ports Signed-off-by: Alan Ott Contributed-under: TianoCore Contribution Agreement 1.0 --- Silicon/AMD/Styx/AmdStyx.dec | 2 +- Silicon/AMD/Styx/Drivers/StyxSataPlatformDxe/InitController.c | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/Silicon/AMD/Styx/AmdStyx.dec b/Silicon/AMD/Styx/AmdStyx.dec index ddd5bf4..c6eebe6 100644 --- a/Silicon/AMD/Styx/AmdStyx.dec +++ b/Silicon/AMD/Styx/AmdStyx.dec @@ -54,7 +54,7 @@ gAmdStyxTokenSpaceGuid.PcdSata0CtrlAxiSlvPort|0xE0300000|UINT32|0x00020000 gAmdStyxTokenSpaceGuid.PcdSata0PortCount|8|UINT8|0x00020001 gAmdStyxTokenSpaceGuid.PcdSataPi|0xFF|UINT32|0x00020002 - gAmdStyxTokenSpaceGuid.PcdSataPortMode|0|UINT16|0x00020003 + gAmdStyxTokenSpaceGuid.PcdSataPortMode|0|UINT32|0x00020003 gAmdStyxTokenSpaceGuid.PcdSataPortMpsp|TRUE|BOOLEAN|0x00020004 gAmdStyxTokenSpaceGuid.PcdSataSmpsSupport|FALSE|BOOLEAN|0x00020005 gAmdStyxTokenSpaceGuid.PcdSataSssSupport|TRUE|BOOLEAN|0x00020006 diff --git a/Silicon/AMD/Styx/Drivers/StyxSataPlatformDxe/InitController.c b/Silicon/AMD/Styx/Drivers/StyxSataPlatformDxe/InitController.c index 1958d91..78c6819 100644 --- a/Silicon/AMD/Styx/Drivers/StyxSataPlatformDxe/InitController.c +++ b/Silicon/AMD/Styx/Drivers/StyxSataPlatformDxe/InitController.c @@ -110,8 +110,8 @@ InitializeSataController ( SataChPerSerdes = FixedPcdGet8 (PcdSataNumChPerSerdes); for (PortNum = 0; PortNum < SataPortCount; PortNum += SataChPerSerdes) { - EvenPort = (UINT32)(FixedPcdGet16 (PcdSataPortMode) >> (PortNum * 2)) & 3; - OddPort = (UINT32)(FixedPcdGet16 (PcdSataPortMode) >> ((PortNum+1) * 2)) & 3; + EvenPort = (UINT32)(FixedPcdGet32 (PcdSataPortMode) >> (PortNum * 2)) & 3; + OddPort = (UINT32)(FixedPcdGet32 (PcdSataPortMode) >> ((PortNum+1) * 2)) & 3; SataPhyInit ((StartPort + PortNum) / SataChPerSerdes, EvenPort, OddPort); } -- 2.9.3