public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: Alan Ott <alan@softiron.com>
To: leif.lindholm@linaro.org, ard.biesheuvel@linaro.org
Cc: edk2-devel@lists.01.org, linaro-uefi@lists.linaro.org,
	Alan Ott <alan@softiron.com>
Subject: [PATCH v2 edk2-platforms 3/3] Platform/AMD/OverdriveBoard: Re-enable the second SATA Controller
Date: Sun, 20 Aug 2017 15:33:35 -0400	[thread overview]
Message-ID: <20170820193335.21471-4-alan@softiron.com> (raw)
In-Reply-To: <20170820193335.21471-1-alan@softiron.com>

The comment indicating that only the first SATA controller is operational
on SoftIron-branded OverDrive 3000 boards is incorrect. Re-enable the
second SATA controller.

Signed-off-by: Alan Ott <alan@softiron.com>
Contributed-under: TianoCore Contribution Agreement 1.0
---
 Platform/AMD/OverdriveBoard/OverdriveBoard.dsc | 10 +++-------
 1 file changed, 3 insertions(+), 7 deletions(-)

diff --git a/Platform/AMD/OverdriveBoard/OverdriveBoard.dsc b/Platform/AMD/OverdriveBoard/OverdriveBoard.dsc
index f256ffb..2881de3 100644
--- a/Platform/AMD/OverdriveBoard/OverdriveBoard.dsc
+++ b/Platform/AMD/OverdriveBoard/OverdriveBoard.dsc
@@ -409,14 +409,10 @@ DEFINE DO_FLASHER   = FALSE
   gArmTokenSpaceGuid.PcdGicDistributorBase|0xE1110000
   gArmTokenSpaceGuid.PcdGicInterruptInterfaceBase|0xE112F000
 
-  #
-  # AMD's B1 based Overdrive has 14 SATA ports across 2 controllers. However,
-  # it appears that Softiron's Overdrive 3000, which is also B1 based, does
-  # not have the second SATA controller enabled, and any attempts to use it
-  # will crash the firmware. So use the first controller only.
-  #
+  # SATA Ports
   gAmdStyxTokenSpaceGuid.PcdSata0PortCount|8
-  gAmdStyxTokenSpaceGuid.PcdSataPortMode|0xffff
+  gAmdStyxTokenSpaceGuid.PcdSata1PortCount|6
+  gAmdStyxTokenSpaceGuid.PcdSataPortMode|0x0fffffff
 
   # PCIe Support
   gEfiMdePkgTokenSpaceGuid.PcdPciExpressBaseAddress|0xF0000000
-- 
2.9.3



  parent reply	other threads:[~2017-08-20 19:31 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-08-20 19:33 [PATCH v2 edk2-platforms 0/3] Re-enable the second SATA controller on Overdrive Alan Ott
2017-08-20 19:33 ` [PATCH v2 edk2-platforms 1/3] Silicon/AMD/Styx: Make PcdSataPortMode 32 bits Alan Ott
2017-08-20 19:33 ` [PATCH v2 edk2-platforms 2/3] Silicon/AMD/Styx: Use PcdSataPortMode properly for two controllers Alan Ott
2017-08-20 19:33 ` Alan Ott [this message]
2017-08-20 19:52 ` [PATCH v2 edk2-platforms 0/3] Re-enable the second SATA controller on Overdrive Ard Biesheuvel
2017-08-21 14:12 ` Leif Lindholm
2017-08-21 14:20   ` Alan Ott
2017-08-21 17:17     ` Leif Lindholm

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170820193335.21471-4-alan@softiron.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox