From: Leif Lindholm <leif.lindholm@linaro.org>
To: Ard Biesheuvel <ard.biesheuvel@linaro.org>
Cc: edk2-devel@lists.01.org
Subject: Re: [PATCH edk2-platforms] Silicon/Hisilicon/SasV1Dxe: remove bogus UncachedMemoryAllocationLib ref
Date: Tue, 29 Aug 2017 16:19:51 +0100 [thread overview]
Message-ID: <20170829151951.ggzaxbwvzhgc2pxw@bivouac.eciton.net> (raw)
In-Reply-To: <20170829150807.12122-1-ard.biesheuvel@linaro.org>
On Tue, Aug 29, 2017 at 04:08:07PM +0100, Ard Biesheuvel wrote:
> This driver does not actually use UncachedMemoryAllocationLib anymore,
> so remove the bogus reference.
>
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
Reviewed-by: Leif Lindholm <leif.lindholm@linaro.org>
> ---
> Silicon/Hisilicon/Drivers/SasV1Dxe/SasV1Dxe.c | 1 -
> Silicon/Hisilicon/Drivers/SasV1Dxe/SasV1Dxe.inf | 1 -
> 2 files changed, 2 deletions(-)
>
> diff --git a/Silicon/Hisilicon/Drivers/SasV1Dxe/SasV1Dxe.c b/Silicon/Hisilicon/Drivers/SasV1Dxe/SasV1Dxe.c
> index 18085c43c54e..d876565a7d23 100644
> --- a/Silicon/Hisilicon/Drivers/SasV1Dxe/SasV1Dxe.c
> +++ b/Silicon/Hisilicon/Drivers/SasV1Dxe/SasV1Dxe.c
> @@ -26,7 +26,6 @@
> #include <Library/TimerLib.h>
> #include <Library/UefiBootServicesTableLib.h>
> #include <Library/UefiLib.h>
> -#include <Library/UncachedMemoryAllocationLib.h>
>
> #include <Protocol/PlatformSasProtocol.h>
> #include <Protocol/ScsiPassThruExt.h>
> diff --git a/Silicon/Hisilicon/Drivers/SasV1Dxe/SasV1Dxe.inf b/Silicon/Hisilicon/Drivers/SasV1Dxe/SasV1Dxe.inf
> index 7e65cc819cee..fe0be239b735 100644
> --- a/Silicon/Hisilicon/Drivers/SasV1Dxe/SasV1Dxe.inf
> +++ b/Silicon/Hisilicon/Drivers/SasV1Dxe/SasV1Dxe.inf
> @@ -39,7 +39,6 @@
> TimerLib
> UefiDriverEntryPoint
> UefiLib
> - UncachedMemoryAllocationLib
>
> [Protocols]
> gEfiExtScsiPassThruProtocolGuid
> --
> 2.11.0
>
prev parent reply other threads:[~2017-08-29 15:17 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-29 15:08 [PATCH edk2-platforms] Silicon/Hisilicon/SasV1Dxe: remove bogus UncachedMemoryAllocationLib ref Ard Biesheuvel
2017-08-29 15:19 ` Leif Lindholm [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170829151951.ggzaxbwvzhgc2pxw@bivouac.eciton.net \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox