public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
* [PATCH edk2-platforms] Silicon/Hisilicon/SasV1Dxe: remove bogus UncachedMemoryAllocationLib ref
@ 2017-08-29 15:08 Ard Biesheuvel
  2017-08-29 15:19 ` Leif Lindholm
  0 siblings, 1 reply; 2+ messages in thread
From: Ard Biesheuvel @ 2017-08-29 15:08 UTC (permalink / raw)
  To: edk2-devel, leif.lindholm; +Cc: Ard Biesheuvel

This driver does not actually use UncachedMemoryAllocationLib anymore,
so remove the bogus reference.

Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
---
 Silicon/Hisilicon/Drivers/SasV1Dxe/SasV1Dxe.c   | 1 -
 Silicon/Hisilicon/Drivers/SasV1Dxe/SasV1Dxe.inf | 1 -
 2 files changed, 2 deletions(-)

diff --git a/Silicon/Hisilicon/Drivers/SasV1Dxe/SasV1Dxe.c b/Silicon/Hisilicon/Drivers/SasV1Dxe/SasV1Dxe.c
index 18085c43c54e..d876565a7d23 100644
--- a/Silicon/Hisilicon/Drivers/SasV1Dxe/SasV1Dxe.c
+++ b/Silicon/Hisilicon/Drivers/SasV1Dxe/SasV1Dxe.c
@@ -26,7 +26,6 @@
 #include <Library/TimerLib.h>
 #include <Library/UefiBootServicesTableLib.h>
 #include <Library/UefiLib.h>
-#include <Library/UncachedMemoryAllocationLib.h>
 
 #include <Protocol/PlatformSasProtocol.h>
 #include <Protocol/ScsiPassThruExt.h>
diff --git a/Silicon/Hisilicon/Drivers/SasV1Dxe/SasV1Dxe.inf b/Silicon/Hisilicon/Drivers/SasV1Dxe/SasV1Dxe.inf
index 7e65cc819cee..fe0be239b735 100644
--- a/Silicon/Hisilicon/Drivers/SasV1Dxe/SasV1Dxe.inf
+++ b/Silicon/Hisilicon/Drivers/SasV1Dxe/SasV1Dxe.inf
@@ -39,7 +39,6 @@
   TimerLib
   UefiDriverEntryPoint
   UefiLib
-  UncachedMemoryAllocationLib
 
 [Protocols]
   gEfiExtScsiPassThruProtocolGuid
-- 
2.11.0



^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH edk2-platforms] Silicon/Hisilicon/SasV1Dxe: remove bogus UncachedMemoryAllocationLib ref
  2017-08-29 15:08 [PATCH edk2-platforms] Silicon/Hisilicon/SasV1Dxe: remove bogus UncachedMemoryAllocationLib ref Ard Biesheuvel
@ 2017-08-29 15:19 ` Leif Lindholm
  0 siblings, 0 replies; 2+ messages in thread
From: Leif Lindholm @ 2017-08-29 15:19 UTC (permalink / raw)
  To: Ard Biesheuvel; +Cc: edk2-devel

On Tue, Aug 29, 2017 at 04:08:07PM +0100, Ard Biesheuvel wrote:
> This driver does not actually use UncachedMemoryAllocationLib anymore,
> so remove the bogus reference.
> 
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>

Reviewed-by: Leif Lindholm <leif.lindholm@linaro.org>

> ---
>  Silicon/Hisilicon/Drivers/SasV1Dxe/SasV1Dxe.c   | 1 -
>  Silicon/Hisilicon/Drivers/SasV1Dxe/SasV1Dxe.inf | 1 -
>  2 files changed, 2 deletions(-)
> 
> diff --git a/Silicon/Hisilicon/Drivers/SasV1Dxe/SasV1Dxe.c b/Silicon/Hisilicon/Drivers/SasV1Dxe/SasV1Dxe.c
> index 18085c43c54e..d876565a7d23 100644
> --- a/Silicon/Hisilicon/Drivers/SasV1Dxe/SasV1Dxe.c
> +++ b/Silicon/Hisilicon/Drivers/SasV1Dxe/SasV1Dxe.c
> @@ -26,7 +26,6 @@
>  #include <Library/TimerLib.h>
>  #include <Library/UefiBootServicesTableLib.h>
>  #include <Library/UefiLib.h>
> -#include <Library/UncachedMemoryAllocationLib.h>
>  
>  #include <Protocol/PlatformSasProtocol.h>
>  #include <Protocol/ScsiPassThruExt.h>
> diff --git a/Silicon/Hisilicon/Drivers/SasV1Dxe/SasV1Dxe.inf b/Silicon/Hisilicon/Drivers/SasV1Dxe/SasV1Dxe.inf
> index 7e65cc819cee..fe0be239b735 100644
> --- a/Silicon/Hisilicon/Drivers/SasV1Dxe/SasV1Dxe.inf
> +++ b/Silicon/Hisilicon/Drivers/SasV1Dxe/SasV1Dxe.inf
> @@ -39,7 +39,6 @@
>    TimerLib
>    UefiDriverEntryPoint
>    UefiLib
> -  UncachedMemoryAllocationLib
>  
>  [Protocols]
>    gEfiExtScsiPassThruProtocolGuid
> -- 
> 2.11.0
> 


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2017-08-29 15:17 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-08-29 15:08 [PATCH edk2-platforms] Silicon/Hisilicon/SasV1Dxe: remove bogus UncachedMemoryAllocationLib ref Ard Biesheuvel
2017-08-29 15:19 ` Leif Lindholm

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox