public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: Ard Biesheuvel <ard.biesheuvel@linaro.org>
To: edk2-devel@lists.01.org, leif.lindholm@linaro.org
Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org>
Subject: [PATCH 0/6] ArmPkg EmbeddedPkg: clean up DmaLib implementations
Date: Wed, 30 Aug 2017 09:21:02 +0100	[thread overview]
Message-ID: <20170830082108.7470-1-ard.biesheuvel@linaro.org> (raw)

Currently, we have two DmaLib implementations: a cache coherent one called
'NullDmaLib' residing in EmbeddedPkg, and a non-cache coherent one called
'ArmDmaLib', residinh in ArmPkg.

In both cases, this is slightly awkward: NullDmaLib suggests no functionality
whatsoever, which is slightly misleading because 'nothing' is the correct
action in case of cache coherent DMA, rather than a lack of action. As for
ArmDmalib, this was never specific to ARM, and no longer depends on anything
that ArmPkg provides, so it does not really belong in ArmPkg anymore.

So let's rename them to CoherentDmaLib and NonCoherentDmaLib, respectively,
and move that latter into EmbeddedPkg where it arguably belongs. To align
the two further, add support for non-1:1 DMA mappings to CoherentDmaLib as
well.

Note that the final patch can only be merged after out-of-tree platforms
have switched from ArmDmaLib to NonCoherentDmaLib.

Ard Biesheuvel (6):
  EmbeddedPkg: rename NullDmaLib to CoherentDmaLib
  EmbeddedPkg/CoherentDmaLib: add support for non-1:1 DMA translation
  EmbeddedPkg: implement NonCoherentDmaLib based on ArmDmaLib
  Omap35xxPkg: switch to EmbeddedPkg's NonCoherentDmaLib
  BeagleBoardPkg: switch to generic non-coherent DmaLib
  ArmPkg: remove ArmDmaLib

 ArmPkg/ArmPkg.dsc                                                                                 |   2 -
 ArmPkg/Library/ArmDmaLib/ArmDmaLib.inf                                                            |  49 ---------
 BeagleBoardPkg/BeagleBoardPkg.dsc                                                                 |   2 +-
 EmbeddedPkg/EmbeddedPkg.dec                                                                       |   7 ++
 EmbeddedPkg/EmbeddedPkg.dsc                                                                       |   3 +-
 EmbeddedPkg/Library/{NullDmaLib/NullDmaLib.c => CoherentDmaLib/CoherentDmaLib.c}                  |  10 +-
 EmbeddedPkg/Library/{NullDmaLib/NullDmaLib.inf => CoherentDmaLib/CoherentDmaLib.inf}              |  19 ++--
 ArmPkg/Library/ArmDmaLib/ArmDmaLib.c => EmbeddedPkg/Library/NonCoherentDmaLib/NonCoherentDmaLib.c | 105 +++++++++++---------
 EmbeddedPkg/Library/NonCoherentDmaLib/NonCoherentDmaLib.inf                                       |  50 ++++++++++
 Omap35xxPkg/Omap35xxPkg.dsc                                                                       |   2 +-
 10 files changed, 136 insertions(+), 113 deletions(-)
 delete mode 100644 ArmPkg/Library/ArmDmaLib/ArmDmaLib.inf
 rename EmbeddedPkg/Library/{NullDmaLib/NullDmaLib.c => CoherentDmaLib/CoherentDmaLib.c} (94%)
 rename EmbeddedPkg/Library/{NullDmaLib/NullDmaLib.inf => CoherentDmaLib/CoherentDmaLib.inf} (75%)
 rename ArmPkg/Library/ArmDmaLib/ArmDmaLib.c => EmbeddedPkg/Library/NonCoherentDmaLib/NonCoherentDmaLib.c (82%)
 create mode 100644 EmbeddedPkg/Library/NonCoherentDmaLib/NonCoherentDmaLib.inf

-- 
2.11.0



             reply	other threads:[~2017-08-30  8:18 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-08-30  8:21 Ard Biesheuvel [this message]
2017-08-30  8:21 ` [PATCH 1/6] EmbeddedPkg: rename NullDmaLib to CoherentDmaLib Ard Biesheuvel
2017-08-30 10:46   ` Leif Lindholm
2017-08-30 10:52     ` Ard Biesheuvel
2017-08-30 11:37       ` Leif Lindholm
2017-08-30  8:21 ` [PATCH 2/6] EmbeddedPkg/CoherentDmaLib: add support for non-1:1 DMA translation Ard Biesheuvel
2017-08-30 10:51   ` Leif Lindholm
2017-08-30 10:54     ` Ard Biesheuvel
2017-08-30 11:47       ` Leif Lindholm
2017-08-30  8:21 ` [PATCH 3/6] EmbeddedPkg: implement NonCoherentDmaLib based on ArmDmaLib Ard Biesheuvel
2017-08-30 13:05   ` Leif Lindholm
2017-08-30  8:21 ` [PATCH 4/6] Omap35xxPkg: switch to EmbeddedPkg's NonCoherentDmaLib Ard Biesheuvel
2017-08-30  8:21 ` [PATCH 5/6] BeagleBoardPkg: switch to generic non-coherent DmaLib Ard Biesheuvel
2017-08-30  8:21 ` [PATCH 6/6] ArmPkg: remove ArmDmaLib Ard Biesheuvel
2017-08-30 13:06 ` [PATCH 0/6] ArmPkg EmbeddedPkg: clean up DmaLib implementations Leif Lindholm
2017-08-30 13:17   ` Ard Biesheuvel
2017-09-01 12:01     ` Ard Biesheuvel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170830082108.7470-1-ard.biesheuvel@linaro.org \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox