From: Leif Lindholm <leif.lindholm@linaro.org>
To: Ard Biesheuvel <ard.biesheuvel@linaro.org>
Cc: "edk2-devel@lists.01.org" <edk2-devel@lists.01.org>
Subject: Re: [PATCH] ArmPlatformPkg/ArmJunoDxe: remove bogus DmaLib dependency
Date: Wed, 30 Aug 2017 10:33:16 +0100 [thread overview]
Message-ID: <20170830093316.jkek4extm45g5zqh@bivouac.eciton.net> (raw)
In-Reply-To: <CAKv+Gu9ACJwwG4=2Z-Ny5a9JKuwf3uF6f_0t0m4rt+SKDavqcQ@mail.gmail.com>
On Wed, Aug 30, 2017 at 10:31:22AM +0100, Ard Biesheuvel wrote:
> On 30 August 2017 at 10:30, Ard Biesheuvel <ard.biesheuvel@linaro.org> wrote:
> > This driver does not support on DmaLib, so don't declare it as a
> > dependency.
> >
>
> -EGRAMMAR
>
> Will fix before submitting
With that:
Reviewed-by: Leif Lindholm <leif.lindholm@linaro.org>
> > Contributed-under: TianoCore Contribution Agreement 1.1
> > Signed-off-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
> > ---
> > ArmPlatformPkg/ArmJunoPkg/Drivers/ArmJunoDxe/ArmJunoDxe.inf | 1 -
> > 1 file changed, 1 deletion(-)
> >
> > diff --git a/ArmPlatformPkg/ArmJunoPkg/Drivers/ArmJunoDxe/ArmJunoDxe.inf b/ArmPlatformPkg/ArmJunoPkg/Drivers/ArmJunoDxe/ArmJunoDxe.inf
> > index 6719d0adcc87..0fc8bd88c6ce 100644
> > --- a/ArmPlatformPkg/ArmJunoPkg/Drivers/ArmJunoDxe/ArmJunoDxe.inf
> > +++ b/ArmPlatformPkg/ArmJunoPkg/Drivers/ArmJunoDxe/ArmJunoDxe.inf
> > @@ -37,7 +37,6 @@ [LibraryClasses]
> > ArmShellCmdRunAxfLib
> > BaseMemoryLib
> > DebugLib
> > - DmaLib
> > DxeServicesTableLib
> > IoLib
> > NonDiscoverableDeviceRegistrationLib
> > --
> > 2.11.0
> >
next prev parent reply other threads:[~2017-08-30 9:30 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-30 9:30 [PATCH] ArmPlatformPkg/ArmJunoDxe: remove bogus DmaLib dependency Ard Biesheuvel
2017-08-30 9:31 ` Ard Biesheuvel
2017-08-30 9:33 ` Leif Lindholm [this message]
2017-08-30 9:35 ` Ard Biesheuvel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170830093316.jkek4extm45g5zqh@bivouac.eciton.net \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox