From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wr0-x229.google.com (mail-wr0-x229.google.com [IPv6:2a00:1450:400c:c0c::229]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id CC1C021E95E04 for ; Wed, 30 Aug 2017 03:44:16 -0700 (PDT) Received: by mail-wr0-x229.google.com with SMTP id k94so17401743wrc.0 for ; Wed, 30 Aug 2017 03:46:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=ZVBYFV2B7pONM7ID1de/K5ETlz3F/o0ygFoux0ygUvQ=; b=MacAUR4TyxjP2F7+VOBGk359A2B+UEFBorQQMoGPuaS2hv4KRe+QTA3dH610uwbXan 1H0m1Wuf+LbREu0wAc7JLruJ8lIUSjPPFZKmDiHbmwIjnoQKrX5Ar/f1uCkW5RWApdVG Quz1xtmBfFgeVPnTJFZFt3ksOrY05W6sag+dE= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=ZVBYFV2B7pONM7ID1de/K5ETlz3F/o0ygFoux0ygUvQ=; b=dJkx5kxYp+0N/DQj1gAx2FtdMgM4RqPnMjXFusvmU9K1h3jWENKaK+Orr++7SjonMk w43nJQOii0lsA58ACk8kfimEZaz1yhPEMnPz3jXQkwANt2irlMtqBmQUCjNoqk72oNLE vbBkPEHODIPwf9S86zs5slBmvaMi6WLbxYVweYhat9YXZybCIGb50fiber+/KnVfw999 bcVO7alp3naIVUUvnXAV8fbAIBNjwo+1FYyVXL8tdBz3PcCTumWOaiqCEHrc1nns4loW NAskMtjfd4RcKQTbuwpQUWk0X52oxX8InVDwO1hA6CLiqfxzWoinig8kKeKMPyXVLyIh r5Rw== X-Gm-Message-State: AHYfb5gY4uD80dXFrBMBlVx+mdrSiJX+Ik0QsDbpKgx4/ILtolZxsX7E mErY2OsdwaTNldta/mGEdg== X-Received: by 10.223.141.135 with SMTP id o7mr898297wrb.238.1504090016839; Wed, 30 Aug 2017 03:46:56 -0700 (PDT) Received: from bivouac.eciton.net (bivouac.eciton.net. [2a00:1098:0:86:1000:23:0:2]) by smtp.gmail.com with ESMTPSA id n13sm4517523wmg.2.2017.08.30.03.46.55 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 30 Aug 2017 03:46:56 -0700 (PDT) Date: Wed, 30 Aug 2017 11:46:54 +0100 From: Leif Lindholm To: Ard Biesheuvel Cc: edk2-devel@lists.01.org Message-ID: <20170830104654.345w3oo4u7fiag6d@bivouac.eciton.net> References: <20170830082108.7470-1-ard.biesheuvel@linaro.org> <20170830082108.7470-2-ard.biesheuvel@linaro.org> MIME-Version: 1.0 In-Reply-To: <20170830082108.7470-2-ard.biesheuvel@linaro.org> User-Agent: NeoMutt/20170113 (1.7.2) Subject: Re: [PATCH 1/6] EmbeddedPkg: rename NullDmaLib to CoherentDmaLib X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 30 Aug 2017 10:44:17 -0000 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Wed, Aug 30, 2017 at 09:21:03AM +0100, Ard Biesheuvel wrote: > Rename NullDmaLib to CoherentDmaLib to better reflect its nature, and > to better convey the fact that it actually serves a useful purpose, > i.e., as a DmaLib library class resolution for drivers that control > hardware that may only be cache coherent or in some cases (i.e., on > some platforms but not on others). The above doesn't read very well (and I'm not 100% certain what it's trying to say, so can't really propose an improvement). No other issues with patch. / Leif > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Ard Biesheuvel > --- > EmbeddedPkg/EmbeddedPkg.dsc | 2 +- > EmbeddedPkg/Library/{NullDmaLib/NullDmaLib.c => CoherentDmaLib/CoherentDmaLib.c} | 0 > EmbeddedPkg/Library/{NullDmaLib/NullDmaLib.inf => CoherentDmaLib/CoherentDmaLib.inf} | 20 ++++++-------------- > 3 files changed, 7 insertions(+), 15 deletions(-) > > diff --git a/EmbeddedPkg/EmbeddedPkg.dsc b/EmbeddedPkg/EmbeddedPkg.dsc > index 4a34e34843ad..84c5a842e37e 100644 > --- a/EmbeddedPkg/EmbeddedPkg.dsc > +++ b/EmbeddedPkg/EmbeddedPkg.dsc > @@ -250,7 +250,7 @@ [Components.common] > EmbeddedPkg/Library/TemplateResetSystemLib/TemplateResetSystemLib.inf > EmbeddedPkg/Library/TemplateRealTimeClockLib/TemplateRealTimeClockLib.inf > EmbeddedPkg/Library/LzmaHobCustomDecompressLib/LzmaHobCustomDecompressLib.inf > - EmbeddedPkg/Library/NullDmaLib/NullDmaLib.inf > + EmbeddedPkg/Library/CoherentDmaLib/CoherentDmaLib.inf > EmbeddedPkg/Library/DxeDtPlatformDtbLoaderLibDefault/DxeDtPlatformDtbLoaderLibDefault.inf > > EmbeddedPkg/Ebl/Ebl.inf > diff --git a/EmbeddedPkg/Library/NullDmaLib/NullDmaLib.c b/EmbeddedPkg/Library/CoherentDmaLib/CoherentDmaLib.c > similarity index 100% > rename from EmbeddedPkg/Library/NullDmaLib/NullDmaLib.c > rename to EmbeddedPkg/Library/CoherentDmaLib/CoherentDmaLib.c > diff --git a/EmbeddedPkg/Library/NullDmaLib/NullDmaLib.inf b/EmbeddedPkg/Library/CoherentDmaLib/CoherentDmaLib.inf > similarity index 78% > rename from EmbeddedPkg/Library/NullDmaLib/NullDmaLib.inf > rename to EmbeddedPkg/Library/CoherentDmaLib/CoherentDmaLib.inf > index 38261d5ede2b..c40a600cf6a3 100644 > --- a/EmbeddedPkg/Library/NullDmaLib/NullDmaLib.inf > +++ b/EmbeddedPkg/Library/CoherentDmaLib/CoherentDmaLib.inf > @@ -1,6 +1,8 @@ > #/** @file > # > # Copyright (c) 2008 - 2010, Apple Inc. All rights reserved.
> +# Copyright (c) 2017, Linaro, Ltd. All rights reserved.
> +# > # This program and the accompanying materials > # are licensed and made available under the terms and conditions of the BSD License > # which accompanies this distribution. The full text of the license may be found at > @@ -12,15 +14,15 @@ > #**/ > > [Defines] > - INF_VERSION = 0x00010005 > - BASE_NAME = NullDmaLib > + INF_VERSION = 0x00010019 > + BASE_NAME = CoherentDmaLib > FILE_GUID = 0F2A0816-D319-4ee7-A6B8-D58524E4428F > MODULE_TYPE = BASE > VERSION_STRING = 1.0 > LIBRARY_CLASS = DmaLib > > -[Sources.common] > - NullDmaLib.c > +[Sources] > + CoherentDmaLib.c > > [Packages] > MdePkg/MdePkg.dec > @@ -29,13 +31,3 @@ [Packages] > [LibraryClasses] > DebugLib > MemoryAllocationLib > - > - > -[Protocols] > - > -[Guids] > - > -[Pcd] > - > -[Depex] > - TRUE > -- > 2.11.0 >