Re: [PATCH 1/6] EmbeddedPkg: rename NullDmaLib to CoherentDmaLib

[Leif Lindholm <leif.lindholm@linaro.org>]

On Wed, Aug 30, 2017 at 11:52:26AM +0100, Ard Biesheuvel wrote:
> On 30 August 2017 at 11:46, Leif Lindholm <leif.lindholm@linaro.org> wrote:
> > On Wed, Aug 30, 2017 at 09:21:03AM +0100, Ard Biesheuvel wrote:
> >> Rename NullDmaLib to CoherentDmaLib to better reflect its nature, and
> >> to better convey the fact that it actually serves a useful purpose,
> >> i.e., as a DmaLib library class resolution for drivers that control
> >> hardware that may only be cache coherent or in some cases (i.e., on
> >> some platforms but not on others).
> >
> > The above doesn't read very well (and I'm not 100% certain what it's
> > trying to say, so can't really propose an improvement).
> > No other issues with patch.
> >
> 
> How about
> 
> """
> The name NullDmaLib suggests that this library is a placeholder that
> only exists to fulfil formal dependencies on the DmaLib library class
> without providing an actual implementation (*). This is not the case,
> though: NullDmaLib does implement DmaLib fully, but doing so simply
> requires very little effort on a cache coherent platform. So let's
> rename it to CoherentDmaLib instead.
> """
> 
> * there are such instances in MdeModulePkg that do nothing and
> ASSERT() in every function.

Indeed.
Yes, this looks fine to me:
Reviewed-by: Leif Lindholm <leif.lindholm@linaro.org>