From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wr0-x236.google.com (mail-wr0-x236.google.com [IPv6:2a00:1450:400c:c0c::236]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id BF7E221DF809E for ; Wed, 30 Aug 2017 04:35:12 -0700 (PDT) Received: by mail-wr0-x236.google.com with SMTP id p14so17769255wrg.3 for ; Wed, 30 Aug 2017 04:37:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=cQ9i3J0qZjMtpkH9dJMy76HD6kCg6tvlQg1wPXGkrhQ=; b=gOvibWEGmH6H5S5oETmPKJSetaxGmm+Su1NzVrc2Qyu/JvXkAsJBIiiE/99pzq8cbn ej42Vco0T6YdY4kkglsFJWuRhANYEBQkqxqLzo4f0hfWX425DVAorQjsoubvrqOs6k8u WDRVb7ewXRUHPcsiNrJ+sMBIXQ9avKnEpUl0w= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=cQ9i3J0qZjMtpkH9dJMy76HD6kCg6tvlQg1wPXGkrhQ=; b=YGRlihVHjsRTdc+TJTIKmqzkj6938R7iDSFZ3+cWOVHQZkwCMZkG61PEdNEZPm/Dcx QrkX3NcbHg2IHb9KISUuzOQNMdaP6+SknblsoQn7wlVUf3LmAq+lD+rGtLalEsbYihyc iivb2bx7Kfvj9s95kN7Fe/Y7Uz8z+We3YE6LizfGiVUd6aFk08mYNr93NWizsOqY98I1 BJoLEpxV7fTai/UVyplPgqUqlAwZ90oDFFIesSRjPb/g8KqIRRIHX8ACk+BN4ojYV6kv 2ezNy4J5gL+o7VFV6aFPSsMd2BP8rg6wubw71p8n4MuUOPUug8WtA12UOQljT/Q0fMmV APPg== X-Gm-Message-State: AHYfb5hrnqjOECPuaY60EHIQxmZhi79EQPUyuwfnsbOfHi5DYWJidvu5 +N3Qm4nbU6EQrLqu X-Received: by 10.223.172.54 with SMTP id v51mr1032599wrc.145.1504093072932; Wed, 30 Aug 2017 04:37:52 -0700 (PDT) Received: from bivouac.eciton.net (bivouac.eciton.net. [2a00:1098:0:86:1000:23:0:2]) by smtp.gmail.com with ESMTPSA id h30sm5950815wrf.11.2017.08.30.04.37.51 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 30 Aug 2017 04:37:52 -0700 (PDT) Date: Wed, 30 Aug 2017 12:37:50 +0100 From: Leif Lindholm To: Ard Biesheuvel Cc: "edk2-devel@lists.01.org" Message-ID: <20170830113750.enmtecmuyeifc52y@bivouac.eciton.net> References: <20170830082108.7470-1-ard.biesheuvel@linaro.org> <20170830082108.7470-2-ard.biesheuvel@linaro.org> <20170830104654.345w3oo4u7fiag6d@bivouac.eciton.net> MIME-Version: 1.0 In-Reply-To: User-Agent: NeoMutt/20170113 (1.7.2) Subject: Re: [PATCH 1/6] EmbeddedPkg: rename NullDmaLib to CoherentDmaLib X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 30 Aug 2017 11:35:13 -0000 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Wed, Aug 30, 2017 at 11:52:26AM +0100, Ard Biesheuvel wrote: > On 30 August 2017 at 11:46, Leif Lindholm wrote: > > On Wed, Aug 30, 2017 at 09:21:03AM +0100, Ard Biesheuvel wrote: > >> Rename NullDmaLib to CoherentDmaLib to better reflect its nature, and > >> to better convey the fact that it actually serves a useful purpose, > >> i.e., as a DmaLib library class resolution for drivers that control > >> hardware that may only be cache coherent or in some cases (i.e., on > >> some platforms but not on others). > > > > The above doesn't read very well (and I'm not 100% certain what it's > > trying to say, so can't really propose an improvement). > > No other issues with patch. > > > > How about > > """ > The name NullDmaLib suggests that this library is a placeholder that > only exists to fulfil formal dependencies on the DmaLib library class > without providing an actual implementation (*). This is not the case, > though: NullDmaLib does implement DmaLib fully, but doing so simply > requires very little effort on a cache coherent platform. So let's > rename it to CoherentDmaLib instead. > """ > > * there are such instances in MdeModulePkg that do nothing and > ASSERT() in every function. Indeed. Yes, this looks fine to me: Reviewed-by: Leif Lindholm