public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: Laszlo Ersek <lersek@redhat.com>
To: edk2-devel-01 <edk2-devel@lists.01.org>
Cc: Brijesh Singh <brijesh.singh@amd.com>,
	Jordan Justen <jordan.l.justen@intel.com>
Subject: [PATCH 00/11] OvmfPkg: improve SEV-related DEBUG messages
Date: Wed, 30 Aug 2017 17:53:06 +0200	[thread overview]
Message-ID: <20170830155317.30917-1-lersek@redhat.com> (raw)

Repo:   https://github.com/lersek/edk2.git
Branch: sev_debug_messages

I've now looked at quite a bit of SEV-related DEBUG messages, and I find
them really hard to read, and to process with command line utilities
like grep, sort, uniq.

For example, shell pipelines should be possible to construct with these
utilities to collect decrypt/encrypt operations, in chronological order,
grouped by address ever decrypted.

The log should also be human-readable as much as possible -- it
shouldn't be redundant, but all information for forward- and
back-referencing should be available.

I propose this series for the above improvements.

Cc: Brijesh Singh <brijesh.singh@amd.com>
Cc: Jordan Justen <jordan.l.justen@intel.com>

Thanks,
Laszlo

Laszlo Ersek (11):
  OvmfPkg/BaseMemEncryptSevLib: unify encrypt/decrypt DEBUG messages
  OvmfPkg/BaseMemEncryptSevLib: break DEBUG calls to multiple lines
  OvmfPkg/BaseMemEncryptSevLib: clean up DEBUG prefixes
  OvmfPkg/BaseMemEncryptSevLib: clean up debug logging of
    PhysicalAddress
  OvmfPkg/BaseMemEncryptSevLib: promote DEBUG_WARN levels to DEBUG_ERROR
  OvmfPkg/BaseMemEncryptSevLib: clean up upper-case / lower-case in
    DEBUGs
  OvmfPkg/BaseMemEncryptSevLib: fix typos in DEBUG messages
  OvmfPkg/IoMmuDxe: IoMmuMap(): log nicer and more informative DEBUG
    msgs
  OvmfPkg/IoMmuDxe: IoMmuUnmap(): clean up DEBUG message
  OvmfPkg/IoMmuDxe: IoMmuAllocateBuffer(): nicer and more informative
    DEBUGs
  OvmfPkg/IoMmuDxe: IoMmuFreeBuffer(): clean up DEBUG message

 OvmfPkg/IoMmuDxe/AmdSevIoMmu.c                           | 72 +++++++++++-----
 OvmfPkg/Library/BaseMemEncryptSevLib/X64/VirtualMemory.c | 89 ++++++++++++++------
 2 files changed, 110 insertions(+), 51 deletions(-)

-- 
2.14.1.3.gb7cf6e02401b



             reply	other threads:[~2017-08-30 15:53 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-08-30 15:53 Laszlo Ersek [this message]
2017-08-30 15:53 ` [PATCH 01/11] OvmfPkg/BaseMemEncryptSevLib: unify encrypt/decrypt DEBUG messages Laszlo Ersek
2017-08-30 15:53 ` [PATCH 02/11] OvmfPkg/BaseMemEncryptSevLib: break DEBUG calls to multiple lines Laszlo Ersek
2017-08-30 15:53 ` [PATCH 03/11] OvmfPkg/BaseMemEncryptSevLib: clean up DEBUG prefixes Laszlo Ersek
2017-08-30 15:53 ` [PATCH 04/11] OvmfPkg/BaseMemEncryptSevLib: clean up debug logging of PhysicalAddress Laszlo Ersek
2017-08-30 15:53 ` [PATCH 05/11] OvmfPkg/BaseMemEncryptSevLib: promote DEBUG_WARN levels to DEBUG_ERROR Laszlo Ersek
2017-08-30 15:53 ` [PATCH 06/11] OvmfPkg/BaseMemEncryptSevLib: clean up upper-case / lower-case in DEBUGs Laszlo Ersek
2017-08-30 15:53 ` [PATCH 07/11] OvmfPkg/BaseMemEncryptSevLib: fix typos in DEBUG messages Laszlo Ersek
2017-08-30 15:53 ` [PATCH 08/11] OvmfPkg/IoMmuDxe: IoMmuMap(): log nicer and more informative DEBUG msgs Laszlo Ersek
2017-08-30 15:53 ` [PATCH 09/11] OvmfPkg/IoMmuDxe: IoMmuUnmap(): clean up DEBUG message Laszlo Ersek
2017-08-30 15:53 ` [PATCH 10/11] OvmfPkg/IoMmuDxe: IoMmuAllocateBuffer(): nicer and more informative DEBUGs Laszlo Ersek
2017-08-30 15:53 ` [PATCH 11/11] OvmfPkg/IoMmuDxe: IoMmuFreeBuffer(): clean up DEBUG message Laszlo Ersek
2017-08-31 15:14 ` [PATCH 00/11] OvmfPkg: improve SEV-related DEBUG messages Brijesh Singh
2017-09-01 12:23   ` Laszlo Ersek

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170830155317.30917-1-lersek@redhat.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox