From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 66E1F21D2E630 for ; Wed, 30 Aug 2017 08:53:17 -0700 (PDT) Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id C3B8E5D5EA; Wed, 30 Aug 2017 15:53:20 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com C3B8E5D5EA Authentication-Results: ext-mx10.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx10.extmail.prod.ext.phx2.redhat.com; spf=fail smtp.mailfrom=lersek@redhat.com Received: from lacos-laptop-7.usersys.redhat.com (ovpn-120-136.rdu2.redhat.com [10.10.120.136]) by smtp.corp.redhat.com (Postfix) with ESMTP id D31018F364; Wed, 30 Aug 2017 15:53:19 +0000 (UTC) From: Laszlo Ersek To: edk2-devel-01 Cc: Brijesh Singh , Jordan Justen Date: Wed, 30 Aug 2017 17:53:06 +0200 Message-Id: <20170830155317.30917-1-lersek@redhat.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.39]); Wed, 30 Aug 2017 15:53:20 +0000 (UTC) Subject: [PATCH 00/11] OvmfPkg: improve SEV-related DEBUG messages X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 30 Aug 2017 15:53:17 -0000 Repo: https://github.com/lersek/edk2.git Branch: sev_debug_messages I've now looked at quite a bit of SEV-related DEBUG messages, and I find them really hard to read, and to process with command line utilities like grep, sort, uniq. For example, shell pipelines should be possible to construct with these utilities to collect decrypt/encrypt operations, in chronological order, grouped by address ever decrypted. The log should also be human-readable as much as possible -- it shouldn't be redundant, but all information for forward- and back-referencing should be available. I propose this series for the above improvements. Cc: Brijesh Singh Cc: Jordan Justen Thanks, Laszlo Laszlo Ersek (11): OvmfPkg/BaseMemEncryptSevLib: unify encrypt/decrypt DEBUG messages OvmfPkg/BaseMemEncryptSevLib: break DEBUG calls to multiple lines OvmfPkg/BaseMemEncryptSevLib: clean up DEBUG prefixes OvmfPkg/BaseMemEncryptSevLib: clean up debug logging of PhysicalAddress OvmfPkg/BaseMemEncryptSevLib: promote DEBUG_WARN levels to DEBUG_ERROR OvmfPkg/BaseMemEncryptSevLib: clean up upper-case / lower-case in DEBUGs OvmfPkg/BaseMemEncryptSevLib: fix typos in DEBUG messages OvmfPkg/IoMmuDxe: IoMmuMap(): log nicer and more informative DEBUG msgs OvmfPkg/IoMmuDxe: IoMmuUnmap(): clean up DEBUG message OvmfPkg/IoMmuDxe: IoMmuAllocateBuffer(): nicer and more informative DEBUGs OvmfPkg/IoMmuDxe: IoMmuFreeBuffer(): clean up DEBUG message OvmfPkg/IoMmuDxe/AmdSevIoMmu.c | 72 +++++++++++----- OvmfPkg/Library/BaseMemEncryptSevLib/X64/VirtualMemory.c | 89 ++++++++++++++------ 2 files changed, 110 insertions(+), 51 deletions(-) -- 2.14.1.3.gb7cf6e02401b