From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 5654C21E70D34 for ; Wed, 30 Aug 2017 08:53:25 -0700 (PDT) Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id BC3D35D687; Wed, 30 Aug 2017 15:53:28 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com BC3D35D687 Authentication-Results: ext-mx10.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx10.extmail.prod.ext.phx2.redhat.com; spf=fail smtp.mailfrom=lersek@redhat.com Received: from lacos-laptop-7.usersys.redhat.com (ovpn-120-136.rdu2.redhat.com [10.10.120.136]) by smtp.corp.redhat.com (Postfix) with ESMTP id C95718F356; Wed, 30 Aug 2017 15:53:27 +0000 (UTC) From: Laszlo Ersek To: edk2-devel-01 Cc: Brijesh Singh , Jordan Justen Date: Wed, 30 Aug 2017 17:53:11 +0200 Message-Id: <20170830155317.30917-6-lersek@redhat.com> In-Reply-To: <20170830155317.30917-1-lersek@redhat.com> References: <20170830155317.30917-1-lersek@redhat.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.39]); Wed, 30 Aug 2017 15:53:28 +0000 (UTC) Subject: [PATCH 05/11] OvmfPkg/BaseMemEncryptSevLib: promote DEBUG_WARN levels to DEBUG_ERROR X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 30 Aug 2017 15:53:25 -0000 In SetMemoryEncDec(), we have four locations where we (a) log a message on the DEBUG_WARN level that says "ERROR", (b) return the status code RETURN_NO_MAPPING right after. These messages clearly describe actual errors (bad PML4, PDPE, PDE, PTE). Promote their debug levels to DEBUG_ERROR, and remove the word "ERROR" from the messages. Cc: Brijesh Singh Cc: Jordan Justen Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Laszlo Ersek --- OvmfPkg/Library/BaseMemEncryptSevLib/X64/VirtualMemory.c | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/OvmfPkg/Library/BaseMemEncryptSevLib/X64/VirtualMemory.c b/OvmfPkg/Library/BaseMemEncryptSevLib/X64/VirtualMemory.c index 58c793dae6bf..c37d799bc1f4 100644 --- a/OvmfPkg/Library/BaseMemEncryptSevLib/X64/VirtualMemory.c +++ b/OvmfPkg/Library/BaseMemEncryptSevLib/X64/VirtualMemory.c @@ -287,8 +287,8 @@ SetMemoryEncDec ( PageMapLevel4Entry += PML4_OFFSET(PhysicalAddress); if (!PageMapLevel4Entry->Bits.Present) { DEBUG (( - DEBUG_WARN, - "%a:%a: ERROR bad PML4 for Physical=0x%Lx\n", + DEBUG_ERROR, + "%a:%a: bad PML4 for Physical=0x%Lx\n", gEfiCallerBaseName, __FUNCTION__, PhysicalAddress @@ -300,8 +300,8 @@ SetMemoryEncDec ( PageDirectory1GEntry += PDP_OFFSET(PhysicalAddress); if (!PageDirectory1GEntry->Bits.Present) { DEBUG (( - DEBUG_WARN, - "%a:%a: ERROR bad PDPE for Physical=0x%Lx\n", + DEBUG_ERROR, + "%a:%a: bad PDPE for Physical=0x%Lx\n", gEfiCallerBaseName, __FUNCTION__, PhysicalAddress @@ -351,8 +351,8 @@ SetMemoryEncDec ( PageDirectory2MEntry += PDE_OFFSET(PhysicalAddress); if (!PageDirectory2MEntry->Bits.Present) { DEBUG (( - DEBUG_WARN, - "%a:%a: ERROR bad PDE for Physical=0x%Lx\n", + DEBUG_ERROR, + "%a:%a: bad PDE for Physical=0x%Lx\n", gEfiCallerBaseName, __FUNCTION__, PhysicalAddress @@ -391,8 +391,8 @@ SetMemoryEncDec ( PageTableEntry += PTE_OFFSET(PhysicalAddress); if (!PageTableEntry->Bits.Present) { DEBUG (( - DEBUG_WARN, - "%a:%a: ERROR bad PTE for Physical=0x%Lx\n", + DEBUG_ERROR, + "%a:%a: bad PTE for Physical=0x%Lx\n", gEfiCallerBaseName, __FUNCTION__, PhysicalAddress -- 2.14.1.3.gb7cf6e02401b