From: Leif Lindholm <leif.lindholm@linaro.org>
To: Meenakshi Aggarwal <meenakshi.aggarwal@nxp.com>
Cc: edk2-devel@lists.01.org, Jun Nie <jun.nie@linaro.org>,
Haojian Zhuang <haojian.zhuang@linaro.org>
Subject: Re: [PATCH 1/2] MMC : Recieve response was missing after CMD12
Date: Thu, 31 Aug 2017 12:22:35 +0100 [thread overview]
Message-ID: <20170831112235.ps23hrth3kjx5aqi@bivouac.eciton.net> (raw)
In-Reply-To: <1504102859-13477-1-git-send-email-meenakshi.aggarwal@nxp.com>
On Wed, Aug 30, 2017 at 07:50:58PM +0530, Meenakshi Aggarwal wrote:
> We are not recieving the response from memory card after
> sending CMD 12. It was not resulting in any failure but
> we should recieve response after sending a command.
This looks sensible to me, but I'm not very familiar with MMC.
Jun, Haojian - could you comment on this?
/
Leif
> Signed-off-by: Meenakshi Aggarwal <meenakshi.aggarwal@nxp.com>
> ---
> EmbeddedPkg/Universal/MmcDxe/MmcBlockIo.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/EmbeddedPkg/Universal/MmcDxe/MmcBlockIo.c b/EmbeddedPkg/Universal/MmcDxe/MmcBlockIo.c
> index 403db96..a2b9232 100644
> --- a/EmbeddedPkg/Universal/MmcDxe/MmcBlockIo.c
> +++ b/EmbeddedPkg/Universal/MmcDxe/MmcBlockIo.c
> @@ -206,6 +206,7 @@ MmcTransferBlock (
> if (EFI_ERROR (Status)) {
> DEBUG ((EFI_D_BLKIO, "%a(): Error and Status:%r\n", __func__, Status));
> }
> + MmcHost->ReceiveResponse (MmcHost, MMC_RESPONSE_TYPE_R1b, Response);
> }
>
> Status = MmcNotifyState (MmcHostInstance, MmcTransferState);
> --
> 1.9.1
>
> _______________________________________________
> edk2-devel mailing list
> edk2-devel@lists.01.org
> https://lists.01.org/mailman/listinfo/edk2-devel
next prev parent reply other threads:[~2017-08-31 11:19 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-30 14:20 [PATCH 1/2] MMC : Recieve response was missing after CMD12 Meenakshi Aggarwal
2017-08-30 14:20 ` [PATCH 2/2] SD : Updated CMD 6 implememtation Meenakshi Aggarwal
2017-08-31 6:06 ` Meenakshi Aggarwal
2017-08-31 12:06 ` Leif Lindholm
2017-08-31 14:43 ` Jun Nie
2017-09-01 9:32 ` Meenakshi Aggarwal
2017-09-04 8:37 ` Meenakshi Aggarwal
2017-08-31 6:05 ` [PATCH 1/2] MMC : Recieve response was missing after CMD12 Meenakshi Aggarwal
2017-08-31 11:22 ` Leif Lindholm [this message]
2017-08-31 13:33 ` Jun Nie
2017-08-31 14:14 ` Meenakshi Aggarwal
2017-09-01 10:45 ` Leif Lindholm
2017-09-01 10:46 ` Meenakshi Aggarwal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170831112235.ps23hrth3kjx5aqi@bivouac.eciton.net \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox