* [PATCH edk2-platforms v2 0/4] Platform/OverdriveBoard: move device tree compilation into build
@ 2017-08-31 13:08 Ard Biesheuvel
2017-08-31 13:08 ` [PATCH edk2-platforms v2 1/4] " Ard Biesheuvel
` (3 more replies)
0 siblings, 4 replies; 11+ messages in thread
From: Ard Biesheuvel @ 2017-08-31 13:08 UTC (permalink / raw)
To: edk2-devel; +Cc: leif.lindholm, alan, liming.gao, yonghong.zhu, Ard Biesheuvel
OK, I was slightly naughty when I sent this the first time around, so here
are the same changes but broken up as I should have in the first place.
Ard Biesheuvel (4):
Platform/OverdriveBoard: move device tree compilation into build
Platform/OverdriveBoard: clean up device tree source file
Platform/OverdriveBoard: fix CPU affinity for vGIC maintenace
interrupt
Platform/OverdriveBoard: classify legacy INTx interrupts as level high
Platform/AMD/OverdriveBoard/FdtBlob/styx-overdrive.dtb | Bin 9357 -> 0 bytes
Platform/AMD/OverdriveBoard/FdtBlob/styx-overdrive.dts | 510 --------------------
Platform/AMD/OverdriveBoard/OverdriveBoard.dsc | 1 +
Platform/AMD/OverdriveBoard/OverdriveBoard.fdf | 9 +-
Platform/AMD/OverdriveBoard/OverdriveBoardDeviceTree/OverdriveBoardDeviceTree.dts | 487 +++++++++++++++++++
Platform/AMD/OverdriveBoard/OverdriveBoardDeviceTree/OverdriveBoardDeviceTree.inf | 28 ++
6 files changed, 521 insertions(+), 514 deletions(-)
delete mode 100644 Platform/AMD/OverdriveBoard/FdtBlob/styx-overdrive.dtb
delete mode 100644 Platform/AMD/OverdriveBoard/FdtBlob/styx-overdrive.dts
create mode 100644 Platform/AMD/OverdriveBoard/OverdriveBoardDeviceTree/OverdriveBoardDeviceTree.dts
create mode 100644 Platform/AMD/OverdriveBoard/OverdriveBoardDeviceTree/OverdriveBoardDeviceTree.inf
--
2.11.0
^ permalink raw reply [flat|nested] 11+ messages in thread
* [PATCH edk2-platforms v2 1/4] Platform/OverdriveBoard: move device tree compilation into build
2017-08-31 13:08 [PATCH edk2-platforms v2 0/4] Platform/OverdriveBoard: move device tree compilation into build Ard Biesheuvel
@ 2017-08-31 13:08 ` Ard Biesheuvel
2017-08-31 13:08 ` [PATCH edk2-platforms v2 2/4] Platform/OverdriveBoard: clean up device tree source file Ard Biesheuvel
` (2 subsequent siblings)
3 siblings, 0 replies; 11+ messages in thread
From: Ard Biesheuvel @ 2017-08-31 13:08 UTC (permalink / raw)
To: edk2-devel; +Cc: leif.lindholm, alan, liming.gao, yonghong.zhu, Ard Biesheuvel
Use the proposed BaseTools support for device tree compilation to
build the device tree binary from source at build time. Give it its
own .inf and a build rule so the tools take care of everything.
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
---
Platform/AMD/OverdriveBoard/FdtBlob/styx-overdrive.dtb | Bin 9357 -> 0 bytes
Platform/AMD/OverdriveBoard/OverdriveBoard.dsc | 1 +
Platform/AMD/OverdriveBoard/OverdriveBoard.fdf | 9 ++++---
Platform/AMD/OverdriveBoard/{FdtBlob/styx-overdrive.dts => OverdriveBoardDeviceTree/OverdriveBoardDeviceTree.dts} | 0
Platform/AMD/OverdriveBoard/OverdriveBoardDeviceTree/OverdriveBoardDeviceTree.inf | 28 ++++++++++++++++++++
5 files changed, 34 insertions(+), 4 deletions(-)
diff --git a/Platform/AMD/OverdriveBoard/FdtBlob/styx-overdrive.dtb b/Platform/AMD/OverdriveBoard/FdtBlob/styx-overdrive.dtb
deleted file mode 100644
index c8e5fd980bce305186214aab10a7d399faa22500..0000000000000000000000000000000000000000
GIT binary patch
literal 0
HcmV?d00001
literal 9357
zcmdT~O>7-k6`rw)A*6q4AOZx68>b<GO!{ocZID1RX%Q5t3gK4;<jk9Q{XFu_d()Zm
zPa-6;sk%a9RRJpsbO%TjSRhc;6%q@ib_pw6iVzz_yFfw}YWco%@0oW!c~0ykU2vrP
z=A3iSJ?FdU{>{vrSMPo6pFwcq`#}(#4}ym-;d%<?Fv<fcpvee&>e>`K#U!qC<Ujq?
z6VqQYab0I-`qV|Ue)huY=_ky($%aL42KDrXVO;j6Pd&YE%3hhSo72_-+aE`niu2x?
z%C?V&Y7}_dk^Q^C5+gCNJ!Sfs@Z?!1hv}d;Ww}<=Q8FCV<uJ=kxoBo*JF}fm2Sy<J
zIEFG6m-(4~nndSNLp~Xnwb_i~*@Xydnu;y2pK?57Uv&Jfu&{m+MLcb@2SPU0+Yi3(
z<Y~EXzt4$*laKC@>FXYpJ__@2FbM7^7V1BMQld1p?MBm$Ds5<c8O6`x_naKA&*h7z
z(>ad}xfF@t2T|YT2sY7j8RrH{5Pg!KM<LIM2}%&WM}F}mApF>hmsiH-m1D>f)@g2B
zC)A(B#<;AXkD6N65u@he-XM6Je%P=3JpPc!zt`~+r^>r970j>+rm8eAG81*zDyl_K
zf5%a1ulRL-Q6>>8dFK8Flok<=P?%(^n0fiil_g0n+i)DGmeWnsi;`@ZtkO{9yhs70
z@~;m3dt2rE!CZ@b**ttMS*NVB`Gao$u?55tm9*bioTJYidIe1x7kLb>B}u_BzE8;?
z<IK<Bew-tJjTT)T=}#5cu>=}9)xLAS`eVR3Ls@Yw+(}+P@)w!Oj3qdVBsIigokDv<
z98Q7#=hcfNdF|!WT`x@2pScB@C+BV}&V7G>`KrSw{mIiRVSlVsx@_hY^NMxT$jmEc
z&8wTQx7S~9zH<M#wicIlRiuRCP1z<kv2YA@%!!4(V5#za4I9%O_a#|9woc|X_iI#R
z?{08%!%0wrt!e&(>@rl}uQ?56u3PRQpzw?M;hG0EytcUxC9zN@y@8^2#Lh8Qnb;}&
z*pq!@e+3>$d&B+(SSohq70<1(bDpRzu~W9#u_lrC`4)EeZK@g+)tTN#62&V?3I&Kh
zM!9zbCEjcu$4hgafG1v!`xf|d`9+)X0O}Z%bPUDE)@xzIc^KZ)ORKn>nVz(;G4_V}
zRo8+UxDj&~y8U3bUOdd{T!LE=L9E$f|9RrOe3~ll4>sb`M6iW=XHMk=pmubo`Z?uB
z*2dSYXNleEV878NB)<0?dyAtW#37cpe(bM8w`=Umlxdu?>(Y5`&$TCKdy#c!XXVbT
zC~^EJCd<@@!6Xseb{#+*8~<~t(D=Ob;Cy0kwH(I0IKn*$8&D7z-6fuCs3+O^R22j$
zdyG{}TOZ@x+^sOulTd>ZQph<=9Dcq&4_Wc@>f_}cK5`R`vL4ZfM8EsP$QDAk#P}r4
z_Jfh0VIQ8wm80ckxrg#)*{Eq#^%6WBEOx+?XwUgNmFG!>vm&apVa*DV`bw;*a<~xA
zMp}<?4?l}EUxgda2iGS2daKQHOI~lu&$Z+qIhms?bERLTLrxZNF)@}u4v+3KpP8Ru
zIzMc~L6AOe-?+X|75*MSv?H~jJ&1*M{=8z}_A_Q)e>(o;r{CT7(mU$s79$Gnn1B22
z=KwBlyPw_ydguD7qc+;F0D0fzncqo2y$3m>xwCQOt}1j#<Cen3zQ-*|us7SY!{009
z?BbgO)JOUbVSP3xO7^!|TU!Dd8heJY&Ra9OPc-YyySEGf>{`h>;j_WwvOT{Y5c)cb
zGKIQmWmwgbN#Z=}n*q+e1Qj6Ku+PUGuQK;R`c?TNc-<#~IQ$!Al0`ql4qxGQ#A6-X
za^HKM0*Lo-&R_T@c+E9^Bq)IzTBl+Qb^^Q4+pJc4HyHQ{w@`<9gX42VL}Jl2x^UX+
zcGyYI8WUl{hsM|uZ`&Vp1>FvR>`U8j#_ITp(GYFgb|<WEhut`Q509}MhwtPVyK(qF
zYVD5T($F}3r%((14!d#qPLHu0hwo!!?8f2yxV4jc0JeFq`7rnw9;fC8YEsL%yzeU;
zjkEoiP9;>Z6Qo7?9bK<NrUQ^R*DL2RN&4@e{bE^lR?lW!zjE)m>$Bfatg-XXHthdv
zD2zjy`=LIMJO!Thpip^jbDc^Q%A_|?w2seyTuLevJ7vM1B!k7yrjc#f-F4Hh!H)W9
zp>qx@Y0q{Eg@5n|<PxH76zg|UMXVB|ztO9)Id;3F8++OxMC)CjgZRu`b*ngHV;F<j
zW*SA}Z~Xxr$pP5<qZOS@TkaVrOS4>>Y9(-QSZTyMZ*L9144GJ|$91B!QFXvt?5jxy
z=%a@MXSW-6=!2=W$kPZ7=>$Z-*t^2()QiUInp|$VKA?^#SR3DS&?!FnpXkuf(oX-x
zy$Cyc(tbP%p6%>7XRGd=jr2`p?D^fE_s-`1@Of>skC#JuKItssEs_7`rim}_aM5qY
zBl|w(7M@wCnm*qJJVjmXj%TWchjI(g++D>pd-MFbGfc*b>ymN{&-`7+bJP6j{NubK
z9?F8JSh<YHiMexp^G-k@&LPalv1|B)sFVLqHv3%@p>g}>$F--g1SQx$!B8ZIhWxNx
z_;ZOrkpIIghz2@;b-#Js)1!XkYcvEoyNLum*M_b%)pL!qe=Ir{*c&FEhm3deQg|S%
z{g1)(oe2x;RsRdeQ`R*|KYxO(#C)=z__-$|ca6+C$~$w7H*(OC*zPXon%f_#$@Ntc
zgWwXc$n}4nJTBK4P^Wra|1WZ_V@2G|HD$@QJG&p<_t||39!PdZ>A3E8c7F+$j13Bv
z*EZLoBo@k~_St<HI<+Ns%06~`c0&oG9S8U3_Z?SZLE0Pkr(vnsl~+8s!mewF?TMYT
zV3+d)C+lOQ#M9?)bDU?+Xg_H^NTH5xr%@7=V5{IS$ZaWGn^tr(Z9j>kd&g(MYyX}B
zZ?h7F-}3lxd;E7CPd}iEE&PzjSu*kF#EU=u+0S2sWOYQq_htuB^z3;6A&&6W<m)}|
z#_lyAeE`QK?R0MdKY19rN>eC7E@m@FFxK+!nR9}448{48J?4-nGyjx#<o^@zME-w(
zC?w7Q53RUM{+~dt=AZkv=AZAxl>dguf79_U7p?sN`sLsJ_II$bdC>fGZzs<-d&$4<
z7kkY==QXLFf38Ix59XgT^DkqN;9=bGEs?ds9H0EqBly$zkufi$wM|haZYqdhd9LTZ
zGWAjCtb6_27`fP!C#yVR9F2W2ANEX!yW+fv>lA-P1f!1;3cTAN)WJ;L>*3b9iukU(
z3TCSGigEnNcJ$#wFym>ZMQQpYuT@aSgTASPEFG+Eo+(!1K@U;$D)l~o2(T(5XE!7N
zH@kqA$DRDMYi5vK4y-&}tBbWd8sMLP;Ol3@Zk$C83aHW{AH6Jox=w~GM*1f0t3c|j
zpsM2<|EXK2)*D~#dVL$L<q_`Zsm<d}d|aSF)`wXg_l<(azXWr0XI4^E#$~c{Ik2)o
zT8<OrWMn;J{+(EEMj5|GiRv=#J6*j)H^aBNt{;|dz88_tP_ATYH>%c(0w0CgP61{S
z^vrsin5Fu1VFG+KU_naC-4HjqqB%;nIvOzXfFX409huq$v4%4u5T=NebkMh-#1sY}
z3sk0dAIOwFQ$^iuBk|>=R{~9Kd|mNuRIQo~Uxh5hdEsk%%O<LU6=SoEWZ7?UB!t$O
x0smK%n!=P(f{8XjZX5goo?9X}wFBOmx|v8;2BoTdm{<|k#Y&KydS%!P{s-HVZ2|xQ
diff --git a/Platform/AMD/OverdriveBoard/OverdriveBoard.dsc b/Platform/AMD/OverdriveBoard/OverdriveBoard.dsc
index bc69c586e929..081a4f3cd002 100644
--- a/Platform/AMD/OverdriveBoard/OverdriveBoard.dsc
+++ b/Platform/AMD/OverdriveBoard/OverdriveBoard.dsc
@@ -600,6 +600,7 @@ DEFINE DO_FLASHER = FALSE
#
# FDT support
#
+ Platform/AMD/OverdriveBoard/OverdriveBoardDeviceTree/OverdriveBoardDeviceTree.inf
EmbeddedPkg/Drivers/DtPlatformDxe/DtPlatformDxe.inf {
<LibraryClasses>
FdtLib|EmbeddedPkg/Library/FdtLib/FdtLib.inf
diff --git a/Platform/AMD/OverdriveBoard/OverdriveBoard.fdf b/Platform/AMD/OverdriveBoard/OverdriveBoard.fdf
index 23e57befcdd9..aa2a1a6fa053 100644
--- a/Platform/AMD/OverdriveBoard/OverdriveBoard.fdf
+++ b/Platform/AMD/OverdriveBoard/OverdriveBoard.fdf
@@ -145,10 +145,7 @@ READ_LOCK_STATUS = TRUE
# FDT support
#
INF EmbeddedPkg/Drivers/DtPlatformDxe/DtPlatformDxe.inf
-
- FILE FREEFORM = 25462CDA-221F-47DF-AC1D-259CFAA4E326 {
- SECTION RAW = Platform/AMD/OverdriveBoard/FdtBlob/styx-overdrive.dtb
- }
+ INF RuleOverride = DTB Platform/AMD/OverdriveBoard/OverdriveBoardDeviceTree/OverdriveBoardDeviceTree.inf
#
# PCI support
@@ -413,3 +410,7 @@ READ_LOCK_STATUS = TRUE
RAW ASL |.aml
}
+[Rule.Common.USER_DEFINED.DTB]
+ FILE FREEFORM = $(NAMED_GUID) {
+ RAW BIN |.dtb
+ }
diff --git a/Platform/AMD/OverdriveBoard/FdtBlob/styx-overdrive.dts b/Platform/AMD/OverdriveBoard/OverdriveBoardDeviceTree/OverdriveBoardDeviceTree.dts
similarity index 100%
rename from Platform/AMD/OverdriveBoard/FdtBlob/styx-overdrive.dts
rename to Platform/AMD/OverdriveBoard/OverdriveBoardDeviceTree/OverdriveBoardDeviceTree.dts
diff --git a/Platform/AMD/OverdriveBoard/OverdriveBoardDeviceTree/OverdriveBoardDeviceTree.inf b/Platform/AMD/OverdriveBoard/OverdriveBoardDeviceTree/OverdriveBoardDeviceTree.inf
new file mode 100644
index 000000000000..9ecf993cafac
--- /dev/null
+++ b/Platform/AMD/OverdriveBoard/OverdriveBoardDeviceTree/OverdriveBoardDeviceTree.inf
@@ -0,0 +1,28 @@
+## @file
+#
+# Device tree description of the AMD Seattle Overdrive platform
+#
+# Copyright (c) 2017, Linaro Ltd. All rights reserved.
+#
+# This program and the accompanying materials
+# are licensed and made available under the terms and conditions of the BSD License
+# which accompanies this distribution. The full text of the license may be found at
+# http://opensource.org/licenses/bsd-license.php
+#
+# THE PROGRAM IS DISTRIBUTED UNDER THE BSD LICENSE ON AN "AS IS" BASIS,
+# WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER EXPRESS OR IMPLIED.
+#
+##
+
+[Defines]
+ INF_VERSION = 0x00010019
+ BASE_NAME = OverdriveBoardDeviceTree
+ FILE_GUID = 25462CDA-221F-47DF-AC1D-259CFAA4E326 # gDtPlatformDefaultDtbFileGuid
+ MODULE_TYPE = USER_DEFINED
+ VERSION_STRING = 1.0
+
+[Sources]
+ OverdriveBoardDeviceTree.dts
+
+[Packages]
+ MdePkg/MdePkg.dec
--
2.11.0
^ permalink raw reply related [flat|nested] 11+ messages in thread
* [PATCH edk2-platforms v2 2/4] Platform/OverdriveBoard: clean up device tree source file
2017-08-31 13:08 [PATCH edk2-platforms v2 0/4] Platform/OverdriveBoard: move device tree compilation into build Ard Biesheuvel
2017-08-31 13:08 ` [PATCH edk2-platforms v2 1/4] " Ard Biesheuvel
@ 2017-08-31 13:08 ` Ard Biesheuvel
2017-09-01 11:12 ` Leif Lindholm
2017-08-31 13:08 ` [PATCH edk2-platforms v2 3/4] Platform/OverdriveBoard: fix CPU affinity for vGIC maintenace interrupt Ard Biesheuvel
2017-08-31 13:08 ` [PATCH edk2-platforms v2 4/4] Platform/OverdriveBoard: classify legacy INTx interrupts as level high Ard Biesheuvel
3 siblings, 1 reply; 11+ messages in thread
From: Ard Biesheuvel @ 2017-08-31 13:08 UTC (permalink / raw)
To: edk2-devel; +Cc: leif.lindholm, alan, liming.gao, yonghong.zhu, Ard Biesheuvel
Clean up the device tree source file, by switching to Tianocore
conventions for line endings and whitespace etc, and by replacing
open coded values with symbol constants and/or phandle references.
The resulting .dtb will likely not be identical at the bit level, but
the modifications are cosmetic only.
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
---
Platform/AMD/OverdriveBoard/OverdriveBoardDeviceTree/OverdriveBoardDeviceTree.dts | 957 ++++++++++----------
1 file changed, 467 insertions(+), 490 deletions(-)
diff --git a/Platform/AMD/OverdriveBoard/OverdriveBoardDeviceTree/OverdriveBoardDeviceTree.dts b/Platform/AMD/OverdriveBoard/OverdriveBoardDeviceTree/OverdriveBoardDeviceTree.dts
index 4039f666004a..81477fe43cdd 100644
--- a/Platform/AMD/OverdriveBoard/OverdriveBoardDeviceTree/OverdriveBoardDeviceTree.dts
+++ b/Platform/AMD/OverdriveBoard/OverdriveBoardDeviceTree/OverdriveBoardDeviceTree.dts
@@ -2,6 +2,7 @@
* DTS file for AMD Seattle (Rev.B) Overdrive Development Board
*
* Copyright 2015 - 2016 ADVANCED MICRO DEVICES, INC. All Rights Reserved.
+ * Copyright 2015 - 2017 Linaro, Ltd. All Rights Reserved.
*
* This program and the accompanying materials are licensed and made available
* under the terms and conditions of the BSD License which accompanies this
@@ -14,497 +15,473 @@
*
*/
+#define GIC_SPI 0
+#define GIC_PPI 1
+
+#define IRQ_TYPE_NONE 0
+#define IRQ_TYPE_EDGE_RISING 1
+#define IRQ_TYPE_EDGE_FALLING 2
+#define IRQ_TYPE_LEVEL_HIGH 4
+#define IRQ_TYPE_LEVEL_LOW 8
+
+#define GIC_CPU_MASK(num) (((1 << (num)) - 1) << 8)
+
/dts-v1/;
/ {
- model = "AMD Seattle (Rev.B) Development Board (Overdrive)";
- compatible = "amd,seattle-overdrive", "amd,seattle";
- interrupt-parent = <0x1>;
- #address-cells = <0x2>;
- #size-cells = <0x2>;
-
- interrupt-controller@e1101000 {
- compatible = "arm,gic-400", "arm,cortex-a15-gic";
- interrupt-controller;
- #interrupt-cells = <0x3>;
- #address-cells = <0x2>;
- #size-cells = <0x2>;
- reg = <0x0 0xe1110000 0x0 0x1000>,
- <0x0 0xe112f000 0x0 0x2000>,
- <0x0 0xe1140000 0x0 0x2000>,
- <0x0 0xe1160000 0x0 0x2000>;
- interrupts = <0x1 0x9 0xf04>;
- ranges = <0x0 0x0 0x0 0xe1100000 0x0 0x100000>;
- linux,phandle = <0x1>;
- phandle = <0x1>;
-
- v2m@e0080000 {
- compatible = "arm,gic-v2m-frame";
- msi-controller;
- reg = <0x0 0x80000 0x0 0x1000>;
- linux,phandle = <0x4>;
- phandle = <0x4>;
- };
- };
-
- timer {
- compatible = "arm,armv8-timer";
- interrupts = <0x1 0xd 0xff04>,
- <0x1 0xe 0xff04>,
- <0x1 0xb 0xff04>,
- <0x1 0xa 0xff04>;
- };
-
- smb {
- compatible = "simple-bus";
- #address-cells = <0x2>;
- #size-cells = <0x2>;
- ranges;
- /*
- * dma-ranges is 40-bit address space containing:
- * - GICv2m MSI register is at 0xe0080000
- * - DRAM range [0x8000000000 to 0xffffffffff]
- */
- dma-ranges = <0x0 0x0 0x0 0x0 0x100 0x0>;
-
- clk100mhz_0 {
- compatible = "fixed-clock";
- #clock-cells = <0x0>;
- clock-frequency = <100000000>;
- clock-output-names = "adl3clk_100mhz";
- };
-
- clk375mhz {
- compatible = "fixed-clock";
- #clock-cells = <0x0>;
- clock-frequency = <375000000>;
- clock-output-names = "ccpclk_375mhz";
- };
-
- clk333mhz {
- compatible = "fixed-clock";
- #clock-cells = <0x0>;
- clock-frequency = <333000000>;
- clock-output-names = "sataclk_333mhz";
- linux,phandle = <0x2>;
- phandle = <0x2>;
- };
-
- clk500mhz_0 {
- compatible = "fixed-clock";
- #clock-cells = <0x0>;
- clock-frequency = <500000000>;
- clock-output-names = "pcieclk_500mhz";
- };
-
- clk500mhz_1 {
- compatible = "fixed-clock";
- #clock-cells = <0x0>;
- clock-frequency = <500000000>;
- clock-output-names = "dmaclk_500mhz";
- };
-
- clk250mhz_4 {
- compatible = "fixed-clock";
- #clock-cells = <0x0>;
- clock-frequency = <250000000>;
- clock-output-names = "miscclk_250mhz";
- linux,phandle = <0xd>;
- phandle = <0xd>;
- };
-
- clk100mhz_1 {
- compatible = "fixed-clock";
- #clock-cells = <0x0>;
- clock-frequency = <100000000>;
- clock-output-names = "uartspiclk_100mhz";
- linux,phandle = <0x3>;
- phandle = <0x3>;
- };
-
- sata0_smmu: smmu@e0200000 {
- compatible = "arm,mmu-401";
- reg = <0 0xe0200000 0 0x10000>;
- #global-interrupts = <1>;
- interrupts = /* Uses combined intr for both
- * global and context
- */
- <0 332 4>,
- <0 332 4>;
- #iommu-cells = <2>;
- dma-coherent;
- };
-
- sata1_smmu: smmu@e0c00000 {
- compatible = "arm,mmu-401";
- reg = <0 0xe0c00000 0 0x10000>;
- #global-interrupts = <1>;
- interrupts = /* Uses combined intr for both
- * global and context
- */
- <0 331 4>,
- <0 331 4>;
- #iommu-cells = <2>;
- dma-coherent;
- };
-
- sata@e0300000 {
- compatible = "snps,dwc-ahci";
- reg = <0x0 0xe0300000 0x0 0xf0000>;
- interrupts = <0x0 0x163 0x4>;
- clocks = <0x2>;
- dma-coherent;
- iommus = <&sata0_smmu 0x00 0x1f>; /* 0-31 */
- };
-
- sata@e0d00000 {
- status = "disabled";
- compatible = "snps,dwc-ahci";
- reg = <0x0 0xe0d00000 0x0 0xf0000>;
- interrupts = <0x0 0x162 0x4>;
- clocks = <0x2>;
- dma-coherent;
- iommus = <&sata1_smmu 0x00 0x1f>; /* 0-31 */
- };
-
- i2c@e1000000 {
- compatible = "snps,designware-i2c";
- reg = <0x0 0xe1000000 0x0 0x1000>;
- interrupts = <0x0 0x165 0x4>;
- clocks = <0xd>;
- };
-
- i2c@e0050000 {
- compatible = "snps,designware-i2c";
- reg = <0x0 0xe0050000 0x0 0x1000>;
- interrupts = <0x0 0x154 0x4>;
- clocks = <0xd>;
- };
-
- serial@e1010000 {
- compatible = "arm,pl011", "arm,primecell";
- reg = <0x0 0xe1010000 0x0 0x1000>;
- interrupts = <0x0 0x148 0x4>;
- clocks = <0x3 0x3>;
- clock-names = "uartclk", "apb_pclk";
- };
-
- ssp@e1020000 {
- compatible = "arm,pl022", "arm,primecell";
- reg = <0x0 0xe1020000 0x0 0x1000>;
- spi-controller;
- interrupts = <0x0 0x14a 0x4>;
- clocks = <0x3>;
- clock-names = "apb_pclk";
- };
-
- ssp@e1030000 {
- compatible = "arm,pl022", "arm,primecell";
- reg = <0x0 0xe1030000 0x0 0x1000>;
- spi-controller;
- interrupts = <0x0 0x149 0x4>;
- clocks = <0x3>;
- clock-names = "apb_pclk";
- num-cs = <0x1>;
- #address-cells = <0x1>;
- #size-cells = <0x0>;
-
- sdcard@0 {
- compatible = "mmc-spi-slot";
- reg = <0x0>;
- spi-max-frequency = <20000000>;
- voltage-ranges = <3200 3400>;
- pl022,hierarchy = <0x0>;
- pl022,interface = <0x0>;
- pl022,com-mode = <0x0>;
- pl022,rx-level-trig = <0x0>;
- pl022,tx-level-trig = <0x0>;
- };
- };
-
- gpio@e1050000 { /* [0 : 7] */
- compatible = "arm,pl061", "arm,primecell";
- #gpio-cells = <0x2>;
- reg = <0x0 0xe1050000 0x0 0x1000>;
- gpio-controller;
- interrupt-controller;
- #interrupt-cells = <0x2>;
- interrupts = <0x0 0x166 0x4>;
- clocks = <0x3>;
- clock-names = "apb_pclk";
- };
-
- gpio@e0020000 { /* [8 : 15] */
- status = "disabled";
- compatible = "arm,pl061", "arm,primecell";
- #gpio-cells = <0x2>;
- reg = <0x0 0xe0020000 0x0 0x1000>;
- gpio-controller;
- interrupt-controller;
- #interrupt-cells = <0x2>;
- interrupts = <0x0 0x16e 0x4>;
- clocks = <0x3>;
- clock-names = "apb_pclk";
- };
-
- gpio@e0030000 { /* [16 : 23] */
- status = "disabled";
- compatible = "arm,pl061", "arm,primecell";
- #gpio-cells = <0x2>;
- reg = <0x0 0xe0030000 0x0 0x1000>;
- gpio-controller;
- interrupt-controller;
- #interrupt-cells = <0x2>;
- interrupts = <0x0 0x16d 0x4>;
- clocks = <0x3>;
- clock-names = "apb_pclk";
- };
-
- gpio@e0080000 { /* [24] */
- compatible = "arm,pl061", "arm,primecell";
- #gpio-cells = <0x2>;
- reg = <0x0 0xe0080000 0x0 0x1000>;
- gpio-controller;
- interrupt-controller;
- #interrupt-cells = <0x2>;
- interrupts = <0x0 0x169 0x4>;
- clocks = <0x3>;
- clock-names = "apb_pclk";
- };
-
- ccp: ccp@e0100000 {
- compatible = "amd,ccp-seattle-v1a";
- reg = <0x0 0xe0100000 0x0 0x10000>;
- interrupts = <0x0 0x3 0x4>;
- dma-coherent;
- amd,zlib-support = <0x1>;
- };
-
- pcie: pcie@f0000000 {
- compatible = "pci-host-ecam-generic";
- #address-cells = <0x3>;
- #size-cells = <0x2>;
- #interrupt-cells = <0x1>;
- iommu-map = <0x0 &pcie_smmu 0x0 0x10000>;
- device_type = "pci";
- bus-range = <0x0 0x7f>;
- msi-parent = <0x4>;
- reg = <0x0 0xf0000000 0x0 0x10000000>;
- interrupt-map-mask = <0xff00 0x0 0x0 0x7>;
- interrupt-map = <0x1100 0x0 0x0 0x1 0x1 0x0 0x0 0x0 0x120 0x1>,
- <0x1100 0x0 0x0 0x2 0x1 0x0 0x0 0x0 0x121 0x1>,
- <0x1100 0x0 0x0 0x3 0x1 0x0 0x0 0x0 0x122 0x1>,
- <0x1100 0x0 0x0 0x4 0x1 0x0 0x0 0x0 0x123 0x1>,
-
- <0x1200 0x0 0x0 0x1 0x1 0x0 0x0 0x0 0x124 0x1>,
- <0x1200 0x0 0x0 0x2 0x1 0x0 0x0 0x0 0x125 0x1>,
- <0x1200 0x0 0x0 0x3 0x1 0x0 0x0 0x0 0x126 0x1>,
- <0x1200 0x0 0x0 0x4 0x1 0x0 0x0 0x0 0x127 0x1>,
-
- <0x1300 0x0 0x0 0x1 0x1 0x0 0x0 0x0 0x128 0x1>,
- <0x1300 0x0 0x0 0x2 0x1 0x0 0x0 0x0 0x129 0x1>,
- <0x1300 0x0 0x0 0x3 0x1 0x0 0x0 0x0 0x12a 0x1>,
- <0x1300 0x0 0x0 0x4 0x1 0x0 0x0 0x0 0x12b 0x1>;
- dma-coherent;
- dma-ranges = <0x43000000 0x0 0x0 0x0 0x0 0x100 0x0>;
- ranges = <0x1000000 0x0 0x00000000 0x0 0xefff0000 0x00 0x00010000>, /* I/O Memory (size=64K) */
- <0x2000000 0x0 0x40000000 0x0 0x40000000 0x00 0x80000000>, /* 32-bit MMIO (size=2G) */
- <0x3000000 0x1 0x00000000 0x1 0x00000000 0x7f 0x00000000>; /* 64-bit MMIO (size= 124G) */
- };
-
- pcie_smmu: smmu@e0a00000 {
- compatible = "arm,mmu-401";
- reg = <0 0xe0a00000 0 0x10000>;
- #global-interrupts = <1>;
- interrupts = /* Uses combined intr for both
- * global and context
- */
- <0 333 4>,
- <0 333 4>;
- #iommu-cells = <1>;
- dma-coherent;
- };
-
- ccn@0xe8000000 {
- compatible = "arm,ccn-504";
- reg = <0x0 0xe8000000 0x0 0x1000000>;
- interrupts = <0x0 0x17c 0x4>;
- };
-
- gwdt@e0bb0000 {
- status = "disabled";
- compatible = "arm,sbsa-gwdt";
- reg = <0x0 0xe0bb0000 0x0 0x10000
- 0x0 0xe0bc0000 0x0 0x10000>;
- reg-names = "refresh", "control";
- interrupts = <0x0 0x151 0x4>;
- interrupt-names = "ws0";
- };
-
- kcs@e0010000 {
- status = "disabled";
- compatible = "ipmi-kcs";
- device_type = "ipmi";
- reg = <0x0 0xe0010000 0 0x8>;
- interrupts = <0 389 4>;
- interrupt-names = "ipmi_kcs";
- reg-size = <1>;
- reg-spacing = <4>;
- };
-
- clk250mhz_0 {
- compatible = "fixed-clock";
- #clock-cells = <0x0>;
- clock-frequency = <250000000>;
- clock-output-names = "xgmacclk0_dma_250mhz";
- linux,phandle = <0x5>;
- phandle = <0x5>;
- };
-
- clk250mhz_1 {
- compatible = "fixed-clock";
- #clock-cells = <0x0>;
- clock-frequency = <250000000>;
- clock-output-names = "xgmacclk0_ptp_250mhz";
- linux,phandle = <0x6>;
- phandle = <0x6>;
- };
-
- clk250mhz_2 {
- compatible = "fixed-clock";
- #clock-cells = <0x0>;
- clock-frequency = <250000000>;
- clock-output-names = "xgmacclk1_dma_250mhz";
- linux,phandle = <0x7>;
- phandle = <0x7>;
- };
-
- clk250mhz_3 {
- compatible = "fixed-clock";
- #clock-cells = <0x0>;
- clock-frequency = <250000000>;
- clock-output-names = "xgmacclk1_ptp_250mhz";
- linux,phandle = <0x8>;
- phandle = <0x8>;
- };
-
- phy@e1240800 {
- status = "disabled";
- compatible = "amd,xgbe-phy-seattle-v1a";
- reg = <0x0 0xe1240800 0x0 0x0400>, /* SERDES RX/TX0 */
- <0x0 0xe1250000 0x0 0x0060>, /* SERDES IR 1/2 */
- <0x0 0xe12500f8 0x0 0x0004>; /* SERDES IR 2/2 */
- interrupts = <0x0 0x143 0x4>;
- amd,speed-set = <0x0>;
- amd,serdes-blwc = <0x1 0x1 0x0>;
- amd,serdes-cdr-rate = <0x2 0x2 0x7>;
- amd,serdes-pq-skew = <0xa 0xa 0x12>;
- amd,serdes-tx-amp = <0xf 0xf 0xa>;
- amd,serdes-dfe-tap-config = <0x3 0x3 0x1>;
- amd,serdes-dfe-tap-enable = <0x0 0x0 0x7f>;
- linux,phandle = <0x9>;
- phandle = <0x9>;
- };
-
- phy@e1240c00 {
- status = "disabled";
- compatible = "amd,xgbe-phy-seattle-v1a";
- reg = <0x0 0xe1240c00 0x0 0x0400>, /* SERDES RX/TX0 */
- <0x0 0xe1250080 0x0 0x0060>, /* SERDES IR 1/2 */
- <0x0 0xe12500fc 0x0 0x0004>; /* SERDES IR 2/2 */
- interrupts = <0x0 0x142 0x4>;
- amd,speed-set = <0x0>;
- amd,serdes-blwc = <0x1 0x1 0x0>;
- amd,serdes-cdr-rate = <0x2 0x2 0x7>;
- amd,serdes-pq-skew = <0xa 0xa 0x12>;
- amd,serdes-tx-amp = <0xf 0xf 0xa>;
- amd,serdes-dfe-tap-config = <0x3 0x3 0x1>;
- amd,serdes-dfe-tap-enable = <0x0 0x0 0x7f>;
- linux,phandle = <0xa>;
- phandle = <0xa>;
- };
-
- xgmac0_smmu: smmu@e0600000 {
- compatible = "arm,mmu-401";
- reg = <0 0xe0600000 0 0x10000>;
- #global-interrupts = <1>;
- interrupts = /* Uses combined intr for both
- * global and context
- */
- <0 336 4>,
- <0 336 4>;
- #iommu-cells = <2>;
- dma-coherent;
- };
-
- xgmac1_smmu: smmu@e0800000 {
- compatible = "arm,mmu-401";
- reg = <0 0xe0800000 0 0x10000>;
- #global-interrupts = <1>;
- interrupts = /* Uses combined intr for both
- * global and context
- */
- <0 335 4>,
- <0 335 4>;
- #iommu-cells = <2>;
- dma-coherent;
- };
-
- xgmac@e0700000 {
- status = "disabled";
- compatible = "amd,xgbe-seattle-v1a";
- reg = <0x0 0xe0700000 0x0 0x80000 0x0 0xe0780000 0x0 0x80000>;
- interrupts = <0x0 0x145 0x4>,
- <0x0 0x15a 0x1>,
- <0x0 0x15b 0x1>,
- <0x0 0x15c 0x1>,
- <0x0 0x15d 0x1>;
- amd,per-channel-interrupt;
- mac-address = [02 a1 a2 a3 a4 a5];
- clocks = <0x5 0x6>;
- clock-names = "dma_clk", "ptp_clk";
- phy-handle = <0x9>;
- phy-mode = "xgmii";
- dma-coherent;
- iommus = <&xgmac0_smmu 0x00 0x1f>; /* 0-31 */
- linux,phandle = <0xb>;
- phandle = <0xb>;
- };
-
- xgmac@e0900000 {
- status = "disabled";
- compatible = "amd,xgbe-seattle-v1a";
- reg = <0x0 0xe0900000 0x0 0x80000 0x0 0xe0980000 0x0 0x80000>;
- interrupts = <0x0 0x144 0x4>,
- <0x0 0x155 0x1>,
- <0x0 0x156 0x1>,
- <0x0 0x157 0x1>,
- <0x0 0x158 0x1>;
- amd,per-channel-interrupt;
- mac-address = [02 b1 b2 b3 b4 b5];
- clocks = <0x7 0x8>;
- clock-names = "dma_clk", "ptp_clk";
- phy-handle = <0xa>;
- phy-mode = "xgmii";
- dma-coherent;
- iommus = <&xgmac1_smmu 0x00 0x1f>; /* 0-31 */
- linux,phandle = <0xc>;
- phandle = <0xc>;
- };
- };
-
- chosen {
- stdout-path = "/smb/serial@e1010000";
- /* Note:
- * Linux support for pci-probe-only DT is not
- * stable. Disable this for now and let Linux
- * take care of the resource assignment.
- */
- // linux,pci-probe-only;
- };
-
- psci {
- compatible = "arm,psci-0.2", "arm,psci";
- method = "smc";
- };
+ model = "AMD Seattle (Rev.B) Development Board (Overdrive)";
+ compatible = "amd,seattle-overdrive", "amd,seattle";
+ interrupt-parent = <&gic>;
+ #address-cells = <0x2>;
+ #size-cells = <0x2>;
+
+ gic: interrupt-controller@e1101000 {
+ compatible = "arm,gic-400", "arm,cortex-a15-gic";
+ interrupt-controller;
+ #interrupt-cells = <0x3>;
+ #address-cells = <0x2>;
+ #size-cells = <0x2>;
+ reg = <0x0 0xe1110000 0x0 0x1000>,
+ <0x0 0xe112f000 0x0 0x2000>,
+ <0x0 0xe1140000 0x0 0x2000>,
+ <0x0 0xe1160000 0x0 0x2000>;
+ interrupts = <GIC_PPI 0x9 (IRQ_TYPE_LEVEL_HIGH | GIC_CPU_MASK(4))>;
+ ranges = <0x0 0x0 0x0 0xe1100000 0x0 0x100000>;
+
+ msi: v2m@e0080000 {
+ compatible = "arm,gic-v2m-frame";
+ reg = <0x0 0x80000 0x0 0x1000>;
+ msi-controller;
+ };
+ };
+
+ timer {
+ compatible = "arm,armv8-timer";
+ interrupts = <GIC_PPI 0xd (IRQ_TYPE_LEVEL_HIGH | GIC_CPU_MASK(8))>,
+ <GIC_PPI 0xe (IRQ_TYPE_LEVEL_HIGH | GIC_CPU_MASK(8))>,
+ <GIC_PPI 0xb (IRQ_TYPE_LEVEL_HIGH | GIC_CPU_MASK(8))>,
+ <GIC_PPI 0xa (IRQ_TYPE_LEVEL_HIGH | GIC_CPU_MASK(8))>;
+ };
+
+ smb {
+ compatible = "simple-bus";
+ #address-cells = <0x2>;
+ #size-cells = <0x2>;
+ ranges;
+ /*
+ * dma-ranges is 40-bit address space containing:
+ * - GICv2m MSI register is at 0xe0080000
+ * - DRAM range [0x8000000000 to 0xffffffffff]
+ */
+ dma-ranges = <0x0 0x0 0x0 0x0 0x100 0x0>;
+
+ adl3clk: clk100mhz_0 {
+ compatible = "fixed-clock";
+ #clock-cells = <0x0>;
+ clock-frequency = <100000000>;
+ clock-output-names = "adl3clk_100mhz";
+ };
+
+ ccpclk: clk375mhz {
+ compatible = "fixed-clock";
+ #clock-cells = <0x0>;
+ clock-frequency = <375000000>;
+ clock-output-names = "ccpclk_375mhz";
+ };
+
+ sataclk: clk333mhz {
+ compatible = "fixed-clock";
+ #clock-cells = <0x0>;
+ clock-frequency = <333000000>;
+ clock-output-names = "sataclk_333mhz";
+ };
+
+ pcieclk: clk500mhz_0 {
+ compatible = "fixed-clock";
+ #clock-cells = <0x0>;
+ clock-frequency = <500000000>;
+ clock-output-names = "pcieclk_500mhz";
+ };
+
+ dmaclk: clk500mhz_1 {
+ compatible = "fixed-clock";
+ #clock-cells = <0x0>;
+ clock-frequency = <500000000>;
+ clock-output-names = "dmaclk_500mhz";
+ };
+
+ miscclk: clk250mhz_4 {
+ compatible = "fixed-clock";
+ #clock-cells = <0x0>;
+ clock-frequency = <250000000>;
+ clock-output-names = "miscclk_250mhz";
+ };
+
+ uartspiclk: clk100mhz_1 {
+ compatible = "fixed-clock";
+ #clock-cells = <0x0>;
+ clock-frequency = <100000000>;
+ clock-output-names = "uartspiclk_100mhz";
+ };
+
+ sata0_smmu: smmu@e0200000 {
+ compatible = "arm,mmu-401";
+ reg = <0 0xe0200000 0 0x10000>;
+
+ /* Uses combined intr for both global and context */
+ #global-interrupts = <1>;
+ interrupts = <GIC_SPI 332 IRQ_TYPE_LEVEL_HIGH>,
+ <GIC_SPI 332 IRQ_TYPE_LEVEL_HIGH>;
+ #iommu-cells = <2>;
+ dma-coherent;
+ };
+
+ sata1_smmu: smmu@e0c00000 {
+ compatible = "arm,mmu-401";
+ reg = <0 0xe0c00000 0 0x10000>;
+
+ /* Uses combined intr for both global and context */
+ #global-interrupts = <1>;
+ interrupts = <GIC_SPI 331 IRQ_TYPE_LEVEL_HIGH>,
+ <GIC_SPI 331 IRQ_TYPE_LEVEL_HIGH>;
+ #iommu-cells = <2>;
+ dma-coherent;
+ };
+
+ sata@e0300000 {
+ compatible = "snps,dwc-ahci";
+ reg = <0x0 0xe0300000 0x0 0xf0000>;
+ interrupts = <GIC_SPI 0x163 IRQ_TYPE_LEVEL_HIGH>;
+ clocks = <&sataclk>;
+ dma-coherent;
+ iommus = <&sata0_smmu 0x00 0x1f>; /* 0-31 */
+ };
+
+ sata@e0d00000 {
+ status = "disabled";
+ compatible = "snps,dwc-ahci";
+ reg = <0x0 0xe0d00000 0x0 0xf0000>;
+ interrupts = <GIC_SPI 0x162 IRQ_TYPE_LEVEL_HIGH>;
+ clocks = <&sataclk>;
+ dma-coherent;
+ iommus = <&sata1_smmu 0x00 0x1f>; /* 0-31 */
+ };
+
+ i2c@e1000000 {
+ compatible = "snps,designware-i2c";
+ reg = <0x0 0xe1000000 0x0 0x1000>;
+ interrupts = <GIC_SPI 0x165 IRQ_TYPE_LEVEL_HIGH>;
+ clocks = <&miscclk>;
+ };
+
+ i2c@e0050000 {
+ compatible = "snps,designware-i2c";
+ reg = <0x0 0xe0050000 0x0 0x1000>;
+ interrupts = <GIC_SPI 0x154 IRQ_TYPE_LEVEL_HIGH>;
+ clocks = <&miscclk>;
+ };
+
+ serial@e1010000 {
+ compatible = "arm,pl011", "arm,primecell";
+ reg = <0x0 0xe1010000 0x0 0x1000>;
+ interrupts = <GIC_SPI 0x148 IRQ_TYPE_LEVEL_HIGH>;
+ clocks = <&uartspiclk &uartspiclk>;
+ clock-names = "uartclk", "apb_pclk";
+ };
+
+ ssp@e1020000 {
+ compatible = "arm,pl022", "arm,primecell";
+ reg = <0x0 0xe1020000 0x0 0x1000>;
+ spi-controller;
+ interrupts = <GIC_SPI 0x14a IRQ_TYPE_LEVEL_HIGH>;
+ clocks = <&uartspiclk>;
+ clock-names = "apb_pclk";
+ };
+
+ ssp@e1030000 {
+ compatible = "arm,pl022", "arm,primecell";
+ reg = <0x0 0xe1030000 0x0 0x1000>;
+ spi-controller;
+ interrupts = <GIC_SPI 0x149 IRQ_TYPE_LEVEL_HIGH>;
+ clocks = <&uartspiclk>;
+ clock-names = "apb_pclk";
+ num-cs = <0x1>;
+ #address-cells = <0x1>;
+ #size-cells = <0x0>;
+
+ sdcard@0 {
+ compatible = "mmc-spi-slot";
+ reg = <0x0>;
+ spi-max-frequency = <20000000>;
+ voltage-ranges = <3200 3400>;
+ pl022,hierarchy = <0x0>;
+ pl022,interface = <0x0>;
+ pl022,com-mode = <0x0>;
+ pl022,rx-level-trig = <0x0>;
+ pl022,tx-level-trig = <0x0>;
+ };
+ };
+
+ gpio@e1050000 { /* [0 : 7] */
+ compatible = "arm,pl061", "arm,primecell";
+ #gpio-cells = <0x2>;
+ reg = <0x0 0xe1050000 0x0 0x1000>;
+ gpio-controller;
+ interrupt-controller;
+ #interrupt-cells = <0x2>;
+ interrupts = <GIC_SPI 0x166 IRQ_TYPE_LEVEL_HIGH>;
+ clocks = <&uartspiclk>;
+ clock-names = "apb_pclk";
+ };
+
+ gpio@e0020000 { /* [8 : 15] */
+ status = "disabled";
+ compatible = "arm,pl061", "arm,primecell";
+ #gpio-cells = <0x2>;
+ reg = <0x0 0xe0020000 0x0 0x1000>;
+ gpio-controller;
+ interrupt-controller;
+ #interrupt-cells = <0x2>;
+ interrupts = <GIC_SPI 0x16e IRQ_TYPE_LEVEL_HIGH>;
+ clocks = <&uartspiclk>;
+ clock-names = "apb_pclk";
+ };
+
+ gpio@e0030000 { /* [16 : 23] */
+ status = "disabled";
+ compatible = "arm,pl061", "arm,primecell";
+ #gpio-cells = <0x2>;
+ reg = <0x0 0xe0030000 0x0 0x1000>;
+ gpio-controller;
+ interrupt-controller;
+ #interrupt-cells = <0x2>;
+ interrupts = <GIC_SPI 0x16d IRQ_TYPE_LEVEL_HIGH>;
+ clocks = <&uartspiclk>;
+ clock-names = "apb_pclk";
+ };
+
+ gpio@e0080000 { /* [24] */
+ compatible = "arm,pl061", "arm,primecell";
+ #gpio-cells = <0x2>;
+ reg = <0x0 0xe0080000 0x0 0x1000>;
+ gpio-controller;
+ interrupt-controller;
+ #interrupt-cells = <0x2>;
+ interrupts = <GIC_SPI 0x169 IRQ_TYPE_LEVEL_HIGH>;
+ clocks = <&uartspiclk>;
+ clock-names = "apb_pclk";
+ };
+
+ ccp: ccp@e0100000 {
+ compatible = "amd,ccp-seattle-v1a";
+ reg = <0x0 0xe0100000 0x0 0x10000>;
+ interrupts = <GIC_SPI 0x3 IRQ_TYPE_LEVEL_HIGH>;
+ dma-coherent;
+ amd,zlib-support = <0x1>;
+ };
+
+ pcie: pcie@f0000000 {
+ compatible = "pci-host-ecam-generic";
+ #address-cells = <0x3>;
+ #size-cells = <0x2>;
+ #interrupt-cells = <0x1>;
+ iommu-map = <0x0 &pcie_smmu 0x0 0x10000>;
+ device_type = "pci";
+ bus-range = <0x0 0x7f>;
+ msi-parent = <&msi>;
+ reg = <0x0 0xf0000000 0x0 0x10000000>;
+ interrupt-map-mask = <0xff00 0x0 0x0 0x7>;
+ interrupt-map = <0x1100 0x0 0x0 0x1 &gic 0x0 0x0 GIC_SPI 0x120 IRQ_TYPE_EDGE_RISING>,
+ <0x1100 0x0 0x0 0x2 &gic 0x0 0x0 GIC_SPI 0x121 IRQ_TYPE_EDGE_RISING>,
+ <0x1100 0x0 0x0 0x3 &gic 0x0 0x0 GIC_SPI 0x122 IRQ_TYPE_EDGE_RISING>,
+ <0x1100 0x0 0x0 0x4 &gic 0x0 0x0 GIC_SPI 0x123 IRQ_TYPE_EDGE_RISING>,
+
+ <0x1200 0x0 0x0 0x1 &gic 0x0 0x0 GIC_SPI 0x124 IRQ_TYPE_EDGE_RISING>,
+ <0x1200 0x0 0x0 0x2 &gic 0x0 0x0 GIC_SPI 0x125 IRQ_TYPE_EDGE_RISING>,
+ <0x1200 0x0 0x0 0x3 &gic 0x0 0x0 GIC_SPI 0x126 IRQ_TYPE_EDGE_RISING>,
+ <0x1200 0x0 0x0 0x4 &gic 0x0 0x0 GIC_SPI 0x127 IRQ_TYPE_EDGE_RISING>,
+
+ <0x1300 0x0 0x0 0x1 &gic 0x0 0x0 GIC_SPI 0x128 IRQ_TYPE_EDGE_RISING>,
+ <0x1300 0x0 0x0 0x2 &gic 0x0 0x0 GIC_SPI 0x129 IRQ_TYPE_EDGE_RISING>,
+ <0x1300 0x0 0x0 0x3 &gic 0x0 0x0 GIC_SPI 0x12a IRQ_TYPE_EDGE_RISING>,
+ <0x1300 0x0 0x0 0x4 &gic 0x0 0x0 GIC_SPI 0x12b IRQ_TYPE_EDGE_RISING>;
+ dma-coherent;
+ dma-ranges = <0x43000000 0x0 0x0 0x0 0x0 0x100 0x0>;
+ ranges = <0x1000000 0x0 0x00000000 0x0 0xefff0000 0x00 0x00010000>, /* I/O Memory (size=64K) */
+ <0x2000000 0x0 0x40000000 0x0 0x40000000 0x00 0x80000000>, /* 32-bit MMIO (size=2G) */
+ <0x3000000 0x1 0x00000000 0x1 0x00000000 0x7f 0x00000000>; /* 64-bit MMIO (size= 124G) */
+ };
+
+ pcie_smmu: smmu@e0a00000 {
+ compatible = "arm,mmu-401";
+ reg = <0 0xe0a00000 0 0x10000>;
+
+ /* Uses combined intr for both global and context */
+ #global-interrupts = <1>;
+ interrupts = <GIC_SPI 333 IRQ_TYPE_LEVEL_HIGH>,
+ <GIC_SPI 333 IRQ_TYPE_LEVEL_HIGH>;
+ #iommu-cells = <1>;
+ dma-coherent;
+ };
+
+ ccn@0xe8000000 {
+ compatible = "arm,ccn-504";
+ reg = <0x0 0xe8000000 0x0 0x1000000>;
+ interrupts = <GIC_SPI 0x17c IRQ_TYPE_LEVEL_HIGH>;
+ };
+
+ gwdt@e0bb0000 {
+ status = "disabled";
+ compatible = "arm,sbsa-gwdt";
+ reg = <0x0 0xe0bb0000 0x0 0x10000
+ 0x0 0xe0bc0000 0x0 0x10000>;
+ reg-names = "refresh", "control";
+ interrupts = <GIC_SPI 0x151 IRQ_TYPE_LEVEL_HIGH>;
+ interrupt-names = "ws0";
+ };
+
+ kcs@e0010000 {
+ status = "disabled";
+ compatible = "ipmi-kcs";
+ device_type = "ipmi";
+ reg = <0x0 0xe0010000 0 0x8>;
+ interrupts = <GIC_SPI 389 IRQ_TYPE_LEVEL_HIGH>;
+ interrupt-names = "ipmi_kcs";
+ reg-size = <1>;
+ reg-spacing = <4>;
+ };
+
+ xgmacclk0_dma: clk250mhz_0 {
+ compatible = "fixed-clock";
+ #clock-cells = <0x0>;
+ clock-frequency = <250000000>;
+ clock-output-names = "xgmacclk0_dma_250mhz";
+ };
+
+ xgmacclk0_ptp: clk250mhz_1 {
+ compatible = "fixed-clock";
+ #clock-cells = <0x0>;
+ clock-frequency = <250000000>;
+ clock-output-names = "xgmacclk0_ptp_250mhz";
+ };
+
+ xgmacclk1_dma: clk250mhz_2 {
+ compatible = "fixed-clock";
+ #clock-cells = <0x0>;
+ clock-frequency = <250000000>;
+ clock-output-names = "xgmacclk1_dma_250mhz";
+ };
+
+ xgmacclk1_ptp: clk250mhz_3 {
+ compatible = "fixed-clock";
+ #clock-cells = <0x0>;
+ clock-frequency = <250000000>;
+ clock-output-names = "xgmacclk1_ptp_250mhz";
+ };
+
+ xgmac0_phy: phy@e1240800 {
+ compatible = "amd,xgbe-phy-seattle-v1a";
+ reg = <0x0 0xe1240800 0x0 0x0400>, /* SERDES RX/TX0 */
+ <0x0 0xe1250000 0x0 0x0060>, /* SERDES IR 1/2 */
+ <0x0 0xe12500f8 0x0 0x0004>; /* SERDES IR 2/2 */
+ interrupts = <GIC_SPI 0x143 IRQ_TYPE_LEVEL_HIGH>;
+ amd,speed-set = <0x0>;
+ amd,serdes-blwc = <0x1 0x1 0x0>;
+ amd,serdes-cdr-rate = <0x2 0x2 0x7>;
+ amd,serdes-pq-skew = <0xa 0xa 0x12>;
+ amd,serdes-tx-amp = <0xf 0xf 0xa>;
+ amd,serdes-dfe-tap-config = <0x3 0x3 0x1>;
+ amd,serdes-dfe-tap-enable = <0x0 0x0 0x7f>;
+ status = "disabled";
+ };
+
+ xgmac1_phy: phy@e1240c00 {
+ compatible = "amd,xgbe-phy-seattle-v1a";
+ reg = <0x0 0xe1240c00 0x0 0x0400>, /* SERDES RX/TX0 */
+ <0x0 0xe1250080 0x0 0x0060>, /* SERDES IR 1/2 */
+ <0x0 0xe12500fc 0x0 0x0004>; /* SERDES IR 2/2 */
+ interrupts = <GIC_SPI 0x142 IRQ_TYPE_LEVEL_HIGH>;
+ amd,speed-set = <0x0>;
+ amd,serdes-blwc = <0x1 0x1 0x0>;
+ amd,serdes-cdr-rate = <0x2 0x2 0x7>;
+ amd,serdes-pq-skew = <0xa 0xa 0x12>;
+ amd,serdes-tx-amp = <0xf 0xf 0xa>;
+ amd,serdes-dfe-tap-config = <0x3 0x3 0x1>;
+ amd,serdes-dfe-tap-enable = <0x0 0x0 0x7f>;
+ status = "disabled";
+ };
+
+ xgmac0_smmu: smmu@e0600000 {
+ compatible = "arm,mmu-401";
+ reg = <0 0xe0600000 0 0x10000>;
+
+ /* Uses combined intr for both global and context */
+ #global-interrupts = <1>;
+ interrupts = <GIC_SPI 336 IRQ_TYPE_LEVEL_HIGH>,
+ <GIC_SPI 336 IRQ_TYPE_LEVEL_HIGH>;
+ #iommu-cells = <2>;
+ dma-coherent;
+ };
+
+ xgmac1_smmu: smmu@e0800000 {
+ compatible = "arm,mmu-401";
+ reg = <0 0xe0800000 0 0x10000>;
+
+ /* Uses combined intr for both global and context */
+ #global-interrupts = <1>;
+ interrupts = <GIC_SPI 335 IRQ_TYPE_LEVEL_HIGH>,
+ <GIC_SPI 335 IRQ_TYPE_LEVEL_HIGH>;
+ #iommu-cells = <2>;
+ dma-coherent;
+ };
+
+ xgmac@e0700000 {
+ compatible = "amd,xgbe-seattle-v1a";
+ reg = <0x0 0xe0700000 0x0 0x80000 0x0 0xe0780000 0x0 0x80000>;
+ interrupts = <GIC_SPI 0x145 IRQ_TYPE_LEVEL_HIGH>,
+ <GIC_SPI 0x15a IRQ_TYPE_EDGE_RISING>,
+ <GIC_SPI 0x15b IRQ_TYPE_EDGE_RISING>,
+ <GIC_SPI 0x15c IRQ_TYPE_EDGE_RISING>,
+ <GIC_SPI 0x15d IRQ_TYPE_EDGE_RISING>;
+ amd,per-channel-interrupt;
+ mac-address = [02 a1 a2 a3 a4 a5];
+ clocks = <&xgmacclk0_dma &xgmacclk0_ptp>;
+ clock-names = "dma_clk", "ptp_clk";
+ phy-handle = <&xgmac0_phy>;
+ phy-mode = "xgmii";
+
+ iommus = <&xgmac0_smmu 0x00 0x1f>; /* 0-31 */
+ dma-coherent;
+ status = "disabled";
+ };
+
+ xgmac@e0900000 {
+ compatible = "amd,xgbe-seattle-v1a";
+ reg = <0x0 0xe0900000 0x0 0x80000 0x0 0xe0980000 0x0 0x80000>;
+ interrupts = <GIC_SPI 0x144 IRQ_TYPE_LEVEL_HIGH>,
+ <GIC_SPI 0x155 IRQ_TYPE_EDGE_RISING>,
+ <GIC_SPI 0x156 IRQ_TYPE_EDGE_RISING>,
+ <GIC_SPI 0x157 IRQ_TYPE_EDGE_RISING>,
+ <GIC_SPI 0x158 IRQ_TYPE_EDGE_RISING>;
+ amd,per-channel-interrupt;
+ mac-address = [02 b1 b2 b3 b4 b5];
+ clocks = <&xgmacclk1_dma &xgmacclk1_ptp>;
+ clock-names = "dma_clk", "ptp_clk";
+ phy-handle = <&xgmac1_phy>;
+ phy-mode = "xgmii";
+
+ iommus = <&xgmac1_smmu 0x00 0x1f>; /* 0-31 */
+ dma-coherent;
+ status = "disabled";
+ };
+ };
+
+ chosen {
+ stdout-path = "/smb/serial@e1010000";
+ };
+
+ psci {
+ compatible = "arm,psci-0.2", "arm,psci";
+ method = "smc";
+ };
};
--
2.11.0
^ permalink raw reply related [flat|nested] 11+ messages in thread
* [PATCH edk2-platforms v2 3/4] Platform/OverdriveBoard: fix CPU affinity for vGIC maintenace interrupt
2017-08-31 13:08 [PATCH edk2-platforms v2 0/4] Platform/OverdriveBoard: move device tree compilation into build Ard Biesheuvel
2017-08-31 13:08 ` [PATCH edk2-platforms v2 1/4] " Ard Biesheuvel
2017-08-31 13:08 ` [PATCH edk2-platforms v2 2/4] Platform/OverdriveBoard: clean up device tree source file Ard Biesheuvel
@ 2017-08-31 13:08 ` Ard Biesheuvel
2017-09-01 11:13 ` Leif Lindholm
2017-08-31 13:08 ` [PATCH edk2-platforms v2 4/4] Platform/OverdriveBoard: classify legacy INTx interrupts as level high Ard Biesheuvel
3 siblings, 1 reply; 11+ messages in thread
From: Ard Biesheuvel @ 2017-08-31 13:08 UTC (permalink / raw)
To: edk2-devel; +Cc: leif.lindholm, alan, liming.gao, yonghong.zhu, Ard Biesheuvel
The CPU affinity for the vGIC maintenance interrupt was set to
CPUs #0 .. #3 for no good reason. So set it to all CPUs instead.
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
---
Platform/AMD/OverdriveBoard/OverdriveBoardDeviceTree/OverdriveBoardDeviceTree.dts | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/Platform/AMD/OverdriveBoard/OverdriveBoardDeviceTree/OverdriveBoardDeviceTree.dts b/Platform/AMD/OverdriveBoard/OverdriveBoardDeviceTree/OverdriveBoardDeviceTree.dts
index 81477fe43cdd..e57e702029ba 100644
--- a/Platform/AMD/OverdriveBoard/OverdriveBoardDeviceTree/OverdriveBoardDeviceTree.dts
+++ b/Platform/AMD/OverdriveBoard/OverdriveBoardDeviceTree/OverdriveBoardDeviceTree.dts
@@ -45,7 +45,7 @@
<0x0 0xe112f000 0x0 0x2000>,
<0x0 0xe1140000 0x0 0x2000>,
<0x0 0xe1160000 0x0 0x2000>;
- interrupts = <GIC_PPI 0x9 (IRQ_TYPE_LEVEL_HIGH | GIC_CPU_MASK(4))>;
+ interrupts = <GIC_PPI 0x9 (IRQ_TYPE_LEVEL_HIGH | GIC_CPU_MASK(8))>;
ranges = <0x0 0x0 0x0 0xe1100000 0x0 0x100000>;
msi: v2m@e0080000 {
--
2.11.0
^ permalink raw reply related [flat|nested] 11+ messages in thread
* [PATCH edk2-platforms v2 4/4] Platform/OverdriveBoard: classify legacy INTx interrupts as level high
2017-08-31 13:08 [PATCH edk2-platforms v2 0/4] Platform/OverdriveBoard: move device tree compilation into build Ard Biesheuvel
` (2 preceding siblings ...)
2017-08-31 13:08 ` [PATCH edk2-platforms v2 3/4] Platform/OverdriveBoard: fix CPU affinity for vGIC maintenace interrupt Ard Biesheuvel
@ 2017-08-31 13:08 ` Ard Biesheuvel
2017-09-01 11:14 ` Leif Lindholm
3 siblings, 1 reply; 11+ messages in thread
From: Ard Biesheuvel @ 2017-08-31 13:08 UTC (permalink / raw)
To: edk2-devel; +Cc: leif.lindholm, alan, liming.gao, yonghong.zhu, Ard Biesheuvel
Fix the trigger type of the legacy INTx interrupts. The Seattle SoC manual
classifies them as level high, not rising edge.
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
---
Platform/AMD/OverdriveBoard/OverdriveBoardDeviceTree/OverdriveBoardDeviceTree.dts | 28 ++++++++++----------
1 file changed, 14 insertions(+), 14 deletions(-)
diff --git a/Platform/AMD/OverdriveBoard/OverdriveBoardDeviceTree/OverdriveBoardDeviceTree.dts b/Platform/AMD/OverdriveBoard/OverdriveBoardDeviceTree/OverdriveBoardDeviceTree.dts
index e57e702029ba..2c05fdbb8b71 100644
--- a/Platform/AMD/OverdriveBoard/OverdriveBoardDeviceTree/OverdriveBoardDeviceTree.dts
+++ b/Platform/AMD/OverdriveBoard/OverdriveBoardDeviceTree/OverdriveBoardDeviceTree.dts
@@ -291,20 +291,20 @@
msi-parent = <&msi>;
reg = <0x0 0xf0000000 0x0 0x10000000>;
interrupt-map-mask = <0xff00 0x0 0x0 0x7>;
- interrupt-map = <0x1100 0x0 0x0 0x1 &gic 0x0 0x0 GIC_SPI 0x120 IRQ_TYPE_EDGE_RISING>,
- <0x1100 0x0 0x0 0x2 &gic 0x0 0x0 GIC_SPI 0x121 IRQ_TYPE_EDGE_RISING>,
- <0x1100 0x0 0x0 0x3 &gic 0x0 0x0 GIC_SPI 0x122 IRQ_TYPE_EDGE_RISING>,
- <0x1100 0x0 0x0 0x4 &gic 0x0 0x0 GIC_SPI 0x123 IRQ_TYPE_EDGE_RISING>,
-
- <0x1200 0x0 0x0 0x1 &gic 0x0 0x0 GIC_SPI 0x124 IRQ_TYPE_EDGE_RISING>,
- <0x1200 0x0 0x0 0x2 &gic 0x0 0x0 GIC_SPI 0x125 IRQ_TYPE_EDGE_RISING>,
- <0x1200 0x0 0x0 0x3 &gic 0x0 0x0 GIC_SPI 0x126 IRQ_TYPE_EDGE_RISING>,
- <0x1200 0x0 0x0 0x4 &gic 0x0 0x0 GIC_SPI 0x127 IRQ_TYPE_EDGE_RISING>,
-
- <0x1300 0x0 0x0 0x1 &gic 0x0 0x0 GIC_SPI 0x128 IRQ_TYPE_EDGE_RISING>,
- <0x1300 0x0 0x0 0x2 &gic 0x0 0x0 GIC_SPI 0x129 IRQ_TYPE_EDGE_RISING>,
- <0x1300 0x0 0x0 0x3 &gic 0x0 0x0 GIC_SPI 0x12a IRQ_TYPE_EDGE_RISING>,
- <0x1300 0x0 0x0 0x4 &gic 0x0 0x0 GIC_SPI 0x12b IRQ_TYPE_EDGE_RISING>;
+ interrupt-map = <0x1100 0x0 0x0 0x1 &gic 0x0 0x0 GIC_SPI 0x120 IRQ_TYPE_LEVEL_HIGH>,
+ <0x1100 0x0 0x0 0x2 &gic 0x0 0x0 GIC_SPI 0x121 IRQ_TYPE_LEVEL_HIGH>,
+ <0x1100 0x0 0x0 0x3 &gic 0x0 0x0 GIC_SPI 0x122 IRQ_TYPE_LEVEL_HIGH>,
+ <0x1100 0x0 0x0 0x4 &gic 0x0 0x0 GIC_SPI 0x123 IRQ_TYPE_LEVEL_HIGH>,
+
+ <0x1200 0x0 0x0 0x1 &gic 0x0 0x0 GIC_SPI 0x124 IRQ_TYPE_LEVEL_HIGH>,
+ <0x1200 0x0 0x0 0x2 &gic 0x0 0x0 GIC_SPI 0x125 IRQ_TYPE_LEVEL_HIGH>,
+ <0x1200 0x0 0x0 0x3 &gic 0x0 0x0 GIC_SPI 0x126 IRQ_TYPE_LEVEL_HIGH>,
+ <0x1200 0x0 0x0 0x4 &gic 0x0 0x0 GIC_SPI 0x127 IRQ_TYPE_LEVEL_HIGH>,
+
+ <0x1300 0x0 0x0 0x1 &gic 0x0 0x0 GIC_SPI 0x128 IRQ_TYPE_LEVEL_HIGH>,
+ <0x1300 0x0 0x0 0x2 &gic 0x0 0x0 GIC_SPI 0x129 IRQ_TYPE_LEVEL_HIGH>,
+ <0x1300 0x0 0x0 0x3 &gic 0x0 0x0 GIC_SPI 0x12a IRQ_TYPE_LEVEL_HIGH>,
+ <0x1300 0x0 0x0 0x4 &gic 0x0 0x0 GIC_SPI 0x12b IRQ_TYPE_LEVEL_HIGH>;
dma-coherent;
dma-ranges = <0x43000000 0x0 0x0 0x0 0x0 0x100 0x0>;
ranges = <0x1000000 0x0 0x00000000 0x0 0xefff0000 0x00 0x00010000>, /* I/O Memory (size=64K) */
--
2.11.0
^ permalink raw reply related [flat|nested] 11+ messages in thread
* Re: [PATCH edk2-platforms v2 2/4] Platform/OverdriveBoard: clean up device tree source file
2017-08-31 13:08 ` [PATCH edk2-platforms v2 2/4] Platform/OverdriveBoard: clean up device tree source file Ard Biesheuvel
@ 2017-09-01 11:12 ` Leif Lindholm
2017-09-01 11:14 ` Ard Biesheuvel
0 siblings, 1 reply; 11+ messages in thread
From: Leif Lindholm @ 2017-09-01 11:12 UTC (permalink / raw)
To: Ard Biesheuvel; +Cc: edk2-devel, alan, Grant Likely
Adding Grant,
On Thu, Aug 31, 2017 at 02:08:28PM +0100, Ard Biesheuvel wrote:
> Clean up the device tree source file, by switching to Tianocore
> conventions for line endings and whitespace etc, and by replacing
> open coded values with symbol constants and/or phandle references.
1: All for the getting rid of open coding.
2: As for the line endings/whitespace, I am less convinced.
It is its own (and very specific) file format, it is not
edk2-specific, and just like (GNU)Makefiles and shellscripts they
originated in a CR-free environment.
/
Leif
> The resulting .dtb will likely not be identical at the bit level, but
> the modifications are cosmetic only.
>
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
> ---
> Platform/AMD/OverdriveBoard/OverdriveBoardDeviceTree/OverdriveBoardDeviceTree.dts | 957 ++++++++++----------
> 1 file changed, 467 insertions(+), 490 deletions(-)
>
> diff --git a/Platform/AMD/OverdriveBoard/OverdriveBoardDeviceTree/OverdriveBoardDeviceTree.dts b/Platform/AMD/OverdriveBoard/OverdriveBoardDeviceTree/OverdriveBoardDeviceTree.dts
> index 4039f666004a..81477fe43cdd 100644
> --- a/Platform/AMD/OverdriveBoard/OverdriveBoardDeviceTree/OverdriveBoardDeviceTree.dts
> +++ b/Platform/AMD/OverdriveBoard/OverdriveBoardDeviceTree/OverdriveBoardDeviceTree.dts
> @@ -2,6 +2,7 @@
> * DTS file for AMD Seattle (Rev.B) Overdrive Development Board
> *
> * Copyright 2015 - 2016 ADVANCED MICRO DEVICES, INC. All Rights Reserved.
> + * Copyright 2015 - 2017 Linaro, Ltd. All Rights Reserved.
> *
> * This program and the accompanying materials are licensed and made available
> * under the terms and conditions of the BSD License which accompanies this
> @@ -14,497 +15,473 @@
> *
> */
>
> +#define GIC_SPI 0
> +#define GIC_PPI 1
> +
> +#define IRQ_TYPE_NONE 0
> +#define IRQ_TYPE_EDGE_RISING 1
> +#define IRQ_TYPE_EDGE_FALLING 2
> +#define IRQ_TYPE_LEVEL_HIGH 4
> +#define IRQ_TYPE_LEVEL_LOW 8
> +
> +#define GIC_CPU_MASK(num) (((1 << (num)) - 1) << 8)
> +
> /dts-v1/;
>
> / {
> - model = "AMD Seattle (Rev.B) Development Board (Overdrive)";
> - compatible = "amd,seattle-overdrive", "amd,seattle";
> - interrupt-parent = <0x1>;
> - #address-cells = <0x2>;
> - #size-cells = <0x2>;
> -
> - interrupt-controller@e1101000 {
> - compatible = "arm,gic-400", "arm,cortex-a15-gic";
> - interrupt-controller;
> - #interrupt-cells = <0x3>;
> - #address-cells = <0x2>;
> - #size-cells = <0x2>;
> - reg = <0x0 0xe1110000 0x0 0x1000>,
> - <0x0 0xe112f000 0x0 0x2000>,
> - <0x0 0xe1140000 0x0 0x2000>,
> - <0x0 0xe1160000 0x0 0x2000>;
> - interrupts = <0x1 0x9 0xf04>;
> - ranges = <0x0 0x0 0x0 0xe1100000 0x0 0x100000>;
> - linux,phandle = <0x1>;
> - phandle = <0x1>;
> -
> - v2m@e0080000 {
> - compatible = "arm,gic-v2m-frame";
> - msi-controller;
> - reg = <0x0 0x80000 0x0 0x1000>;
> - linux,phandle = <0x4>;
> - phandle = <0x4>;
> - };
> - };
> -
> - timer {
> - compatible = "arm,armv8-timer";
> - interrupts = <0x1 0xd 0xff04>,
> - <0x1 0xe 0xff04>,
> - <0x1 0xb 0xff04>,
> - <0x1 0xa 0xff04>;
> - };
> -
> - smb {
> - compatible = "simple-bus";
> - #address-cells = <0x2>;
> - #size-cells = <0x2>;
> - ranges;
> - /*
> - * dma-ranges is 40-bit address space containing:
> - * - GICv2m MSI register is at 0xe0080000
> - * - DRAM range [0x8000000000 to 0xffffffffff]
> - */
> - dma-ranges = <0x0 0x0 0x0 0x0 0x100 0x0>;
> -
> - clk100mhz_0 {
> - compatible = "fixed-clock";
> - #clock-cells = <0x0>;
> - clock-frequency = <100000000>;
> - clock-output-names = "adl3clk_100mhz";
> - };
> -
> - clk375mhz {
> - compatible = "fixed-clock";
> - #clock-cells = <0x0>;
> - clock-frequency = <375000000>;
> - clock-output-names = "ccpclk_375mhz";
> - };
> -
> - clk333mhz {
> - compatible = "fixed-clock";
> - #clock-cells = <0x0>;
> - clock-frequency = <333000000>;
> - clock-output-names = "sataclk_333mhz";
> - linux,phandle = <0x2>;
> - phandle = <0x2>;
> - };
> -
> - clk500mhz_0 {
> - compatible = "fixed-clock";
> - #clock-cells = <0x0>;
> - clock-frequency = <500000000>;
> - clock-output-names = "pcieclk_500mhz";
> - };
> -
> - clk500mhz_1 {
> - compatible = "fixed-clock";
> - #clock-cells = <0x0>;
> - clock-frequency = <500000000>;
> - clock-output-names = "dmaclk_500mhz";
> - };
> -
> - clk250mhz_4 {
> - compatible = "fixed-clock";
> - #clock-cells = <0x0>;
> - clock-frequency = <250000000>;
> - clock-output-names = "miscclk_250mhz";
> - linux,phandle = <0xd>;
> - phandle = <0xd>;
> - };
> -
> - clk100mhz_1 {
> - compatible = "fixed-clock";
> - #clock-cells = <0x0>;
> - clock-frequency = <100000000>;
> - clock-output-names = "uartspiclk_100mhz";
> - linux,phandle = <0x3>;
> - phandle = <0x3>;
> - };
> -
> - sata0_smmu: smmu@e0200000 {
> - compatible = "arm,mmu-401";
> - reg = <0 0xe0200000 0 0x10000>;
> - #global-interrupts = <1>;
> - interrupts = /* Uses combined intr for both
> - * global and context
> - */
> - <0 332 4>,
> - <0 332 4>;
> - #iommu-cells = <2>;
> - dma-coherent;
> - };
> -
> - sata1_smmu: smmu@e0c00000 {
> - compatible = "arm,mmu-401";
> - reg = <0 0xe0c00000 0 0x10000>;
> - #global-interrupts = <1>;
> - interrupts = /* Uses combined intr for both
> - * global and context
> - */
> - <0 331 4>,
> - <0 331 4>;
> - #iommu-cells = <2>;
> - dma-coherent;
> - };
> -
> - sata@e0300000 {
> - compatible = "snps,dwc-ahci";
> - reg = <0x0 0xe0300000 0x0 0xf0000>;
> - interrupts = <0x0 0x163 0x4>;
> - clocks = <0x2>;
> - dma-coherent;
> - iommus = <&sata0_smmu 0x00 0x1f>; /* 0-31 */
> - };
> -
> - sata@e0d00000 {
> - status = "disabled";
> - compatible = "snps,dwc-ahci";
> - reg = <0x0 0xe0d00000 0x0 0xf0000>;
> - interrupts = <0x0 0x162 0x4>;
> - clocks = <0x2>;
> - dma-coherent;
> - iommus = <&sata1_smmu 0x00 0x1f>; /* 0-31 */
> - };
> -
> - i2c@e1000000 {
> - compatible = "snps,designware-i2c";
> - reg = <0x0 0xe1000000 0x0 0x1000>;
> - interrupts = <0x0 0x165 0x4>;
> - clocks = <0xd>;
> - };
> -
> - i2c@e0050000 {
> - compatible = "snps,designware-i2c";
> - reg = <0x0 0xe0050000 0x0 0x1000>;
> - interrupts = <0x0 0x154 0x4>;
> - clocks = <0xd>;
> - };
> -
> - serial@e1010000 {
> - compatible = "arm,pl011", "arm,primecell";
> - reg = <0x0 0xe1010000 0x0 0x1000>;
> - interrupts = <0x0 0x148 0x4>;
> - clocks = <0x3 0x3>;
> - clock-names = "uartclk", "apb_pclk";
> - };
> -
> - ssp@e1020000 {
> - compatible = "arm,pl022", "arm,primecell";
> - reg = <0x0 0xe1020000 0x0 0x1000>;
> - spi-controller;
> - interrupts = <0x0 0x14a 0x4>;
> - clocks = <0x3>;
> - clock-names = "apb_pclk";
> - };
> -
> - ssp@e1030000 {
> - compatible = "arm,pl022", "arm,primecell";
> - reg = <0x0 0xe1030000 0x0 0x1000>;
> - spi-controller;
> - interrupts = <0x0 0x149 0x4>;
> - clocks = <0x3>;
> - clock-names = "apb_pclk";
> - num-cs = <0x1>;
> - #address-cells = <0x1>;
> - #size-cells = <0x0>;
> -
> - sdcard@0 {
> - compatible = "mmc-spi-slot";
> - reg = <0x0>;
> - spi-max-frequency = <20000000>;
> - voltage-ranges = <3200 3400>;
> - pl022,hierarchy = <0x0>;
> - pl022,interface = <0x0>;
> - pl022,com-mode = <0x0>;
> - pl022,rx-level-trig = <0x0>;
> - pl022,tx-level-trig = <0x0>;
> - };
> - };
> -
> - gpio@e1050000 { /* [0 : 7] */
> - compatible = "arm,pl061", "arm,primecell";
> - #gpio-cells = <0x2>;
> - reg = <0x0 0xe1050000 0x0 0x1000>;
> - gpio-controller;
> - interrupt-controller;
> - #interrupt-cells = <0x2>;
> - interrupts = <0x0 0x166 0x4>;
> - clocks = <0x3>;
> - clock-names = "apb_pclk";
> - };
> -
> - gpio@e0020000 { /* [8 : 15] */
> - status = "disabled";
> - compatible = "arm,pl061", "arm,primecell";
> - #gpio-cells = <0x2>;
> - reg = <0x0 0xe0020000 0x0 0x1000>;
> - gpio-controller;
> - interrupt-controller;
> - #interrupt-cells = <0x2>;
> - interrupts = <0x0 0x16e 0x4>;
> - clocks = <0x3>;
> - clock-names = "apb_pclk";
> - };
> -
> - gpio@e0030000 { /* [16 : 23] */
> - status = "disabled";
> - compatible = "arm,pl061", "arm,primecell";
> - #gpio-cells = <0x2>;
> - reg = <0x0 0xe0030000 0x0 0x1000>;
> - gpio-controller;
> - interrupt-controller;
> - #interrupt-cells = <0x2>;
> - interrupts = <0x0 0x16d 0x4>;
> - clocks = <0x3>;
> - clock-names = "apb_pclk";
> - };
> -
> - gpio@e0080000 { /* [24] */
> - compatible = "arm,pl061", "arm,primecell";
> - #gpio-cells = <0x2>;
> - reg = <0x0 0xe0080000 0x0 0x1000>;
> - gpio-controller;
> - interrupt-controller;
> - #interrupt-cells = <0x2>;
> - interrupts = <0x0 0x169 0x4>;
> - clocks = <0x3>;
> - clock-names = "apb_pclk";
> - };
> -
> - ccp: ccp@e0100000 {
> - compatible = "amd,ccp-seattle-v1a";
> - reg = <0x0 0xe0100000 0x0 0x10000>;
> - interrupts = <0x0 0x3 0x4>;
> - dma-coherent;
> - amd,zlib-support = <0x1>;
> - };
> -
> - pcie: pcie@f0000000 {
> - compatible = "pci-host-ecam-generic";
> - #address-cells = <0x3>;
> - #size-cells = <0x2>;
> - #interrupt-cells = <0x1>;
> - iommu-map = <0x0 &pcie_smmu 0x0 0x10000>;
> - device_type = "pci";
> - bus-range = <0x0 0x7f>;
> - msi-parent = <0x4>;
> - reg = <0x0 0xf0000000 0x0 0x10000000>;
> - interrupt-map-mask = <0xff00 0x0 0x0 0x7>;
> - interrupt-map = <0x1100 0x0 0x0 0x1 0x1 0x0 0x0 0x0 0x120 0x1>,
> - <0x1100 0x0 0x0 0x2 0x1 0x0 0x0 0x0 0x121 0x1>,
> - <0x1100 0x0 0x0 0x3 0x1 0x0 0x0 0x0 0x122 0x1>,
> - <0x1100 0x0 0x0 0x4 0x1 0x0 0x0 0x0 0x123 0x1>,
> -
> - <0x1200 0x0 0x0 0x1 0x1 0x0 0x0 0x0 0x124 0x1>,
> - <0x1200 0x0 0x0 0x2 0x1 0x0 0x0 0x0 0x125 0x1>,
> - <0x1200 0x0 0x0 0x3 0x1 0x0 0x0 0x0 0x126 0x1>,
> - <0x1200 0x0 0x0 0x4 0x1 0x0 0x0 0x0 0x127 0x1>,
> -
> - <0x1300 0x0 0x0 0x1 0x1 0x0 0x0 0x0 0x128 0x1>,
> - <0x1300 0x0 0x0 0x2 0x1 0x0 0x0 0x0 0x129 0x1>,
> - <0x1300 0x0 0x0 0x3 0x1 0x0 0x0 0x0 0x12a 0x1>,
> - <0x1300 0x0 0x0 0x4 0x1 0x0 0x0 0x0 0x12b 0x1>;
> - dma-coherent;
> - dma-ranges = <0x43000000 0x0 0x0 0x0 0x0 0x100 0x0>;
> - ranges = <0x1000000 0x0 0x00000000 0x0 0xefff0000 0x00 0x00010000>, /* I/O Memory (size=64K) */
> - <0x2000000 0x0 0x40000000 0x0 0x40000000 0x00 0x80000000>, /* 32-bit MMIO (size=2G) */
> - <0x3000000 0x1 0x00000000 0x1 0x00000000 0x7f 0x00000000>; /* 64-bit MMIO (size= 124G) */
> - };
> -
> - pcie_smmu: smmu@e0a00000 {
> - compatible = "arm,mmu-401";
> - reg = <0 0xe0a00000 0 0x10000>;
> - #global-interrupts = <1>;
> - interrupts = /* Uses combined intr for both
> - * global and context
> - */
> - <0 333 4>,
> - <0 333 4>;
> - #iommu-cells = <1>;
> - dma-coherent;
> - };
> -
> - ccn@0xe8000000 {
> - compatible = "arm,ccn-504";
> - reg = <0x0 0xe8000000 0x0 0x1000000>;
> - interrupts = <0x0 0x17c 0x4>;
> - };
> -
> - gwdt@e0bb0000 {
> - status = "disabled";
> - compatible = "arm,sbsa-gwdt";
> - reg = <0x0 0xe0bb0000 0x0 0x10000
> - 0x0 0xe0bc0000 0x0 0x10000>;
> - reg-names = "refresh", "control";
> - interrupts = <0x0 0x151 0x4>;
> - interrupt-names = "ws0";
> - };
> -
> - kcs@e0010000 {
> - status = "disabled";
> - compatible = "ipmi-kcs";
> - device_type = "ipmi";
> - reg = <0x0 0xe0010000 0 0x8>;
> - interrupts = <0 389 4>;
> - interrupt-names = "ipmi_kcs";
> - reg-size = <1>;
> - reg-spacing = <4>;
> - };
> -
> - clk250mhz_0 {
> - compatible = "fixed-clock";
> - #clock-cells = <0x0>;
> - clock-frequency = <250000000>;
> - clock-output-names = "xgmacclk0_dma_250mhz";
> - linux,phandle = <0x5>;
> - phandle = <0x5>;
> - };
> -
> - clk250mhz_1 {
> - compatible = "fixed-clock";
> - #clock-cells = <0x0>;
> - clock-frequency = <250000000>;
> - clock-output-names = "xgmacclk0_ptp_250mhz";
> - linux,phandle = <0x6>;
> - phandle = <0x6>;
> - };
> -
> - clk250mhz_2 {
> - compatible = "fixed-clock";
> - #clock-cells = <0x0>;
> - clock-frequency = <250000000>;
> - clock-output-names = "xgmacclk1_dma_250mhz";
> - linux,phandle = <0x7>;
> - phandle = <0x7>;
> - };
> -
> - clk250mhz_3 {
> - compatible = "fixed-clock";
> - #clock-cells = <0x0>;
> - clock-frequency = <250000000>;
> - clock-output-names = "xgmacclk1_ptp_250mhz";
> - linux,phandle = <0x8>;
> - phandle = <0x8>;
> - };
> -
> - phy@e1240800 {
> - status = "disabled";
> - compatible = "amd,xgbe-phy-seattle-v1a";
> - reg = <0x0 0xe1240800 0x0 0x0400>, /* SERDES RX/TX0 */
> - <0x0 0xe1250000 0x0 0x0060>, /* SERDES IR 1/2 */
> - <0x0 0xe12500f8 0x0 0x0004>; /* SERDES IR 2/2 */
> - interrupts = <0x0 0x143 0x4>;
> - amd,speed-set = <0x0>;
> - amd,serdes-blwc = <0x1 0x1 0x0>;
> - amd,serdes-cdr-rate = <0x2 0x2 0x7>;
> - amd,serdes-pq-skew = <0xa 0xa 0x12>;
> - amd,serdes-tx-amp = <0xf 0xf 0xa>;
> - amd,serdes-dfe-tap-config = <0x3 0x3 0x1>;
> - amd,serdes-dfe-tap-enable = <0x0 0x0 0x7f>;
> - linux,phandle = <0x9>;
> - phandle = <0x9>;
> - };
> -
> - phy@e1240c00 {
> - status = "disabled";
> - compatible = "amd,xgbe-phy-seattle-v1a";
> - reg = <0x0 0xe1240c00 0x0 0x0400>, /* SERDES RX/TX0 */
> - <0x0 0xe1250080 0x0 0x0060>, /* SERDES IR 1/2 */
> - <0x0 0xe12500fc 0x0 0x0004>; /* SERDES IR 2/2 */
> - interrupts = <0x0 0x142 0x4>;
> - amd,speed-set = <0x0>;
> - amd,serdes-blwc = <0x1 0x1 0x0>;
> - amd,serdes-cdr-rate = <0x2 0x2 0x7>;
> - amd,serdes-pq-skew = <0xa 0xa 0x12>;
> - amd,serdes-tx-amp = <0xf 0xf 0xa>;
> - amd,serdes-dfe-tap-config = <0x3 0x3 0x1>;
> - amd,serdes-dfe-tap-enable = <0x0 0x0 0x7f>;
> - linux,phandle = <0xa>;
> - phandle = <0xa>;
> - };
> -
> - xgmac0_smmu: smmu@e0600000 {
> - compatible = "arm,mmu-401";
> - reg = <0 0xe0600000 0 0x10000>;
> - #global-interrupts = <1>;
> - interrupts = /* Uses combined intr for both
> - * global and context
> - */
> - <0 336 4>,
> - <0 336 4>;
> - #iommu-cells = <2>;
> - dma-coherent;
> - };
> -
> - xgmac1_smmu: smmu@e0800000 {
> - compatible = "arm,mmu-401";
> - reg = <0 0xe0800000 0 0x10000>;
> - #global-interrupts = <1>;
> - interrupts = /* Uses combined intr for both
> - * global and context
> - */
> - <0 335 4>,
> - <0 335 4>;
> - #iommu-cells = <2>;
> - dma-coherent;
> - };
> -
> - xgmac@e0700000 {
> - status = "disabled";
> - compatible = "amd,xgbe-seattle-v1a";
> - reg = <0x0 0xe0700000 0x0 0x80000 0x0 0xe0780000 0x0 0x80000>;
> - interrupts = <0x0 0x145 0x4>,
> - <0x0 0x15a 0x1>,
> - <0x0 0x15b 0x1>,
> - <0x0 0x15c 0x1>,
> - <0x0 0x15d 0x1>;
> - amd,per-channel-interrupt;
> - mac-address = [02 a1 a2 a3 a4 a5];
> - clocks = <0x5 0x6>;
> - clock-names = "dma_clk", "ptp_clk";
> - phy-handle = <0x9>;
> - phy-mode = "xgmii";
> - dma-coherent;
> - iommus = <&xgmac0_smmu 0x00 0x1f>; /* 0-31 */
> - linux,phandle = <0xb>;
> - phandle = <0xb>;
> - };
> -
> - xgmac@e0900000 {
> - status = "disabled";
> - compatible = "amd,xgbe-seattle-v1a";
> - reg = <0x0 0xe0900000 0x0 0x80000 0x0 0xe0980000 0x0 0x80000>;
> - interrupts = <0x0 0x144 0x4>,
> - <0x0 0x155 0x1>,
> - <0x0 0x156 0x1>,
> - <0x0 0x157 0x1>,
> - <0x0 0x158 0x1>;
> - amd,per-channel-interrupt;
> - mac-address = [02 b1 b2 b3 b4 b5];
> - clocks = <0x7 0x8>;
> - clock-names = "dma_clk", "ptp_clk";
> - phy-handle = <0xa>;
> - phy-mode = "xgmii";
> - dma-coherent;
> - iommus = <&xgmac1_smmu 0x00 0x1f>; /* 0-31 */
> - linux,phandle = <0xc>;
> - phandle = <0xc>;
> - };
> - };
> -
> - chosen {
> - stdout-path = "/smb/serial@e1010000";
> - /* Note:
> - * Linux support for pci-probe-only DT is not
> - * stable. Disable this for now and let Linux
> - * take care of the resource assignment.
> - */
> - // linux,pci-probe-only;
> - };
> -
> - psci {
> - compatible = "arm,psci-0.2", "arm,psci";
> - method = "smc";
> - };
> + model = "AMD Seattle (Rev.B) Development Board (Overdrive)";
> + compatible = "amd,seattle-overdrive", "amd,seattle";
> + interrupt-parent = <&gic>;
> + #address-cells = <0x2>;
> + #size-cells = <0x2>;
> +
> + gic: interrupt-controller@e1101000 {
> + compatible = "arm,gic-400", "arm,cortex-a15-gic";
> + interrupt-controller;
> + #interrupt-cells = <0x3>;
> + #address-cells = <0x2>;
> + #size-cells = <0x2>;
> + reg = <0x0 0xe1110000 0x0 0x1000>,
> + <0x0 0xe112f000 0x0 0x2000>,
> + <0x0 0xe1140000 0x0 0x2000>,
> + <0x0 0xe1160000 0x0 0x2000>;
> + interrupts = <GIC_PPI 0x9 (IRQ_TYPE_LEVEL_HIGH | GIC_CPU_MASK(4))>;
> + ranges = <0x0 0x0 0x0 0xe1100000 0x0 0x100000>;
> +
> + msi: v2m@e0080000 {
> + compatible = "arm,gic-v2m-frame";
> + reg = <0x0 0x80000 0x0 0x1000>;
> + msi-controller;
> + };
> + };
> +
> + timer {
> + compatible = "arm,armv8-timer";
> + interrupts = <GIC_PPI 0xd (IRQ_TYPE_LEVEL_HIGH | GIC_CPU_MASK(8))>,
> + <GIC_PPI 0xe (IRQ_TYPE_LEVEL_HIGH | GIC_CPU_MASK(8))>,
> + <GIC_PPI 0xb (IRQ_TYPE_LEVEL_HIGH | GIC_CPU_MASK(8))>,
> + <GIC_PPI 0xa (IRQ_TYPE_LEVEL_HIGH | GIC_CPU_MASK(8))>;
> + };
> +
> + smb {
> + compatible = "simple-bus";
> + #address-cells = <0x2>;
> + #size-cells = <0x2>;
> + ranges;
> + /*
> + * dma-ranges is 40-bit address space containing:
> + * - GICv2m MSI register is at 0xe0080000
> + * - DRAM range [0x8000000000 to 0xffffffffff]
> + */
> + dma-ranges = <0x0 0x0 0x0 0x0 0x100 0x0>;
> +
> + adl3clk: clk100mhz_0 {
> + compatible = "fixed-clock";
> + #clock-cells = <0x0>;
> + clock-frequency = <100000000>;
> + clock-output-names = "adl3clk_100mhz";
> + };
> +
> + ccpclk: clk375mhz {
> + compatible = "fixed-clock";
> + #clock-cells = <0x0>;
> + clock-frequency = <375000000>;
> + clock-output-names = "ccpclk_375mhz";
> + };
> +
> + sataclk: clk333mhz {
> + compatible = "fixed-clock";
> + #clock-cells = <0x0>;
> + clock-frequency = <333000000>;
> + clock-output-names = "sataclk_333mhz";
> + };
> +
> + pcieclk: clk500mhz_0 {
> + compatible = "fixed-clock";
> + #clock-cells = <0x0>;
> + clock-frequency = <500000000>;
> + clock-output-names = "pcieclk_500mhz";
> + };
> +
> + dmaclk: clk500mhz_1 {
> + compatible = "fixed-clock";
> + #clock-cells = <0x0>;
> + clock-frequency = <500000000>;
> + clock-output-names = "dmaclk_500mhz";
> + };
> +
> + miscclk: clk250mhz_4 {
> + compatible = "fixed-clock";
> + #clock-cells = <0x0>;
> + clock-frequency = <250000000>;
> + clock-output-names = "miscclk_250mhz";
> + };
> +
> + uartspiclk: clk100mhz_1 {
> + compatible = "fixed-clock";
> + #clock-cells = <0x0>;
> + clock-frequency = <100000000>;
> + clock-output-names = "uartspiclk_100mhz";
> + };
> +
> + sata0_smmu: smmu@e0200000 {
> + compatible = "arm,mmu-401";
> + reg = <0 0xe0200000 0 0x10000>;
> +
> + /* Uses combined intr for both global and context */
> + #global-interrupts = <1>;
> + interrupts = <GIC_SPI 332 IRQ_TYPE_LEVEL_HIGH>,
> + <GIC_SPI 332 IRQ_TYPE_LEVEL_HIGH>;
> + #iommu-cells = <2>;
> + dma-coherent;
> + };
> +
> + sata1_smmu: smmu@e0c00000 {
> + compatible = "arm,mmu-401";
> + reg = <0 0xe0c00000 0 0x10000>;
> +
> + /* Uses combined intr for both global and context */
> + #global-interrupts = <1>;
> + interrupts = <GIC_SPI 331 IRQ_TYPE_LEVEL_HIGH>,
> + <GIC_SPI 331 IRQ_TYPE_LEVEL_HIGH>;
> + #iommu-cells = <2>;
> + dma-coherent;
> + };
> +
> + sata@e0300000 {
> + compatible = "snps,dwc-ahci";
> + reg = <0x0 0xe0300000 0x0 0xf0000>;
> + interrupts = <GIC_SPI 0x163 IRQ_TYPE_LEVEL_HIGH>;
> + clocks = <&sataclk>;
> + dma-coherent;
> + iommus = <&sata0_smmu 0x00 0x1f>; /* 0-31 */
> + };
> +
> + sata@e0d00000 {
> + status = "disabled";
> + compatible = "snps,dwc-ahci";
> + reg = <0x0 0xe0d00000 0x0 0xf0000>;
> + interrupts = <GIC_SPI 0x162 IRQ_TYPE_LEVEL_HIGH>;
> + clocks = <&sataclk>;
> + dma-coherent;
> + iommus = <&sata1_smmu 0x00 0x1f>; /* 0-31 */
> + };
> +
> + i2c@e1000000 {
> + compatible = "snps,designware-i2c";
> + reg = <0x0 0xe1000000 0x0 0x1000>;
> + interrupts = <GIC_SPI 0x165 IRQ_TYPE_LEVEL_HIGH>;
> + clocks = <&miscclk>;
> + };
> +
> + i2c@e0050000 {
> + compatible = "snps,designware-i2c";
> + reg = <0x0 0xe0050000 0x0 0x1000>;
> + interrupts = <GIC_SPI 0x154 IRQ_TYPE_LEVEL_HIGH>;
> + clocks = <&miscclk>;
> + };
> +
> + serial@e1010000 {
> + compatible = "arm,pl011", "arm,primecell";
> + reg = <0x0 0xe1010000 0x0 0x1000>;
> + interrupts = <GIC_SPI 0x148 IRQ_TYPE_LEVEL_HIGH>;
> + clocks = <&uartspiclk &uartspiclk>;
> + clock-names = "uartclk", "apb_pclk";
> + };
> +
> + ssp@e1020000 {
> + compatible = "arm,pl022", "arm,primecell";
> + reg = <0x0 0xe1020000 0x0 0x1000>;
> + spi-controller;
> + interrupts = <GIC_SPI 0x14a IRQ_TYPE_LEVEL_HIGH>;
> + clocks = <&uartspiclk>;
> + clock-names = "apb_pclk";
> + };
> +
> + ssp@e1030000 {
> + compatible = "arm,pl022", "arm,primecell";
> + reg = <0x0 0xe1030000 0x0 0x1000>;
> + spi-controller;
> + interrupts = <GIC_SPI 0x149 IRQ_TYPE_LEVEL_HIGH>;
> + clocks = <&uartspiclk>;
> + clock-names = "apb_pclk";
> + num-cs = <0x1>;
> + #address-cells = <0x1>;
> + #size-cells = <0x0>;
> +
> + sdcard@0 {
> + compatible = "mmc-spi-slot";
> + reg = <0x0>;
> + spi-max-frequency = <20000000>;
> + voltage-ranges = <3200 3400>;
> + pl022,hierarchy = <0x0>;
> + pl022,interface = <0x0>;
> + pl022,com-mode = <0x0>;
> + pl022,rx-level-trig = <0x0>;
> + pl022,tx-level-trig = <0x0>;
> + };
> + };
> +
> + gpio@e1050000 { /* [0 : 7] */
> + compatible = "arm,pl061", "arm,primecell";
> + #gpio-cells = <0x2>;
> + reg = <0x0 0xe1050000 0x0 0x1000>;
> + gpio-controller;
> + interrupt-controller;
> + #interrupt-cells = <0x2>;
> + interrupts = <GIC_SPI 0x166 IRQ_TYPE_LEVEL_HIGH>;
> + clocks = <&uartspiclk>;
> + clock-names = "apb_pclk";
> + };
> +
> + gpio@e0020000 { /* [8 : 15] */
> + status = "disabled";
> + compatible = "arm,pl061", "arm,primecell";
> + #gpio-cells = <0x2>;
> + reg = <0x0 0xe0020000 0x0 0x1000>;
> + gpio-controller;
> + interrupt-controller;
> + #interrupt-cells = <0x2>;
> + interrupts = <GIC_SPI 0x16e IRQ_TYPE_LEVEL_HIGH>;
> + clocks = <&uartspiclk>;
> + clock-names = "apb_pclk";
> + };
> +
> + gpio@e0030000 { /* [16 : 23] */
> + status = "disabled";
> + compatible = "arm,pl061", "arm,primecell";
> + #gpio-cells = <0x2>;
> + reg = <0x0 0xe0030000 0x0 0x1000>;
> + gpio-controller;
> + interrupt-controller;
> + #interrupt-cells = <0x2>;
> + interrupts = <GIC_SPI 0x16d IRQ_TYPE_LEVEL_HIGH>;
> + clocks = <&uartspiclk>;
> + clock-names = "apb_pclk";
> + };
> +
> + gpio@e0080000 { /* [24] */
> + compatible = "arm,pl061", "arm,primecell";
> + #gpio-cells = <0x2>;
> + reg = <0x0 0xe0080000 0x0 0x1000>;
> + gpio-controller;
> + interrupt-controller;
> + #interrupt-cells = <0x2>;
> + interrupts = <GIC_SPI 0x169 IRQ_TYPE_LEVEL_HIGH>;
> + clocks = <&uartspiclk>;
> + clock-names = "apb_pclk";
> + };
> +
> + ccp: ccp@e0100000 {
> + compatible = "amd,ccp-seattle-v1a";
> + reg = <0x0 0xe0100000 0x0 0x10000>;
> + interrupts = <GIC_SPI 0x3 IRQ_TYPE_LEVEL_HIGH>;
> + dma-coherent;
> + amd,zlib-support = <0x1>;
> + };
> +
> + pcie: pcie@f0000000 {
> + compatible = "pci-host-ecam-generic";
> + #address-cells = <0x3>;
> + #size-cells = <0x2>;
> + #interrupt-cells = <0x1>;
> + iommu-map = <0x0 &pcie_smmu 0x0 0x10000>;
> + device_type = "pci";
> + bus-range = <0x0 0x7f>;
> + msi-parent = <&msi>;
> + reg = <0x0 0xf0000000 0x0 0x10000000>;
> + interrupt-map-mask = <0xff00 0x0 0x0 0x7>;
> + interrupt-map = <0x1100 0x0 0x0 0x1 &gic 0x0 0x0 GIC_SPI 0x120 IRQ_TYPE_EDGE_RISING>,
> + <0x1100 0x0 0x0 0x2 &gic 0x0 0x0 GIC_SPI 0x121 IRQ_TYPE_EDGE_RISING>,
> + <0x1100 0x0 0x0 0x3 &gic 0x0 0x0 GIC_SPI 0x122 IRQ_TYPE_EDGE_RISING>,
> + <0x1100 0x0 0x0 0x4 &gic 0x0 0x0 GIC_SPI 0x123 IRQ_TYPE_EDGE_RISING>,
> +
> + <0x1200 0x0 0x0 0x1 &gic 0x0 0x0 GIC_SPI 0x124 IRQ_TYPE_EDGE_RISING>,
> + <0x1200 0x0 0x0 0x2 &gic 0x0 0x0 GIC_SPI 0x125 IRQ_TYPE_EDGE_RISING>,
> + <0x1200 0x0 0x0 0x3 &gic 0x0 0x0 GIC_SPI 0x126 IRQ_TYPE_EDGE_RISING>,
> + <0x1200 0x0 0x0 0x4 &gic 0x0 0x0 GIC_SPI 0x127 IRQ_TYPE_EDGE_RISING>,
> +
> + <0x1300 0x0 0x0 0x1 &gic 0x0 0x0 GIC_SPI 0x128 IRQ_TYPE_EDGE_RISING>,
> + <0x1300 0x0 0x0 0x2 &gic 0x0 0x0 GIC_SPI 0x129 IRQ_TYPE_EDGE_RISING>,
> + <0x1300 0x0 0x0 0x3 &gic 0x0 0x0 GIC_SPI 0x12a IRQ_TYPE_EDGE_RISING>,
> + <0x1300 0x0 0x0 0x4 &gic 0x0 0x0 GIC_SPI 0x12b IRQ_TYPE_EDGE_RISING>;
> + dma-coherent;
> + dma-ranges = <0x43000000 0x0 0x0 0x0 0x0 0x100 0x0>;
> + ranges = <0x1000000 0x0 0x00000000 0x0 0xefff0000 0x00 0x00010000>, /* I/O Memory (size=64K) */
> + <0x2000000 0x0 0x40000000 0x0 0x40000000 0x00 0x80000000>, /* 32-bit MMIO (size=2G) */
> + <0x3000000 0x1 0x00000000 0x1 0x00000000 0x7f 0x00000000>; /* 64-bit MMIO (size= 124G) */
> + };
> +
> + pcie_smmu: smmu@e0a00000 {
> + compatible = "arm,mmu-401";
> + reg = <0 0xe0a00000 0 0x10000>;
> +
> + /* Uses combined intr for both global and context */
> + #global-interrupts = <1>;
> + interrupts = <GIC_SPI 333 IRQ_TYPE_LEVEL_HIGH>,
> + <GIC_SPI 333 IRQ_TYPE_LEVEL_HIGH>;
> + #iommu-cells = <1>;
> + dma-coherent;
> + };
> +
> + ccn@0xe8000000 {
> + compatible = "arm,ccn-504";
> + reg = <0x0 0xe8000000 0x0 0x1000000>;
> + interrupts = <GIC_SPI 0x17c IRQ_TYPE_LEVEL_HIGH>;
> + };
> +
> + gwdt@e0bb0000 {
> + status = "disabled";
> + compatible = "arm,sbsa-gwdt";
> + reg = <0x0 0xe0bb0000 0x0 0x10000
> + 0x0 0xe0bc0000 0x0 0x10000>;
> + reg-names = "refresh", "control";
> + interrupts = <GIC_SPI 0x151 IRQ_TYPE_LEVEL_HIGH>;
> + interrupt-names = "ws0";
> + };
> +
> + kcs@e0010000 {
> + status = "disabled";
> + compatible = "ipmi-kcs";
> + device_type = "ipmi";
> + reg = <0x0 0xe0010000 0 0x8>;
> + interrupts = <GIC_SPI 389 IRQ_TYPE_LEVEL_HIGH>;
> + interrupt-names = "ipmi_kcs";
> + reg-size = <1>;
> + reg-spacing = <4>;
> + };
> +
> + xgmacclk0_dma: clk250mhz_0 {
> + compatible = "fixed-clock";
> + #clock-cells = <0x0>;
> + clock-frequency = <250000000>;
> + clock-output-names = "xgmacclk0_dma_250mhz";
> + };
> +
> + xgmacclk0_ptp: clk250mhz_1 {
> + compatible = "fixed-clock";
> + #clock-cells = <0x0>;
> + clock-frequency = <250000000>;
> + clock-output-names = "xgmacclk0_ptp_250mhz";
> + };
> +
> + xgmacclk1_dma: clk250mhz_2 {
> + compatible = "fixed-clock";
> + #clock-cells = <0x0>;
> + clock-frequency = <250000000>;
> + clock-output-names = "xgmacclk1_dma_250mhz";
> + };
> +
> + xgmacclk1_ptp: clk250mhz_3 {
> + compatible = "fixed-clock";
> + #clock-cells = <0x0>;
> + clock-frequency = <250000000>;
> + clock-output-names = "xgmacclk1_ptp_250mhz";
> + };
> +
> + xgmac0_phy: phy@e1240800 {
> + compatible = "amd,xgbe-phy-seattle-v1a";
> + reg = <0x0 0xe1240800 0x0 0x0400>, /* SERDES RX/TX0 */
> + <0x0 0xe1250000 0x0 0x0060>, /* SERDES IR 1/2 */
> + <0x0 0xe12500f8 0x0 0x0004>; /* SERDES IR 2/2 */
> + interrupts = <GIC_SPI 0x143 IRQ_TYPE_LEVEL_HIGH>;
> + amd,speed-set = <0x0>;
> + amd,serdes-blwc = <0x1 0x1 0x0>;
> + amd,serdes-cdr-rate = <0x2 0x2 0x7>;
> + amd,serdes-pq-skew = <0xa 0xa 0x12>;
> + amd,serdes-tx-amp = <0xf 0xf 0xa>;
> + amd,serdes-dfe-tap-config = <0x3 0x3 0x1>;
> + amd,serdes-dfe-tap-enable = <0x0 0x0 0x7f>;
> + status = "disabled";
> + };
> +
> + xgmac1_phy: phy@e1240c00 {
> + compatible = "amd,xgbe-phy-seattle-v1a";
> + reg = <0x0 0xe1240c00 0x0 0x0400>, /* SERDES RX/TX0 */
> + <0x0 0xe1250080 0x0 0x0060>, /* SERDES IR 1/2 */
> + <0x0 0xe12500fc 0x0 0x0004>; /* SERDES IR 2/2 */
> + interrupts = <GIC_SPI 0x142 IRQ_TYPE_LEVEL_HIGH>;
> + amd,speed-set = <0x0>;
> + amd,serdes-blwc = <0x1 0x1 0x0>;
> + amd,serdes-cdr-rate = <0x2 0x2 0x7>;
> + amd,serdes-pq-skew = <0xa 0xa 0x12>;
> + amd,serdes-tx-amp = <0xf 0xf 0xa>;
> + amd,serdes-dfe-tap-config = <0x3 0x3 0x1>;
> + amd,serdes-dfe-tap-enable = <0x0 0x0 0x7f>;
> + status = "disabled";
> + };
> +
> + xgmac0_smmu: smmu@e0600000 {
> + compatible = "arm,mmu-401";
> + reg = <0 0xe0600000 0 0x10000>;
> +
> + /* Uses combined intr for both global and context */
> + #global-interrupts = <1>;
> + interrupts = <GIC_SPI 336 IRQ_TYPE_LEVEL_HIGH>,
> + <GIC_SPI 336 IRQ_TYPE_LEVEL_HIGH>;
> + #iommu-cells = <2>;
> + dma-coherent;
> + };
> +
> + xgmac1_smmu: smmu@e0800000 {
> + compatible = "arm,mmu-401";
> + reg = <0 0xe0800000 0 0x10000>;
> +
> + /* Uses combined intr for both global and context */
> + #global-interrupts = <1>;
> + interrupts = <GIC_SPI 335 IRQ_TYPE_LEVEL_HIGH>,
> + <GIC_SPI 335 IRQ_TYPE_LEVEL_HIGH>;
> + #iommu-cells = <2>;
> + dma-coherent;
> + };
> +
> + xgmac@e0700000 {
> + compatible = "amd,xgbe-seattle-v1a";
> + reg = <0x0 0xe0700000 0x0 0x80000 0x0 0xe0780000 0x0 0x80000>;
> + interrupts = <GIC_SPI 0x145 IRQ_TYPE_LEVEL_HIGH>,
> + <GIC_SPI 0x15a IRQ_TYPE_EDGE_RISING>,
> + <GIC_SPI 0x15b IRQ_TYPE_EDGE_RISING>,
> + <GIC_SPI 0x15c IRQ_TYPE_EDGE_RISING>,
> + <GIC_SPI 0x15d IRQ_TYPE_EDGE_RISING>;
> + amd,per-channel-interrupt;
> + mac-address = [02 a1 a2 a3 a4 a5];
> + clocks = <&xgmacclk0_dma &xgmacclk0_ptp>;
> + clock-names = "dma_clk", "ptp_clk";
> + phy-handle = <&xgmac0_phy>;
> + phy-mode = "xgmii";
> +
> + iommus = <&xgmac0_smmu 0x00 0x1f>; /* 0-31 */
> + dma-coherent;
> + status = "disabled";
> + };
> +
> + xgmac@e0900000 {
> + compatible = "amd,xgbe-seattle-v1a";
> + reg = <0x0 0xe0900000 0x0 0x80000 0x0 0xe0980000 0x0 0x80000>;
> + interrupts = <GIC_SPI 0x144 IRQ_TYPE_LEVEL_HIGH>,
> + <GIC_SPI 0x155 IRQ_TYPE_EDGE_RISING>,
> + <GIC_SPI 0x156 IRQ_TYPE_EDGE_RISING>,
> + <GIC_SPI 0x157 IRQ_TYPE_EDGE_RISING>,
> + <GIC_SPI 0x158 IRQ_TYPE_EDGE_RISING>;
> + amd,per-channel-interrupt;
> + mac-address = [02 b1 b2 b3 b4 b5];
> + clocks = <&xgmacclk1_dma &xgmacclk1_ptp>;
> + clock-names = "dma_clk", "ptp_clk";
> + phy-handle = <&xgmac1_phy>;
> + phy-mode = "xgmii";
> +
> + iommus = <&xgmac1_smmu 0x00 0x1f>; /* 0-31 */
> + dma-coherent;
> + status = "disabled";
> + };
> + };
> +
> + chosen {
> + stdout-path = "/smb/serial@e1010000";
> + };
> +
> + psci {
> + compatible = "arm,psci-0.2", "arm,psci";
> + method = "smc";
> + };
> };
> --
> 2.11.0
>
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH edk2-platforms v2 3/4] Platform/OverdriveBoard: fix CPU affinity for vGIC maintenace interrupt
2017-08-31 13:08 ` [PATCH edk2-platforms v2 3/4] Platform/OverdriveBoard: fix CPU affinity for vGIC maintenace interrupt Ard Biesheuvel
@ 2017-09-01 11:13 ` Leif Lindholm
0 siblings, 0 replies; 11+ messages in thread
From: Leif Lindholm @ 2017-09-01 11:13 UTC (permalink / raw)
To: Ard Biesheuvel; +Cc: edk2-devel, alan
On Thu, Aug 31, 2017 at 02:08:29PM +0100, Ard Biesheuvel wrote:
> The CPU affinity for the vGIC maintenance interrupt was set to
> CPUs #0 .. #3 for no good reason. So set it to all CPUs instead.
>
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
Reviewed-by: Leif Lindholm <leif.lindholm@linaro.org>
> ---
> Platform/AMD/OverdriveBoard/OverdriveBoardDeviceTree/OverdriveBoardDeviceTree.dts | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/Platform/AMD/OverdriveBoard/OverdriveBoardDeviceTree/OverdriveBoardDeviceTree.dts b/Platform/AMD/OverdriveBoard/OverdriveBoardDeviceTree/OverdriveBoardDeviceTree.dts
> index 81477fe43cdd..e57e702029ba 100644
> --- a/Platform/AMD/OverdriveBoard/OverdriveBoardDeviceTree/OverdriveBoardDeviceTree.dts
> +++ b/Platform/AMD/OverdriveBoard/OverdriveBoardDeviceTree/OverdriveBoardDeviceTree.dts
> @@ -45,7 +45,7 @@
> <0x0 0xe112f000 0x0 0x2000>,
> <0x0 0xe1140000 0x0 0x2000>,
> <0x0 0xe1160000 0x0 0x2000>;
> - interrupts = <GIC_PPI 0x9 (IRQ_TYPE_LEVEL_HIGH | GIC_CPU_MASK(4))>;
> + interrupts = <GIC_PPI 0x9 (IRQ_TYPE_LEVEL_HIGH | GIC_CPU_MASK(8))>;
> ranges = <0x0 0x0 0x0 0xe1100000 0x0 0x100000>;
>
> msi: v2m@e0080000 {
> --
> 2.11.0
>
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH edk2-platforms v2 4/4] Platform/OverdriveBoard: classify legacy INTx interrupts as level high
2017-08-31 13:08 ` [PATCH edk2-platforms v2 4/4] Platform/OverdriveBoard: classify legacy INTx interrupts as level high Ard Biesheuvel
@ 2017-09-01 11:14 ` Leif Lindholm
0 siblings, 0 replies; 11+ messages in thread
From: Leif Lindholm @ 2017-09-01 11:14 UTC (permalink / raw)
To: Ard Biesheuvel; +Cc: edk2-devel, alan
On Thu, Aug 31, 2017 at 02:08:30PM +0100, Ard Biesheuvel wrote:
> Fix the trigger type of the legacy INTx interrupts. The Seattle SoC manual
> classifies them as level high, not rising edge.
>
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
Reviewed-by: Leif Lindholm <leif.lindholm@linaro.org>
> ---
> Platform/AMD/OverdriveBoard/OverdriveBoardDeviceTree/OverdriveBoardDeviceTree.dts | 28 ++++++++++----------
> 1 file changed, 14 insertions(+), 14 deletions(-)
>
> diff --git a/Platform/AMD/OverdriveBoard/OverdriveBoardDeviceTree/OverdriveBoardDeviceTree.dts b/Platform/AMD/OverdriveBoard/OverdriveBoardDeviceTree/OverdriveBoardDeviceTree.dts
> index e57e702029ba..2c05fdbb8b71 100644
> --- a/Platform/AMD/OverdriveBoard/OverdriveBoardDeviceTree/OverdriveBoardDeviceTree.dts
> +++ b/Platform/AMD/OverdriveBoard/OverdriveBoardDeviceTree/OverdriveBoardDeviceTree.dts
> @@ -291,20 +291,20 @@
> msi-parent = <&msi>;
> reg = <0x0 0xf0000000 0x0 0x10000000>;
> interrupt-map-mask = <0xff00 0x0 0x0 0x7>;
> - interrupt-map = <0x1100 0x0 0x0 0x1 &gic 0x0 0x0 GIC_SPI 0x120 IRQ_TYPE_EDGE_RISING>,
> - <0x1100 0x0 0x0 0x2 &gic 0x0 0x0 GIC_SPI 0x121 IRQ_TYPE_EDGE_RISING>,
> - <0x1100 0x0 0x0 0x3 &gic 0x0 0x0 GIC_SPI 0x122 IRQ_TYPE_EDGE_RISING>,
> - <0x1100 0x0 0x0 0x4 &gic 0x0 0x0 GIC_SPI 0x123 IRQ_TYPE_EDGE_RISING>,
> -
> - <0x1200 0x0 0x0 0x1 &gic 0x0 0x0 GIC_SPI 0x124 IRQ_TYPE_EDGE_RISING>,
> - <0x1200 0x0 0x0 0x2 &gic 0x0 0x0 GIC_SPI 0x125 IRQ_TYPE_EDGE_RISING>,
> - <0x1200 0x0 0x0 0x3 &gic 0x0 0x0 GIC_SPI 0x126 IRQ_TYPE_EDGE_RISING>,
> - <0x1200 0x0 0x0 0x4 &gic 0x0 0x0 GIC_SPI 0x127 IRQ_TYPE_EDGE_RISING>,
> -
> - <0x1300 0x0 0x0 0x1 &gic 0x0 0x0 GIC_SPI 0x128 IRQ_TYPE_EDGE_RISING>,
> - <0x1300 0x0 0x0 0x2 &gic 0x0 0x0 GIC_SPI 0x129 IRQ_TYPE_EDGE_RISING>,
> - <0x1300 0x0 0x0 0x3 &gic 0x0 0x0 GIC_SPI 0x12a IRQ_TYPE_EDGE_RISING>,
> - <0x1300 0x0 0x0 0x4 &gic 0x0 0x0 GIC_SPI 0x12b IRQ_TYPE_EDGE_RISING>;
> + interrupt-map = <0x1100 0x0 0x0 0x1 &gic 0x0 0x0 GIC_SPI 0x120 IRQ_TYPE_LEVEL_HIGH>,
> + <0x1100 0x0 0x0 0x2 &gic 0x0 0x0 GIC_SPI 0x121 IRQ_TYPE_LEVEL_HIGH>,
> + <0x1100 0x0 0x0 0x3 &gic 0x0 0x0 GIC_SPI 0x122 IRQ_TYPE_LEVEL_HIGH>,
> + <0x1100 0x0 0x0 0x4 &gic 0x0 0x0 GIC_SPI 0x123 IRQ_TYPE_LEVEL_HIGH>,
> +
> + <0x1200 0x0 0x0 0x1 &gic 0x0 0x0 GIC_SPI 0x124 IRQ_TYPE_LEVEL_HIGH>,
> + <0x1200 0x0 0x0 0x2 &gic 0x0 0x0 GIC_SPI 0x125 IRQ_TYPE_LEVEL_HIGH>,
> + <0x1200 0x0 0x0 0x3 &gic 0x0 0x0 GIC_SPI 0x126 IRQ_TYPE_LEVEL_HIGH>,
> + <0x1200 0x0 0x0 0x4 &gic 0x0 0x0 GIC_SPI 0x127 IRQ_TYPE_LEVEL_HIGH>,
> +
> + <0x1300 0x0 0x0 0x1 &gic 0x0 0x0 GIC_SPI 0x128 IRQ_TYPE_LEVEL_HIGH>,
> + <0x1300 0x0 0x0 0x2 &gic 0x0 0x0 GIC_SPI 0x129 IRQ_TYPE_LEVEL_HIGH>,
> + <0x1300 0x0 0x0 0x3 &gic 0x0 0x0 GIC_SPI 0x12a IRQ_TYPE_LEVEL_HIGH>,
> + <0x1300 0x0 0x0 0x4 &gic 0x0 0x0 GIC_SPI 0x12b IRQ_TYPE_LEVEL_HIGH>;
> dma-coherent;
> dma-ranges = <0x43000000 0x0 0x0 0x0 0x0 0x100 0x0>;
> ranges = <0x1000000 0x0 0x00000000 0x0 0xefff0000 0x00 0x00010000>, /* I/O Memory (size=64K) */
> --
> 2.11.0
>
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH edk2-platforms v2 2/4] Platform/OverdriveBoard: clean up device tree source file
2017-09-01 11:12 ` Leif Lindholm
@ 2017-09-01 11:14 ` Ard Biesheuvel
2017-09-01 11:17 ` Leif Lindholm
0 siblings, 1 reply; 11+ messages in thread
From: Ard Biesheuvel @ 2017-09-01 11:14 UTC (permalink / raw)
To: Leif Lindholm; +Cc: Alan Ott, edk2-devel@lists.01.org, Grant Likely
On 1 September 2017 at 12:12, Leif Lindholm <leif.lindholm@linaro.org> wrote:
> Adding Grant,
>
> On Thu, Aug 31, 2017 at 02:08:28PM +0100, Ard Biesheuvel wrote:
>> Clean up the device tree source file, by switching to Tianocore
>> conventions for line endings and whitespace etc, and by replacing
>> open coded values with symbol constants and/or phandle references.
>
> 1: All for the getting rid of open coding.
>
> 2: As for the line endings/whitespace, I am less convinced.
>
> It is its own (and very specific) file format, it is not
> edk2-specific, and just like (GNU)Makefiles and shellscripts they
> originated in a CR-free environment.
>
Yeah, that's a good point actually. Ideally, we'd just import this
mythical, separate DT repository that is disjoint from the kernel
entirely.
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH edk2-platforms v2 2/4] Platform/OverdriveBoard: clean up device tree source file
2017-09-01 11:14 ` Ard Biesheuvel
@ 2017-09-01 11:17 ` Leif Lindholm
2017-09-01 11:20 ` Ard Biesheuvel
0 siblings, 1 reply; 11+ messages in thread
From: Leif Lindholm @ 2017-09-01 11:17 UTC (permalink / raw)
To: Ard Biesheuvel; +Cc: Alan Ott, edk2-devel@lists.01.org, Grant Likely
On Fri, Sep 01, 2017 at 12:14:53PM +0100, Ard Biesheuvel wrote:
> On 1 September 2017 at 12:12, Leif Lindholm <leif.lindholm@linaro.org> wrote:
> > Adding Grant,
> >
> > On Thu, Aug 31, 2017 at 02:08:28PM +0100, Ard Biesheuvel wrote:
> >> Clean up the device tree source file, by switching to Tianocore
> >> conventions for line endings and whitespace etc, and by replacing
> >> open coded values with symbol constants and/or phandle references.
> >
> > 1: All for the getting rid of open coding.
> >
> > 2: As for the line endings/whitespace, I am less convinced.
> >
> > It is its own (and very specific) file format, it is not
> > edk2-specific, and just like (GNU)Makefiles and shellscripts they
> > originated in a CR-free environment.
>
> Yeah, that's a good point actually. Ideally, we'd just import this
> mythical, separate DT repository that is disjoint from the kernel
> entirely.
That was the subtext, yes :)
/
Leif
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH edk2-platforms v2 2/4] Platform/OverdriveBoard: clean up device tree source file
2017-09-01 11:17 ` Leif Lindholm
@ 2017-09-01 11:20 ` Ard Biesheuvel
0 siblings, 0 replies; 11+ messages in thread
From: Ard Biesheuvel @ 2017-09-01 11:20 UTC (permalink / raw)
To: Leif Lindholm; +Cc: Alan Ott, edk2-devel@lists.01.org, Grant Likely
On 1 September 2017 at 12:17, Leif Lindholm <leif.lindholm@linaro.org> wrote:
> On Fri, Sep 01, 2017 at 12:14:53PM +0100, Ard Biesheuvel wrote:
>> On 1 September 2017 at 12:12, Leif Lindholm <leif.lindholm@linaro.org> wrote:
>> > Adding Grant,
>> >
>> > On Thu, Aug 31, 2017 at 02:08:28PM +0100, Ard Biesheuvel wrote:
>> >> Clean up the device tree source file, by switching to Tianocore
>> >> conventions for line endings and whitespace etc, and by replacing
>> >> open coded values with symbol constants and/or phandle references.
>> >
>> > 1: All for the getting rid of open coding.
>> >
>> > 2: As for the line endings/whitespace, I am less convinced.
>> >
>> > It is its own (and very specific) file format, it is not
>> > edk2-specific, and just like (GNU)Makefiles and shellscripts they
>> > originated in a CR-free environment.
>>
>> Yeah, that's a good point actually. Ideally, we'd just import this
>> mythical, separate DT repository that is disjoint from the kernel
>> entirely.
>
> That was the subtext, yes :)
>
I should note that the only other public AMD Seattle DT is in the
kernel tree, and it is slightly out of date afaik. I proposed updates
in the past, but nobody seems to care
^ permalink raw reply [flat|nested] 11+ messages in thread
end of thread, other threads:[~2017-09-01 11:17 UTC | newest]
Thread overview: 11+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-08-31 13:08 [PATCH edk2-platforms v2 0/4] Platform/OverdriveBoard: move device tree compilation into build Ard Biesheuvel
2017-08-31 13:08 ` [PATCH edk2-platforms v2 1/4] " Ard Biesheuvel
2017-08-31 13:08 ` [PATCH edk2-platforms v2 2/4] Platform/OverdriveBoard: clean up device tree source file Ard Biesheuvel
2017-09-01 11:12 ` Leif Lindholm
2017-09-01 11:14 ` Ard Biesheuvel
2017-09-01 11:17 ` Leif Lindholm
2017-09-01 11:20 ` Ard Biesheuvel
2017-08-31 13:08 ` [PATCH edk2-platforms v2 3/4] Platform/OverdriveBoard: fix CPU affinity for vGIC maintenace interrupt Ard Biesheuvel
2017-09-01 11:13 ` Leif Lindholm
2017-08-31 13:08 ` [PATCH edk2-platforms v2 4/4] Platform/OverdriveBoard: classify legacy INTx interrupts as level high Ard Biesheuvel
2017-09-01 11:14 ` Leif Lindholm
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox