From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-x230.google.com (mail-wm0-x230.google.com [IPv6:2a00:1450:400c:c09::230]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 04D7F21A143F5 for ; Fri, 1 Sep 2017 03:55:40 -0700 (PDT) Received: by mail-wm0-x230.google.com with SMTP id f127so1535031wmf.1 for ; Fri, 01 Sep 2017 03:58:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=Csl7D5hLsEHmyFcouf/8YmoBbcO4o8yflT+9NWvDVZ0=; b=dCPXcO2A5OzGhlf7dpTxr0Y1JvDC1atN/wQ//KUHZZ1pUAo1RpzDniotZYyOZufkfI p+PKVW1JORfgiWmvjCUPAzr8o0cv9S/5CHTVZVmtRETD6wwIfE0Z17TWnc/dTDTuHbXU wzJi9YAj4n49w1aMEat6+BhWOiAV275tl1jIk= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=Csl7D5hLsEHmyFcouf/8YmoBbcO4o8yflT+9NWvDVZ0=; b=KFAFOz4NqaZvqvV3nd2r+euocaIMYN3hCUSbVjTht3ceWIZq5dJ9mxswlov+pVgflh Tp7AAgLhc5QdTogdYiHp7l0LkYCRhPRIx+VbpjVH2PI41Zp4aURTb2mQC9HlaTCYkmgy 1ietf4Uq0pW51i9xW7FvbLc6tRS12DQIPtFQ87vlc0jz6Tnaeyhl409h6Xs6LTAH0PkD ULM+0mkHDNeW1f0h71LNU+EhdQJMGp5v2dchQDjFH9NHZ72/x22YWlRvLvOAplXlv5QX ObXgVIsM7CkEFu3HERyY3Z7Wo3iu6DAjTLtRBUKNa3M4CkgmyAN1mH+SZ2x0qIVRif1/ 6F2g== X-Gm-Message-State: AHPjjUj3bV7XF9mOAG6E2VpgnsiTpO9mUNeVvX71fzBPcWBJFeTaH82W 0Bu3etAQbOeQ+e8c X-Google-Smtp-Source: ADKCNb7uZyR52Dqr/HIEoXiaelAm9sCPNZnUuMgaX+Xbq2UW78YdFXhdHUlC6vOIL/yIXvBFCQqjqg== X-Received: by 10.28.187.195 with SMTP id l186mr229231wmf.174.1504263502958; Fri, 01 Sep 2017 03:58:22 -0700 (PDT) Received: from bivouac.eciton.net (bivouac.eciton.net. [2a00:1098:0:86:1000:23:0:2]) by smtp.gmail.com with ESMTPSA id i75sm1237140wri.81.2017.09.01.03.58.21 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Fri, 01 Sep 2017 03:58:22 -0700 (PDT) Date: Fri, 1 Sep 2017 11:58:20 +0100 From: Leif Lindholm To: Ard Biesheuvel Cc: edk2-devel@lists.01.org Message-ID: <20170901105820.uht6oj426riaubfu@bivouac.eciton.net> References: <20170831135128.14065-1-ard.biesheuvel@linaro.org> MIME-Version: 1.0 In-Reply-To: <20170831135128.14065-1-ard.biesheuvel@linaro.org> User-Agent: NeoMutt/20170113 (1.7.2) Subject: Re: [PATCH edk2-platforms] Platform/Hisilicon: switch to NonCoherentDmaLib X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 01 Sep 2017 10:55:40 -0000 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Thu, Aug 31, 2017 at 02:51:28PM +0100, Ard Biesheuvel wrote: > Remove the shared ArmDmaLib resolution from the shared .dsc include > file: it will be removed soon from upstream EDK2. Instead, replace > it with an explicit NonCoherentDmaLib resolution for each driver that > depends on DmaLib. This makes it more insightful which peripherals are I would suggest "insightful" -> "clear" or "obvious". Fold that in if you agree. > non cache coherent, and forces derived platforms to choose a DmaLib > resolution explicitly for newly added drivers. > > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Ard Biesheuvel Reviewed-by: Leif Lindholm > --- > Platform/Hisilicon/D02/Pv660D02.dsc | 6 +++++- > Platform/Hisilicon/D03/D03.dsc | 1 + > Platform/Hisilicon/D05/D05.dsc | 1 + > Silicon/Hisilicon/Hisilicon.dsc.inc | 1 - > 4 files changed, 7 insertions(+), 2 deletions(-) > > diff --git a/Platform/Hisilicon/D02/Pv660D02.dsc b/Platform/Hisilicon/D02/Pv660D02.dsc > index 423f7d77ff8d..1fd2b98f1552 100644 > --- a/Platform/Hisilicon/D02/Pv660D02.dsc > +++ b/Platform/Hisilicon/D02/Pv660D02.dsc > @@ -354,6 +354,7 @@ > Silicon/Hisilicon/Pv660/Drivers/PcieInitDxe/PcieInitDxe.inf > Silicon/Hisilicon/Drivers/PciHostBridgeDxe/PciHostBridgeDxe.inf { > > + DmaLib|EmbeddedPkg/Library/NonCoherentDmaLib/NonCoherentDmaLib.inf > NULL|Platform/Hisilicon/D02/Library/PlatformPciLib/PlatformPciLib.inf > } > MdeModulePkg/Bus/Pci/PciBusDxe/PciBusDxe.inf > @@ -379,7 +380,10 @@ > MdeModulePkg/Universal/Disk/PartitionDxe/PartitionDxe.inf > MdeModulePkg/Universal/Disk/UnicodeCollation/EnglishDxe/EnglishDxe.inf > > - Silicon/Hisilicon/Drivers/SasV1Dxe/SasV1Dxe.inf > + Silicon/Hisilicon/Drivers/SasV1Dxe/SasV1Dxe.inf { > + > + DmaLib|EmbeddedPkg/Library/NonCoherentDmaLib/NonCoherentDmaLib.inf > + } > MdeModulePkg/Bus/Scsi/ScsiBusDxe/ScsiBusDxe.inf > MdeModulePkg/Bus/Scsi/ScsiDiskDxe/ScsiDiskDxe.inf > Silicon/Hisilicon/Pv660/Drivers/SasInitDxe/SasV1Init.inf > diff --git a/Platform/Hisilicon/D03/D03.dsc b/Platform/Hisilicon/D03/D03.dsc > index 6363b7eeec50..afea162cc48f 100644 > --- a/Platform/Hisilicon/D03/D03.dsc > +++ b/Platform/Hisilicon/D03/D03.dsc > @@ -473,6 +473,7 @@ > Platform/Hisilicon/D03/Drivers/PciPlatform/PciPlatform.inf > Silicon/Hisilicon/Drivers/PciHostBridgeDxe/PciHostBridgeDxe.inf { > > + DmaLib|EmbeddedPkg/Library/NonCoherentDmaLib/NonCoherentDmaLib.inf > NULL|Platform/Hisilicon/D03/Library/PlatformPciLib/PlatformPciLib.inf > } > > diff --git a/Platform/Hisilicon/D05/D05.dsc b/Platform/Hisilicon/D05/D05.dsc > index 35c319757ef8..3cdb1b161bd5 100644 > --- a/Platform/Hisilicon/D05/D05.dsc > +++ b/Platform/Hisilicon/D05/D05.dsc > @@ -609,6 +609,7 @@ > Platform/Hisilicon/D03/Drivers/PciPlatform/PciPlatform.inf > Silicon/Hisilicon/Drivers/PciHostBridgeDxe/PciHostBridgeDxe.inf { > > + DmaLib|EmbeddedPkg/Library/NonCoherentDmaLib/NonCoherentDmaLib.inf > NULL|Platform/Hisilicon/D05/Library/PlatformPciLib/PlatformPciLib.inf > } > > diff --git a/Silicon/Hisilicon/Hisilicon.dsc.inc b/Silicon/Hisilicon/Hisilicon.dsc.inc > index fadd352192ee..d77f0e35431e 100644 > --- a/Silicon/Hisilicon/Hisilicon.dsc.inc > +++ b/Silicon/Hisilicon/Hisilicon.dsc.inc > @@ -56,7 +56,6 @@ > DefaultExceptionHandlerLib|ArmPkg/Library/DefaultExceptionHandlerLib/DefaultExceptionHandlerLib.inf > CpuExceptionHandlerLib|ArmPkg/Library/ArmExceptionLib/ArmExceptionLib.inf > ArmDisassemblerLib|ArmPkg/Library/ArmDisassemblerLib/ArmDisassemblerLib.inf > - DmaLib|ArmPkg/Library/ArmDmaLib/ArmDmaLib.inf > ArmGicLib|ArmPkg/Drivers/ArmGic/ArmGicLib.inf > ArmGicArchLib|ArmPkg/Library/ArmGicArchLib/ArmGicArchLib.inf > ArmPlatformStackLib|ArmPlatformPkg/Library/ArmPlatformStackLib/ArmPlatformStackLib.inf > -- > 2.11.0 >