public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: Leif Lindholm <leif.lindholm@linaro.org>
To: Ard Biesheuvel <ard.biesheuvel@linaro.org>
Cc: Alan Ott <alan@softiron.com>,
	"edk2-devel@lists.01.org" <edk2-devel@lists.01.org>,
	Grant Likely <Grant.Likely@arm.com>
Subject: Re: [PATCH edk2-platforms v2 2/4] Platform/OverdriveBoard: clean up device tree source file
Date: Fri, 1 Sep 2017 12:17:56 +0100	[thread overview]
Message-ID: <20170901111756.dizvq62ohkctljkq@bivouac.eciton.net> (raw)
In-Reply-To: <CAKv+Gu8g0STRq4Re7O-BW8Z8TmonQQ=QK5ooutV5JuLBjHPrag@mail.gmail.com>

On Fri, Sep 01, 2017 at 12:14:53PM +0100, Ard Biesheuvel wrote:
> On 1 September 2017 at 12:12, Leif Lindholm <leif.lindholm@linaro.org> wrote:
> > Adding Grant,
> >
> > On Thu, Aug 31, 2017 at 02:08:28PM +0100, Ard Biesheuvel wrote:
> >> Clean up the device tree source file, by switching to Tianocore
> >> conventions for line endings and whitespace etc, and by replacing
> >> open coded values with symbol constants and/or phandle references.
> >
> > 1: All for the getting rid of open coding.
> >
> > 2: As for the line endings/whitespace, I am less convinced.
> >
> > It is its own (and very specific) file format, it is not
> > edk2-specific, and just like (GNU)Makefiles and shellscripts they
> > originated in a CR-free environment.
> 
> Yeah, that's a good point actually. Ideally, we'd just import this
> mythical, separate DT repository that is disjoint from the kernel
> entirely.

That was the subtext, yes :)

/
    Leif


  reply	other threads:[~2017-09-01 11:15 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-08-31 13:08 [PATCH edk2-platforms v2 0/4] Platform/OverdriveBoard: move device tree compilation into build Ard Biesheuvel
2017-08-31 13:08 ` [PATCH edk2-platforms v2 1/4] " Ard Biesheuvel
2017-08-31 13:08 ` [PATCH edk2-platforms v2 2/4] Platform/OverdriveBoard: clean up device tree source file Ard Biesheuvel
2017-09-01 11:12   ` Leif Lindholm
2017-09-01 11:14     ` Ard Biesheuvel
2017-09-01 11:17       ` Leif Lindholm [this message]
2017-09-01 11:20         ` Ard Biesheuvel
2017-08-31 13:08 ` [PATCH edk2-platforms v2 3/4] Platform/OverdriveBoard: fix CPU affinity for vGIC maintenace interrupt Ard Biesheuvel
2017-09-01 11:13   ` Leif Lindholm
2017-08-31 13:08 ` [PATCH edk2-platforms v2 4/4] Platform/OverdriveBoard: classify legacy INTx interrupts as level high Ard Biesheuvel
2017-09-01 11:14   ` Leif Lindholm

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170901111756.dizvq62ohkctljkq@bivouac.eciton.net \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox