From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wr0-x231.google.com (mail-wr0-x231.google.com [IPv6:2a00:1450:400c:c0c::231]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 3937921E62BBB for ; Fri, 1 Sep 2017 04:15:16 -0700 (PDT) Received: by mail-wr0-x231.google.com with SMTP id y15so5721162wrc.2 for ; Fri, 01 Sep 2017 04:18:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=oDo+f82hLyxmDIj6S4M2MLakpxTG0wY8oeaJAB2ntSg=; b=UQDqw9t3uTDoQ0fCpZTJ1ZuPULLUugiiVnvdqIIPnxlb3IVwQeA8fxcaa4KLPj4DGL uUjRvCvwY3zMspi15u8qfDLGGH8khJEKUjAqgSUd4p7Y5Nu8bOoN7fatW1G3SWrLWTMA ehRzJCXWAFDIlar+zO+c2IKTkPYz4HFRB6zYc= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=oDo+f82hLyxmDIj6S4M2MLakpxTG0wY8oeaJAB2ntSg=; b=kMWqtAv2YmOyJjWpfLix5LFjIshowjpD2eaVm3+GrZfJhvhk2d8ZBzLTQuZmp5P/mC DYECveTGmuUQQgk3x6vYtrUcyTNX71ETwLwsfOnIogWhgiT63gyyT4PxVkm1ZQTS+FsN OrUJ6WIts04RNu/N6CxCcU5j2eLqyDyz+3+BBgwRMsjk69fotmzOdFS+3ecyTCvJ6tMr 3FP+J42do4t6HfkeTFEuLLQTySaXIHKvfuonIA+QCdc2WGcg4hWAACSoxxXxbiBCn9Ro 5RibMzCatddLQS1e+LA8pgKoBUQPmWAzM/zahp69FKNPxNZ3c9yX6+KmEduVxAmnxtx8 PUng== X-Gm-Message-State: AHPjjUjlaMxObGdnE98K5ISqbLTrVjXcf8GFB8OXxnT+ZdkLxHbvi0vJ aVZf8/TAkReAjOGtgDxfEg== X-Google-Smtp-Source: ADKCNb6uB3V6cjnpEdrzspnqzSRpDg2zYXSzZGQhesBex+O/JFbYQl3HpRdFFo5L0iwqODN/4whkfw== X-Received: by 10.223.139.156 with SMTP id o28mr1162492wra.188.1504264679273; Fri, 01 Sep 2017 04:17:59 -0700 (PDT) Received: from bivouac.eciton.net (bivouac.eciton.net. [2a00:1098:0:86:1000:23:0:2]) by smtp.gmail.com with ESMTPSA id q202sm2501067wme.42.2017.09.01.04.17.58 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Fri, 01 Sep 2017 04:17:58 -0700 (PDT) Date: Fri, 1 Sep 2017 12:17:56 +0100 From: Leif Lindholm To: Ard Biesheuvel Cc: Alan Ott , "edk2-devel@lists.01.org" , Grant Likely Message-ID: <20170901111756.dizvq62ohkctljkq@bivouac.eciton.net> References: <20170831130830.12833-1-ard.biesheuvel@linaro.org> <20170831130830.12833-3-ard.biesheuvel@linaro.org> <20170901111200.z2vr5iijgxj2hgy6@bivouac.eciton.net> MIME-Version: 1.0 In-Reply-To: User-Agent: NeoMutt/20170113 (1.7.2) Subject: Re: [PATCH edk2-platforms v2 2/4] Platform/OverdriveBoard: clean up device tree source file X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 01 Sep 2017 11:15:16 -0000 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Fri, Sep 01, 2017 at 12:14:53PM +0100, Ard Biesheuvel wrote: > On 1 September 2017 at 12:12, Leif Lindholm wrote: > > Adding Grant, > > > > On Thu, Aug 31, 2017 at 02:08:28PM +0100, Ard Biesheuvel wrote: > >> Clean up the device tree source file, by switching to Tianocore > >> conventions for line endings and whitespace etc, and by replacing > >> open coded values with symbol constants and/or phandle references. > > > > 1: All for the getting rid of open coding. > > > > 2: As for the line endings/whitespace, I am less convinced. > > > > It is its own (and very specific) file format, it is not > > edk2-specific, and just like (GNU)Makefiles and shellscripts they > > originated in a CR-free environment. > > Yeah, that's a good point actually. Ideally, we'd just import this > mythical, separate DT repository that is disjoint from the kernel > entirely. That was the subtext, yes :) / Leif