From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-x233.google.com (mail-wm0-x233.google.com [IPv6:2a00:1450:400c:c09::233]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 7D04A21EB88D1 for ; Fri, 1 Sep 2017 07:46:01 -0700 (PDT) Received: by mail-wm0-x233.google.com with SMTP id 137so1042296wmj.1 for ; Fri, 01 Sep 2017 07:48:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=Hm1d9+2+M0SccY2snjSwGwbcstpbFPfsvuDa3DEyzBo=; b=NEGo4cgO/S8n3lbju7vsnLg9/a6DKrZO52JOVIjodZMsF66Q4BucQMjBf6Wf6Lga9q 1kHs9ubLqB1M+wZaSf4qk5N55+uV4nRMRmYRZarEDHpUjTedIaQ9NPRZhuvwU7sMhaXE XKeH+5NGxECE/U234ZtnsPWodVRoFoEdmoJas= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=Hm1d9+2+M0SccY2snjSwGwbcstpbFPfsvuDa3DEyzBo=; b=McvqnZwRzCKGNXWVBC1XIpsUEHA8Rp3FmOYCHaRvhzipXfyOZxg7Y/rd64liB5ej6V yMOxr3c1kaBO8P0xNLNQsZ2VTxtW49yaNOYgIhOFd9vRJgcdCmSKenHjmnctghCph7ty rRHrJdxIsN4lCki1L/MzKQeIXB7yOCUhO7ysmPfKp3VoBx6Q4rWtUsYznlj4yH767qUG gfv10UvSCo9kkfJze9/wsfW4/U7gEzVba7hmkCc/kVWJFZZEaTimePHRiBqRsK19JxBx PYOiZQ9zSQb7LEoJjn/4ZDXEUEDoMwH3Mx03zh14kYc82q4A6mI8paGWoGSCgGJp/Rb4 eL6Q== X-Gm-Message-State: AHPjjUiHJ3rr0TyEZkz7xouDVokFihfPm6p4WCf2JrgegThu78vZvwGJ nBs5kUlmiIvhnW/B X-Google-Smtp-Source: ADKCNb72VvnVUri5Vmvmc/Pzu9WjIcEEy1SGgn2vbmBT5VIAiXdhFv1AtQqD3H87uZU445HGhgftsQ== X-Received: by 10.28.5.1 with SMTP id 1mr560695wmf.191.1504277324751; Fri, 01 Sep 2017 07:48:44 -0700 (PDT) Received: from bivouac.eciton.net (bivouac.eciton.net. [2a00:1098:0:86:1000:23:0:2]) by smtp.gmail.com with ESMTPSA id 136sm222148wmo.48.2017.09.01.07.48.43 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Fri, 01 Sep 2017 07:48:44 -0700 (PDT) Date: Fri, 1 Sep 2017 15:48:41 +0100 From: Leif Lindholm To: Marcin Wojtas Cc: edk2-devel@lists.01.org, ard.biesheuvel@linaro.org, nadavh@marvell.com, neta@marvell.com, kostap@marvell.com, jinghua@marvell.com, agraf@suse.de, jsd@semihalf.com Message-ID: <20170901144841.7z5uiooyzkycwuio@bivouac.eciton.net> References: <1504271303-1782-1-git-send-email-mw@semihalf.com> <1504271303-1782-7-git-send-email-mw@semihalf.com> MIME-Version: 1.0 In-Reply-To: <1504271303-1782-7-git-send-email-mw@semihalf.com> User-Agent: NeoMutt/20170113 (1.7.2) Subject: Re: [platforms: PATCH 06/11] Applications/SpiTool: Fix bug in error test X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 01 Sep 2017 14:46:01 -0000 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Fri, Sep 01, 2017 at 03:08:18PM +0200, Marcin Wojtas wrote: > From: Ard Biesheuvel > > Fix a misplaced closing parenthesis. > > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Ard Biesheuvel > Signed-off-by: Marcin Wojtas Reviewed-by: Leif Lindholm > --- > Platform/Marvell/Applications/SpiTool/SpiFlashCmd.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/Platform/Marvell/Applications/SpiTool/SpiFlashCmd.c b/Platform/Marvell/Applications/SpiTool/SpiFlashCmd.c > index b6dc54f..e6e1007 100644 > --- a/Platform/Marvell/Applications/SpiTool/SpiFlashCmd.c > +++ b/Platform/Marvell/Applications/SpiTool/SpiFlashCmd.c > @@ -378,7 +378,7 @@ EFI_STATUS Status; > FilePath = (CHAR16 *) FileStr; > Status = ShellIsFile (FilePath); > // When read file into flash, file doesn't have to exist > - if (EFI_ERROR(Status && !(Flag & READ_FILE))) { > + if (EFI_ERROR (Status) && !(Flag & READ_FILE)) { > Print (L"sf: Wrong FilePath parameter!\n"); > return SHELL_ABORTED; > } > -- > 1.8.3.1 >