From: evan.lloyd@arm.com
To: edk2-devel@lists.01.org
Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org>,
Leif Lindholm <leif.lindholm@linaro.org>,
Matteo Carlini <Matteo.Carlini@arm.com>,
Ryan Harkin <ryan.harkin@linaro.org>
Subject: [PATCH] Platform/ARM/VExpressPkg:Fix Pcd broken in edk2
Date: Fri, 1 Sep 2017 18:27:28 +0100 [thread overview]
Message-ID: <20170901172728.10480-1-evan.lloyd@arm.com> (raw)
From: EvanLloyd <evan.lloyd@arm.com>
A recent change in edk2:
EmbeddedPkg/EmbeddedPkg.dsc: fix build for non-ARM architectures
actually broke the build for AARCH64 architectures (well Juno, really).
The PCD moved, PcdIsp1761BaseAddress, is used by
edk2\EmbeddedPkg\Drivers\Isp1761UsbDxe\Isp1761UsbDxe.inf, which was
included by Platform/ARM/VExpressPkg/ArmVExpress.dsc.inc
This patch moves the Isp1761UsbDxe.inf to [Components.ARM] so that it
doesn't invoke the PCD for Juno.
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Evan Lloyd <evan.lloyd@arm.com>
---
Code may be examined at:
https://github.com/EvanLloyd/edk2-platforms/blob/148_fix_juno_build_v1/Platform/ARM/VExpressPkg/ArmVExpress.dsc.inc
Platform/ARM/VExpressPkg/ArmVExpress.dsc.inc | 9 ++++++---
1 file changed, 6 insertions(+), 3 deletions(-)
diff --git a/Platform/ARM/VExpressPkg/ArmVExpress.dsc.inc b/Platform/ARM/VExpressPkg/ArmVExpress.dsc.inc
index 770007d1c89300f11c130515244686db6f97c96b..f82df48a00b22967f9c9741526fc0c1b75073fa0 100644
--- a/Platform/ARM/VExpressPkg/ArmVExpress.dsc.inc
+++ b/Platform/ARM/VExpressPkg/ArmVExpress.dsc.inc
@@ -471,9 +471,6 @@ [Components.common]
EmbeddedPkg/Drivers/Lan91xDxe/Lan91xDxe.inf
!endif
- # ISP1761 USB OTG Controller
- EmbeddedPkg/Drivers/Isp1761UsbDxe/Isp1761UsbDxe.inf
-
#
# Android Fastboot
#
@@ -505,3 +502,9 @@ [Components.common]
PrintLib|MdePkg/Library/BasePrintLib/BasePrintLib.inf
BcfgCommandLib|ShellPkg/Library/UefiShellBcfgCommandLib/UefiShellBcfgCommandLib.inf
}
+
+[Components.ARM]
+
+ # ISP1761 USB OTG Controller
+ EmbeddedPkg/Drivers/Isp1761UsbDxe/Isp1761UsbDxe.inf
+
--
Guid("CE165669-3EF3-493F-B85D-6190EE5B9759")
next reply other threads:[~2017-09-01 17:24 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-01 17:27 evan.lloyd [this message]
2017-09-01 17:32 ` [PATCH] Platform/ARM/VExpressPkg:Fix Pcd broken in edk2 Jeremy Linton
2017-09-01 21:47 ` Leif Lindholm
2017-09-04 15:03 ` Evan Lloyd
2017-09-05 13:16 ` Leif Lindholm
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170901172728.10480-1-evan.lloyd@arm.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox