Re: [PATCH] Platform/ARM/VExpressPkg:Fix Pcd broken in edk2

[Leif Lindholm <leif.lindholm@linaro.org>]

On Fri, Sep 01, 2017 at 06:27:28PM +0100, evan.lloyd@arm.com wrote:
> From: EvanLloyd <evan.lloyd@arm.com>
> 
> A recent change in edk2:
>     EmbeddedPkg/EmbeddedPkg.dsc: fix build for non-ARM architectures
> actually broke the build for AARCH64 architectures (well Juno, really).
> The PCD moved, PcdIsp1761BaseAddress, is used by
> edk2\EmbeddedPkg\Drivers\Isp1761UsbDxe\Isp1761UsbDxe.inf, which was
> included by Platform/ARM/VExpressPkg/ArmVExpress.dsc.inc
> 
> This patch moves the Isp1761UsbDxe.inf to [Components.ARM] so that it
> doesn't invoke the PCD for Juno.

Err, oops.

The only explanation I can think of is that in a moment of genius I
decided that since TC2 was the only platform using the driver, that
was the only one I had to build test after the change...

> Contributed-under: TianoCore Contribution Agreement 1.0
> Signed-off-by: Evan Lloyd <evan.lloyd@arm.com>

Reviewed-by: Leif Lindholm <leif.lindholm@linaro.org>

However, would you be able to submit this under Contribution Agreement
1.1? (a reply stating so would be sufficient, I can fold it in before
pushing)

/
    Leif

> ---
> 
> Code may be examined at:
> https://github.com/EvanLloyd/edk2-platforms/blob/148_fix_juno_build_v1/Platform/ARM/VExpressPkg/ArmVExpress.dsc.inc
> 
>  Platform/ARM/VExpressPkg/ArmVExpress.dsc.inc | 9 ++++++---
>  1 file changed, 6 insertions(+), 3 deletions(-)
> 
> diff --git a/Platform/ARM/VExpressPkg/ArmVExpress.dsc.inc b/Platform/ARM/VExpressPkg/ArmVExpress.dsc.inc
> index 770007d1c89300f11c130515244686db6f97c96b..f82df48a00b22967f9c9741526fc0c1b75073fa0 100644
> --- a/Platform/ARM/VExpressPkg/ArmVExpress.dsc.inc
> +++ b/Platform/ARM/VExpressPkg/ArmVExpress.dsc.inc
> @@ -471,9 +471,6 @@ [Components.common]
>    EmbeddedPkg/Drivers/Lan91xDxe/Lan91xDxe.inf
>  !endif
>  
> -  # ISP1761 USB OTG Controller
> -  EmbeddedPkg/Drivers/Isp1761UsbDxe/Isp1761UsbDxe.inf
> -
>    #
>    # Android Fastboot
>    #
> @@ -505,3 +502,9 @@ [Components.common]
>        PrintLib|MdePkg/Library/BasePrintLib/BasePrintLib.inf
>        BcfgCommandLib|ShellPkg/Library/UefiShellBcfgCommandLib/UefiShellBcfgCommandLib.inf
>    }
> +
> +[Components.ARM]
> +
> +  # ISP1761 USB OTG Controller
> +  EmbeddedPkg/Drivers/Isp1761UsbDxe/Isp1761UsbDxe.inf
> +
> -- 
> Guid("CE165669-3EF3-493F-B85D-6190EE5B9759")
>