From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-x233.google.com (mail-wm0-x233.google.com [IPv6:2a00:1450:400c:c09::233]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id ABAF021EB88D6 for ; Fri, 1 Sep 2017 14:45:04 -0700 (PDT) Received: by mail-wm0-x233.google.com with SMTP id f127so8387158wmf.1 for ; Fri, 01 Sep 2017 14:47:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=JCl70CWRSZwzO0N3U2Dwv+G/SbGdoqwMSkGAWZAChYA=; b=Z8JWzX6T53WJ3m92reDUbikSeT5mPYd9cB3vkzP0e7gXBLz9+ODIWWL9Sa4SgZJ3fC 2FAKbAx7fmIyfZV3M94rji4whe4psCSH/WOvhIgZnDeDLcyCl16ZmuVmhTZ285ijPwHl qC3OLdP2hNspnPBU9crK7wWIXeA9t8G+qvKNU= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=JCl70CWRSZwzO0N3U2Dwv+G/SbGdoqwMSkGAWZAChYA=; b=EvOhPlLbrzWQ5bF614F+tXj9xsAOwJh0kfkV5FLPcCxroUE3lwfBLiHAmIqVFiJ45n wDKcuqZ+KI74bD8N43BjgN3wWgTL8FtoiR+pc17u9uLWeKz5q//zoS0pLCKhdxr+8zFw HiUIuTDs5QMZsos0cO7b1myaOlSg7vdUigwprbWQe4ulY3K62ocSt0y+Ugmp6TDILghr PtmuvnEkhY30I+MQvi4jWA6u6AJlA7IO6Txr52B0FY3BlSAzqeU8ns1JDfh07EeCqS0J cSOxMKShbtcvT/ACdUrqYzmgpNLxliVz9PbzlWAg69LDMBuuaHPcvYieiu2uK6tIZcgV amEQ== X-Gm-Message-State: AHPjjUgSe7HHZ2XjA4KZEf6YOWTpcY+/Bl637BCO8TQ23WHLGotsrPgW 3p2zk6M66NMRTJC4 X-Google-Smtp-Source: ADKCNb6X6oNBicxxlC1DIOMF6A+69QweWxryeqSV6yeSDxgOMF8ZxTt+3OWCQdu6aYaGqnLNQ7Cg5Q== X-Received: by 10.28.12.11 with SMTP id 11mr1382267wmm.180.1504302467856; Fri, 01 Sep 2017 14:47:47 -0700 (PDT) Received: from bivouac.eciton.net (bivouac.eciton.net. [2a00:1098:0:86:1000:23:0:2]) by smtp.gmail.com with ESMTPSA id 75sm744429wmn.2.2017.09.01.14.47.46 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Fri, 01 Sep 2017 14:47:46 -0700 (PDT) Date: Fri, 1 Sep 2017 22:47:44 +0100 From: Leif Lindholm To: evan.lloyd@arm.com Cc: edk2-devel@lists.01.org, Ard Biesheuvel , Matteo Carlini , Ryan Harkin Message-ID: <20170901214744.hg5da6se3h7kwe7g@bivouac.eciton.net> References: <20170901172728.10480-1-evan.lloyd@arm.com> MIME-Version: 1.0 In-Reply-To: <20170901172728.10480-1-evan.lloyd@arm.com> User-Agent: NeoMutt/20170113 (1.7.2) Subject: Re: [PATCH] Platform/ARM/VExpressPkg:Fix Pcd broken in edk2 X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 01 Sep 2017 21:45:05 -0000 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Fri, Sep 01, 2017 at 06:27:28PM +0100, evan.lloyd@arm.com wrote: > From: EvanLloyd > > A recent change in edk2: > EmbeddedPkg/EmbeddedPkg.dsc: fix build for non-ARM architectures > actually broke the build for AARCH64 architectures (well Juno, really). > The PCD moved, PcdIsp1761BaseAddress, is used by > edk2\EmbeddedPkg\Drivers\Isp1761UsbDxe\Isp1761UsbDxe.inf, which was > included by Platform/ARM/VExpressPkg/ArmVExpress.dsc.inc > > This patch moves the Isp1761UsbDxe.inf to [Components.ARM] so that it > doesn't invoke the PCD for Juno. Err, oops. The only explanation I can think of is that in a moment of genius I decided that since TC2 was the only platform using the driver, that was the only one I had to build test after the change... > Contributed-under: TianoCore Contribution Agreement 1.0 > Signed-off-by: Evan Lloyd Reviewed-by: Leif Lindholm However, would you be able to submit this under Contribution Agreement 1.1? (a reply stating so would be sufficient, I can fold it in before pushing) / Leif > --- > > Code may be examined at: > https://github.com/EvanLloyd/edk2-platforms/blob/148_fix_juno_build_v1/Platform/ARM/VExpressPkg/ArmVExpress.dsc.inc > > Platform/ARM/VExpressPkg/ArmVExpress.dsc.inc | 9 ++++++--- > 1 file changed, 6 insertions(+), 3 deletions(-) > > diff --git a/Platform/ARM/VExpressPkg/ArmVExpress.dsc.inc b/Platform/ARM/VExpressPkg/ArmVExpress.dsc.inc > index 770007d1c89300f11c130515244686db6f97c96b..f82df48a00b22967f9c9741526fc0c1b75073fa0 100644 > --- a/Platform/ARM/VExpressPkg/ArmVExpress.dsc.inc > +++ b/Platform/ARM/VExpressPkg/ArmVExpress.dsc.inc > @@ -471,9 +471,6 @@ [Components.common] > EmbeddedPkg/Drivers/Lan91xDxe/Lan91xDxe.inf > !endif > > - # ISP1761 USB OTG Controller > - EmbeddedPkg/Drivers/Isp1761UsbDxe/Isp1761UsbDxe.inf > - > # > # Android Fastboot > # > @@ -505,3 +502,9 @@ [Components.common] > PrintLib|MdePkg/Library/BasePrintLib/BasePrintLib.inf > BcfgCommandLib|ShellPkg/Library/UefiShellBcfgCommandLib/UefiShellBcfgCommandLib.inf > } > + > +[Components.ARM] > + > + # ISP1761 USB OTG Controller > + EmbeddedPkg/Drivers/Isp1761UsbDxe/Isp1761UsbDxe.inf > + > -- > Guid("CE165669-3EF3-493F-B85D-6190EE5B9759") >