From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wr0-x233.google.com (mail-wr0-x233.google.com [IPv6:2a00:1450:400c:c0c::233]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 6EE9B21EA35D9 for ; Tue, 5 Sep 2017 06:13:38 -0700 (PDT) Received: by mail-wr0-x233.google.com with SMTP id n33so8711769wrn.4 for ; Tue, 05 Sep 2017 06:16:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=iM2PJQ2068c58DIx2qQTUcNxBw91iFN3BUVqmPJ4piY=; b=ZAxwT4W0jijFv+6JQ3mHwZHTEGLmsuWT5VwtJr/FYpDbJXeJAIBs84crL+YDTpayuJ V+jMJbtE3OKerQ4M39vUIoroKJaBFcZh2WDE9zRtPsc0TRhDRz9O3Auc8EwOwDCFKvoa IXqlL/JaV7OxPPhkeGXVTxWZGIINHzcISsiXA= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=iM2PJQ2068c58DIx2qQTUcNxBw91iFN3BUVqmPJ4piY=; b=X1/KVNcVpUWM3PdNaKUVbQrwYjsBxBRAnQtDjOPGjpp3zIuZXhpq16Dy16gnt6wrg8 Kv/U87frbuYe1BUPWmZGNb6p9v56uKT6nPvkqW0iIIIJMJBKdfIssW4ieNsyt6JWme7i N+xgcUrp/y2hE/vf9wKhW20C4xCw51boYFDExWFqXPhnVRcdKYt9IyPNF6OjHZp8I43p bHNOCg532t2eVbgu96Y97+SZjFk4n+h5IIPdYb3uFUWyCyQiNrR3cV0000VxbqRZ5CED /mNZDtl79f31+Ky3ZQF1bgjxLGg8xZpv+skxB4eJfE+UGuMtQ6goRwqem2ZLh6Gjyrbf R2gA== X-Gm-Message-State: AHPjjUjZHOnqvVpiOV5FGLjmI+Qnd5iACF0yYUEHjpCnWlTJQ+WNP2Qy QG7wOBqJxDCAnN6P X-Google-Smtp-Source: ADKCNb688XPSwNeHA3h0+o+uzCZo4C9wfFPJKdBxl88HeklCPRJKZ5XEG2VOFCT6h5/ao4Ff69mbag== X-Received: by 10.223.133.164 with SMTP id 33mr2345146wrt.179.1504617385723; Tue, 05 Sep 2017 06:16:25 -0700 (PDT) Received: from bivouac.eciton.net (bivouac.eciton.net. [2a00:1098:0:86:1000:23:0:2]) by smtp.gmail.com with ESMTPSA id z51sm715464wrz.80.2017.09.05.06.16.24 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 05 Sep 2017 06:16:24 -0700 (PDT) Date: Tue, 5 Sep 2017 14:16:23 +0100 From: Leif Lindholm To: Evan Lloyd Cc: "edk2-devel@lists.01.org" , Ard Biesheuvel , Matteo Carlini Message-ID: <20170905131623.4ddmzxubrwwd7652@bivouac.eciton.net> References: <20170901172728.10480-1-evan.lloyd@arm.com> <20170901214744.hg5da6se3h7kwe7g@bivouac.eciton.net> MIME-Version: 1.0 In-Reply-To: User-Agent: NeoMutt/20170113 (1.7.2) Subject: Re: [PATCH] Platform/ARM/VExpressPkg:Fix Pcd broken in edk2 X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 05 Sep 2017 13:13:38 -0000 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Mon, Sep 04, 2017 at 03:03:42PM +0000, Evan Lloyd wrote: > Thanks, Leif. > > > -----Original Message----- > > From: Leif Lindholm [mailto:leif.lindholm@linaro.org] > > Sent: 01 September 2017 22:48 > > To: Evan Lloyd > > Cc: edk2-devel@lists.01.org; Ard Biesheuvel ; > > Matteo Carlini ; ryan.harkin@linaro.org > > Subject: Re: [PATCH] Platform/ARM/VExpressPkg:Fix Pcd broken in edk2 > > > > On Fri, Sep 01, 2017 at 06:27:28PM +0100, evan.lloyd@arm.com wrote: > > > From: EvanLloyd > > > > > > A recent change in edk2: > > > EmbeddedPkg/EmbeddedPkg.dsc: fix build for non-ARM architectures > > > actually broke the build for AARCH64 architectures (well Juno, really). > > > The PCD moved, PcdIsp1761BaseAddress, is used by > > > edk2\EmbeddedPkg\Drivers\Isp1761UsbDxe\Isp1761UsbDxe.inf, which > > was > > > included by Platform/ARM/VExpressPkg/ArmVExpress.dsc.inc > > > > > > This patch moves the Isp1761UsbDxe.inf to [Components.ARM] so that it > > > doesn't invoke the PCD for Juno. > > > > Err, oops. > > > > The only explanation I can think of is that in a moment of genius I decided > > that since TC2 was the only platform using the driver, that was the only one I > > had to build test after the change... > > [[Evan Lloyd]] Big of you to own up. We've all been there. Well, it's out there for everyone to see whether I own up or not :) > > > Contributed-under: TianoCore Contribution Agreement 1.0 > > > Signed-off-by: Evan Lloyd > > > > Reviewed-by: Leif Lindholm > > > > However, would you be able to submit this under Contribution Agreement > > 1.1? (a reply stating so would be sufficient, I can fold it in before > > pushing) > > [[Evan Lloyd]] > [[Evan Lloyd]] "Err, oops." Please be so good as to accept this > assurance that I intended to use Contribution Agreement 1.1. I'll > change our template today, to prevent this happening again. Thanks - folded that change in and pushed as 6b95ac45c. (After test-building _everything_.) / Leif > > > > / > > Leif > > > > > --- > > > > > > Code may be examined at: > > > https://github.com/EvanLloyd/edk2- > > platforms/blob/148_fix_juno_build_v1 > > > /Platform/ARM/VExpressPkg/ArmVExpress.dsc.inc > > > > > > Platform/ARM/VExpressPkg/ArmVExpress.dsc.inc | 9 ++++++--- > > > 1 file changed, 6 insertions(+), 3 deletions(-) > > > > > > diff --git a/Platform/ARM/VExpressPkg/ArmVExpress.dsc.inc > > > b/Platform/ARM/VExpressPkg/ArmVExpress.dsc.inc > > > index > > > > > 770007d1c89300f11c130515244686db6f97c96b..f82df48a00b22967f9c974152 > > 6fc > > > 0c1b75073fa0 100644 > > > --- a/Platform/ARM/VExpressPkg/ArmVExpress.dsc.inc > > > +++ b/Platform/ARM/VExpressPkg/ArmVExpress.dsc.inc > > > @@ -471,9 +471,6 @@ [Components.common] > > > EmbeddedPkg/Drivers/Lan91xDxe/Lan91xDxe.inf > > > !endif > > > > > > - # ISP1761 USB OTG Controller > > > - EmbeddedPkg/Drivers/Isp1761UsbDxe/Isp1761UsbDxe.inf > > > - > > > # > > > # Android Fastboot > > > # > > > @@ -505,3 +502,9 @@ [Components.common] > > > PrintLib|MdePkg/Library/BasePrintLib/BasePrintLib.inf > > > > > BcfgCommandLib|ShellPkg/Library/UefiShellBcfgCommandLib/UefiShellBcfgC > > ommandLib.inf > > > } > > > + > > > +[Components.ARM] > > > + > > > + # ISP1761 USB OTG Controller > > > + EmbeddedPkg/Drivers/Isp1761UsbDxe/Isp1761UsbDxe.inf > > > + > > > -- > > > Guid("CE165669-3EF3-493F-B85D-6190EE5B9759") > > > > IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium. Thank you.