From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-x230.google.com (mail-wm0-x230.google.com [IPv6:2a00:1450:400c:c09::230]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id CC27B21E977F8 for ; Tue, 5 Sep 2017 11:00:20 -0700 (PDT) Received: by mail-wm0-x230.google.com with SMTP id 137so23703108wmj.1 for ; Tue, 05 Sep 2017 11:03:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to :user-agent; bh=1ZJ/21x3gz5VUrBUjEBsKNyY7b3CziA2jnNgZDWX29U=; b=RyzDYozDQ1974heNUvmyL+evm4e7bUT3GvX+A9N+IEUlQKmMYl8pEjFYiLP7E9ZCDt V86qOVHfTETsa8NB19o4J1t2Og4rpRgtit+LyUYgGe+KC1C3bZLj9Md5u1VHhNcEZLdK HyxmGAvhTC7mEhu18fz15f2JoUSdGBeMBd1Jc= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to:user-agent; bh=1ZJ/21x3gz5VUrBUjEBsKNyY7b3CziA2jnNgZDWX29U=; b=gkvPU6kZwcwUhQlmMjDivSSKAdly1ZJtlCRaiiWdGTDylDMC55jH7ho77FpRceWVJd pbB2gECT1WVoKeWgnd0i1ISgg4JFVCHRZxq4DY+bfs46Qy2Hn5mhL1TlUi1n7N8MZZmD K7UMtfX1aBTRIH1HU9xw0o4Y91p21L9BrxQnq6sGhN6PgThzmzsJAViZSaIkHOaEJtJ1 aQPqpduS6v3kTkAba7Xij1kZMPKmmEEoecEFW9a1ucQpMS3ENhewCrzQH4Mxm8xV03y2 sOcCP5HmK6OlaV8jgUPLmnOX2tz73hLqZPtvGYNfpOmm/RCvuupoLGIKYBeDT6ux0Py/ 6s7A== X-Gm-Message-State: AHPjjUjkgDv7hLSQuuKxwvTJKuZ6TL64S0eA7OhTXVLwp2oouRxbI4Ho BE5lisoR/xJHa4Wd X-Google-Smtp-Source: ADKCNb7QBK3sBnW7+hfRMY1I/VSxqI7rA+z9kPlPVQst0uM3Lv1QGlOV5eBfIMfARcF5nP49wJqijQ== X-Received: by 10.28.207.65 with SMTP id f62mr2830289wmg.107.1504634588496; Tue, 05 Sep 2017 11:03:08 -0700 (PDT) Received: from bivouac.eciton.net (bivouac.eciton.net. [2a00:1098:0:86:1000:23:0:2]) by smtp.gmail.com with ESMTPSA id b196sm942134wmd.43.2017.09.05.11.03.07 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 05 Sep 2017 11:03:07 -0700 (PDT) Date: Tue, 5 Sep 2017 19:03:06 +0100 From: Leif Lindholm To: Jordan Justen Cc: Ge Song , Laszlo Ersek , edk2-devel@lists.01.org, Ard Biesheuvel , "Kinney, Michael D" , Andrew Fish Message-ID: <20170905180306.53vfwarlt7tjbtlo@bivouac.eciton.net> References: <20170903021214.11516-1-ge.song@hxt-semitech.com> <20170903021214.11516-2-ge.song@hxt-semitech.com> <150453207055.10722.7097788282280420028@jljusten-skl> <7db5728c-a901-012e-0584-99c4b10d988e@gmail.com> <711fe92e-7b15-e349-b853-65b07315053e@redhat.com> <150463355735.10253.17993674709751476963@jljusten-skl.jf.intel.com> MIME-Version: 1.0 In-Reply-To: <150463355735.10253.17993674709751476963@jljusten-skl.jf.intel.com> User-Agent: NeoMutt/20170113 (1.7.2) Subject: Re: [PATCH v1 1/1] OvmfPkg/SecMain: Fix stack switching to permanent memory fail X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 05 Sep 2017 18:00:21 -0000 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit On Tue, Sep 05, 2017 at 10:45:57AM -0700, Jordan Justen wrote: > On 2017-09-04 14:25:48, Laszlo Ersek wrote: > > On 09/04/17 17:11, Ge Song wrote: > > > On 09/04/2017 09:34 PM, Jordan Justen wrote: > > > > > >> On 2017-09-03 16:55:36, Laszlo Ersek wrote: > > >>> On 09/03/17 04:12, Ge Song wrote: > > >>>> In earlier PEI stage, temporary memory(Cache As Ram) is employed as > > >>>> stack > > >>>> and heap. We move them to the new room and do some relocation fixup > > >>>> when > > >>>> permanent memory becomes available. TemporaryRamMigration() > > >>>> is responsible for switching the stack. > > >>> [...] > > >>> > > >>>> Cc: Jordan Justen > > >>>> Cc: Laszlo Ersek > > >>>> Cc: Ard Biesheuvel > > >>>> Contributed-under: TianoCore Contribution Agreement 1.1 > > >>>> Signed-off-by: Ge Song > > >>>> --- > > >>>>   OvmfPkg/Sec/SecMain.c | 2 ++ > > >>>>   1 file changed, 2 insertions(+) > > >>> (No more separate emails, I promise.) > > >>> > > >>> Before you send v2, can you please amend the patch like this: > > >>> > > >>>    git commit --amend --author='Ge Song ' > > >>> > > >>> It's OK if you mail it out from another email address, but IMO the git > > >>> authorship should match the first Signed-off-by. > > >> I disagree with this. Unless the individual is well known to the EDK > > >> II community as the owner of both email addresses, I think the author > > >> needs to send it from their author email. > > >> > > >> I suppose they can send it from another email, and then reply from > > >> their other email saying they contributed it under the Tianocore > > >> Contribution Agreement, but that sounds like a stretch... > > > > I'm fine either way, as long as we can establish some kind of agreement > > between (two of?) the three email addresses (sender, git author, S-o-b). > > We've generally said they need to match. If it is a one-time > contribution, then I think it is acceptable for the contributor to > reply to the patch from the author's email saying: "This is me. I > contributed it under the Tiancore Contribution Agreement" > > I think any change from this policy should be decided by the stewards. > > Regarding Ge Song's contribution, I think things are now even more > complicated. It sounds like the contribution is being made by > ge.song@hxt-semitech.com, but due to "IT issues" v2 is now being > authored/sent from songgebird@gmail.com. > > Does hxt-semitech.com agree to this contribution? I think given that > we know ge.song@hxt-semitech.com is the intended author, the patch > should have ge.song@hxt-semitech.com as the author with > ge.song@hxt-semitech.com in the Signed-off-by. > > Ideally it should be sent from ge.song@hxt-semitech.com, but if that > is not possible, then ge.song@hxt-semitech.com should reply to the > patch sent by songgebird@gmail.com re-iterating the > Signed-off-by/Contributed-under is from ge.song@hxt-semitech.com. > > Ge Song, Can you send a v3 with the author reset to > ge.song@hxt-semitech.com (see lersek's git commit command above) and > the Signed-off-by using ge.song@hxt-semitech.com, and then reply to > the patch posting from ge.song@hxt-semitech.com to re-iterate the > Signed-off-by and Contributed-under? While obviously not an ideal situation, it is not the first time I have come across this sort of issue. (And I doubt it will be the last.) Your suggestion sounds like a good workaround. For a series, a reply to the cover-letter should be sufficient. > > > OK, I'll try to send it from the same email address next time, the reason > > > that using two different mail addresses is because the author email is an > > > exchange account and it's hard to find the mail server preferences for > > > git-send-email... > > Sorry for the hassle, but maybe if you are able to work with your IT > department to setup git send-email then you'll be able to contribute > to other open source project's easier from your > ge.song@hxt-semitech.com email address. In my experience, getting IT departments on board with this sort of thing can be very difficult. Clearly, it should be attempted. Since hxt-semtech.com is a Linaro member, I will try to raise the importance of getting this situation resolved internally. / Leif