From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wr0-x231.google.com (mail-wr0-x231.google.com [IPv6:2a00:1450:400c:c0c::231]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id E55C020958BFF for ; Wed, 6 Sep 2017 09:34:19 -0700 (PDT) Received: by mail-wr0-x231.google.com with SMTP id o42so4414207wrb.3 for ; Wed, 06 Sep 2017 09:37:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=TiEa6UbCORg7kDv5LvRKmlP7hB+YvVClf2VVbyXjjbc=; b=hchWMWKK8jrQ284H92r0bV13a2S8eJ4rwNI044BCKFSA3Vio+kO/UBD1Oy5D7l4eQm bzNUO1JXQT1+Of6aPaMbl7G80Ybw12Ih9yrAoTtNaKglbmz0IXz2YjssdrPZTduOnZ/J LLqLJlLoOGvxSYMs0kA2rYZ05DaiuOEkcYcAA= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=TiEa6UbCORg7kDv5LvRKmlP7hB+YvVClf2VVbyXjjbc=; b=mlBKn7JvJmr38PSQnkI38XGD+hUha2DCB8Xy+8Na7BLJVPqeJ2v8f3nzq/esIS0JBw 89yzIX+MuCGbveEoPOLmNwmD2u8uFRfH5Xl3GZhLeJZhIapjVApdRvAJUP3BX8WhdbCP QQpNeGLTP6xwfUvKFgOFnNMu3zXiVa6YspaHhwH8CvGo7Nip86DC7X1rZ9WN26D68dLd BI5y4US4eR+FzCcng/LGjlhi2f7nnzaFGGUuon/yXGMj7ISZgLYxuVojpuP6Nw5a7YeX tvniNB/OiPxAJFUZIs4MwuOHMNixWgLgZUUvR3xUPqRJtHZzM+EASc9p6UR9jviBgxPR ehcg== X-Gm-Message-State: AHPjjUjO9PGpH7iLAkjjT28SvbEZeNr+UpSeLja0248ohWvDcWYTUpsu 8U+KljsbAugSlcjy X-Google-Smtp-Source: ADKCNb6cyoVX1hPHZIg8jmjl68ghM0VdvPNqM/swgM0/CwdUOqFfGMAb6MYTTHzx2UB+F3okdF4eRg== X-Received: by 10.223.167.66 with SMTP id e2mr1994078wrd.169.1504715828684; Wed, 06 Sep 2017 09:37:08 -0700 (PDT) Received: from bivouac.eciton.net (bivouac.eciton.net. [2a00:1098:0:86:1000:23:0:2]) by smtp.gmail.com with ESMTPSA id g20sm1661179wmc.12.2017.09.06.09.37.07 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 06 Sep 2017 09:37:07 -0700 (PDT) Date: Wed, 6 Sep 2017 17:37:05 +0100 From: Leif Lindholm To: Meenakshi Aggarwal Cc: edk2-devel@lists.01.org, jun.nie@linaro.org, haojian.zhuang@linaro.org Message-ID: <20170906163705.xhjg7keq63flfsvm@bivouac.eciton.net> References: <1504695310-25426-1-git-send-email-meenakshi.aggarwal@nxp.com> MIME-Version: 1.0 In-Reply-To: <1504695310-25426-1-git-send-email-meenakshi.aggarwal@nxp.com> User-Agent: NeoMutt/20170113 (1.7.2) Subject: Re: [PATCH v2 1/2] MMC : Added missing __FUNCTION__ macro. X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 06 Sep 2017 16:34:20 -0000 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Wed, Sep 06, 2017 at 04:25:09PM +0530, Meenakshi Aggarwal wrote: > We want to print name of the function resulted in error, > but __FUNCTION__ macro was missing. > > Contributed-under: TianoCore Contribution Agreement 1.0 > Signed-off-by: Meenakshi Aggarwal BaseTools/Scripts/PatchCheck.py gives a number of warnings on this patch: * EFI_D_ERROR was used, but DEBUG_ERROR is now recommended Can you please address and respin. (I could do that myself, but that now causes issues with 2/2, and that's more invasive than I like to be when committing a patch.) Otherwise good to go (and 2/2 is much more reviewable now). / Leif > --- > EmbeddedPkg/Universal/MmcDxe/MmcIdentification.c | 14 +++++++------- > 1 file changed, 7 insertions(+), 7 deletions(-) > > diff --git a/EmbeddedPkg/Universal/MmcDxe/MmcIdentification.c b/EmbeddedPkg/Universal/MmcDxe/MmcIdentification.c > index 7f74c54..8010dea 100644 > --- a/EmbeddedPkg/Universal/MmcDxe/MmcIdentification.c > +++ b/EmbeddedPkg/Universal/MmcDxe/MmcIdentification.c > @@ -388,12 +388,12 @@ InitializeSdMmcDevice ( > > Status = MmcHost->SendCommand (MmcHost, MMC_CMD55, CmdArg); > if (EFI_ERROR (Status)) { > - DEBUG ((EFI_D_ERROR, "%a(MMC_CMD55): Error and Status = %r\n", Status)); > + DEBUG ((EFI_D_ERROR, "%a (MMC_CMD55): Error and Status = %r\n", __FUNCTION__, Status)); > return Status; > } > Status = MmcHost->ReceiveResponse (MmcHost, MMC_RESPONSE_TYPE_R1, Response); > if (EFI_ERROR (Status)) { > - DEBUG ((EFI_D_ERROR, "%a(MMC_CMD55): Error and Status = %r\n", Status)); > + DEBUG ((EFI_D_ERROR, "%a (MMC_CMD55): Error and Status = %r\n", __FUNCTION__, Status)); > return Status; > } > if ((Response[0] & MMC_STATUS_APP_CMD) == 0) { > @@ -445,12 +445,12 @@ InitializeSdMmcDevice ( > CmdArg |= 1 << (0 * 4); > Status = MmcHost->SendCommand (MmcHost, MMC_CMD6, CmdArg); > if (EFI_ERROR (Status)) { > - DEBUG ((EFI_D_ERROR, "%a(MMC_CMD6): Error and Status = %r\n", Status)); > + DEBUG ((EFI_D_ERROR, "%a (MMC_CMD6): Error and Status = %r\n", __FUNCTION__, Status)); > return Status; > } else { > Status = MmcHost->ReadBlockData (MmcHost, 0, 64, Buffer); > if (EFI_ERROR (Status)) { > - DEBUG ((EFI_D_ERROR, "%a(MMC_CMD6): ReadBlockData Error and Status = %r\n", Status)); > + DEBUG ((EFI_D_ERROR, "%a (MMC_CMD6): ReadBlockData Error and Status = %r\n", __FUNCTION__, Status)); > return Status; > } > } > @@ -459,20 +459,20 @@ InitializeSdMmcDevice ( > CmdArg = MmcHostInstance->CardInfo.RCA << 16; > Status = MmcHost->SendCommand (MmcHost, MMC_CMD55, CmdArg); > if (EFI_ERROR (Status)) { > - DEBUG ((EFI_D_ERROR, "%a(MMC_CMD55): Error and Status = %r\n", Status)); > + DEBUG ((EFI_D_ERROR, "%a (MMC_CMD55): Error and Status = %r\n", __FUNCTION__, Status)); > return Status; > } > /* Width: 4 */ > Status = MmcHost->SendCommand (MmcHost, MMC_CMD6, 2); > if (EFI_ERROR (Status)) { > - DEBUG ((EFI_D_ERROR, "%a(MMC_CMD6): Error and Status = %r\n", Status)); > + DEBUG ((EFI_D_ERROR, "%a (MMC_CMD6): Error and Status = %r\n", __FUNCTION__, Status)); > return Status; > } > } > if (MMC_HOST_HAS_SETIOS(MmcHost)) { > Status = MmcHost->SetIos (MmcHost, 26 * 1000 * 1000, 4, EMMCBACKWARD); > if (EFI_ERROR (Status)) { > - DEBUG ((EFI_D_ERROR, "%a(SetIos): Error and Status = %r\n", Status)); > + DEBUG ((EFI_D_ERROR, "%a (SetIos): Error and Status = %r\n", __FUNCTION__, Status)); > return Status; > } > } > -- > 1.9.1 >