From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wr0-x231.google.com (mail-wr0-x231.google.com [IPv6:2a00:1450:400c:c0c::231]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 0F32021CEB0E2 for ; Thu, 7 Sep 2017 07:33:53 -0700 (PDT) Received: by mail-wr0-x231.google.com with SMTP id o42so9350905wrb.3 for ; Thu, 07 Sep 2017 07:36:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=By3+SgAVR8Z0u5HfrpyH7cBpMrzWJl6+z9OrMy5J3Dw=; b=SWBvw00RNG4i5RhsFLOAqxjMi2zUx4CMWgtMTq4/xIbX6EO0YCO160thEiux1wTrBT RDywbqu/sLD5hWOhd2Qaiselxuq+LM5u29GaOrgWhGCbhGTE2U4gjwICgDFN0tURu2iy 6peYTOZIqmevMJo/0HKiFhAYMYcPn6FuHIgYU= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=By3+SgAVR8Z0u5HfrpyH7cBpMrzWJl6+z9OrMy5J3Dw=; b=RgNm7PYwYAxfc9LhIKod7IXcFG8eZ/bnq5ea4yjvF5kdyuAMLKf1YD8LCyOUwmPJUs /O6WaenGZsgezP46NPNxUf+r6Gq2/2nbK6bqDKigUn6ltl/Od84Zzi/R/D03v0Fe3fOE HnnneNMeZVesDePoNQX+fwOqQMOciUJ1Gij6qvWMoSnfBmJmwgTqjjxFjophYZaTAEs9 M6dZ7jXKH/xivUE8VAPHXCMa6Lk+etjCgwAW+l6gSZi8N+ngNgbI1O2VNWoomzxT7o69 J3C9z481ezDWVS29222prq4wJOKNIhJZkpPSkj5rx7y20u0RPTmzrhOrRTGek/zhXACZ U0Qw== X-Gm-Message-State: AHPjjUi8uMGF/NGIQJHW2Ao27IFfElArnlE577i4XYPhZ4DtuDzXJjET /f68hN2Rb0sQUh1M X-Google-Smtp-Source: ADKCNb5HOKYCwepWoI9b/Nz2rSGlaBMJH2JKlUwu97XIH3qd1c4I8pQqQlFxD7uau59mqvxUzAnkQQ== X-Received: by 10.223.142.172 with SMTP id q41mr2453424wrb.106.1504795003030; Thu, 07 Sep 2017 07:36:43 -0700 (PDT) Received: from bivouac.eciton.net (bivouac.eciton.net. [2a00:1098:0:86:1000:23:0:2]) by smtp.gmail.com with ESMTPSA id 56sm2588385wrx.2.2017.09.07.07.36.42 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 07 Sep 2017 07:36:42 -0700 (PDT) Date: Thu, 7 Sep 2017 15:36:40 +0100 From: Leif Lindholm To: Meenakshi Aggarwal Cc: jun.nie@linaro.org, haojian.zhuang@linaro.org, edk2-devel@lists.01.org Message-ID: <20170907143640.skmrf57m62iq5sti@bivouac.eciton.net> References: <1504793873-13078-1-git-send-email-meenakshi.aggarwal@nxp.com> MIME-Version: 1.0 In-Reply-To: <1504793873-13078-1-git-send-email-meenakshi.aggarwal@nxp.com> User-Agent: NeoMutt/20170113 (1.7.2) Subject: Re: [PATCH v3 1/2] MMC : Added missing __FUNCTION__ macro. X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 07 Sep 2017 14:33:53 -0000 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Thu, Sep 07, 2017 at 07:47:52PM +0530, Meenakshi Aggarwal wrote: > We want to print name of the function resulted in error, > but __FUNCTION__ macro was missing. > > Contributed-under: TianoCore Contribution Agreement 1.0 > Signed-off-by: Meenakshi Aggarwal Like for 2/2, you appear to have left out edk2-devel@lists.01.org in this submission (added). Like for 2/2, happy to push this if you can confirm you are contributing under TianoCore Contribution Agreement 1.1. / Leif > --- > EmbeddedPkg/Universal/MmcDxe/MmcIdentification.c | 14 +++++++------- > 1 file changed, 7 insertions(+), 7 deletions(-) > > diff --git a/EmbeddedPkg/Universal/MmcDxe/MmcIdentification.c b/EmbeddedPkg/Universal/MmcDxe/MmcIdentification.c > index 7f74c54..27e4444 100644 > --- a/EmbeddedPkg/Universal/MmcDxe/MmcIdentification.c > +++ b/EmbeddedPkg/Universal/MmcDxe/MmcIdentification.c > @@ -388,12 +388,12 @@ InitializeSdMmcDevice ( > > Status = MmcHost->SendCommand (MmcHost, MMC_CMD55, CmdArg); > if (EFI_ERROR (Status)) { > - DEBUG ((EFI_D_ERROR, "%a(MMC_CMD55): Error and Status = %r\n", Status)); > + DEBUG ((DEBUG_ERROR, "%a (MMC_CMD55): Error and Status = %r\n", __FUNCTION__, Status)); > return Status; > } > Status = MmcHost->ReceiveResponse (MmcHost, MMC_RESPONSE_TYPE_R1, Response); > if (EFI_ERROR (Status)) { > - DEBUG ((EFI_D_ERROR, "%a(MMC_CMD55): Error and Status = %r\n", Status)); > + DEBUG ((DEBUG_ERROR, "%a (MMC_CMD55): Error and Status = %r\n", __FUNCTION__, Status)); > return Status; > } > if ((Response[0] & MMC_STATUS_APP_CMD) == 0) { > @@ -445,12 +445,12 @@ InitializeSdMmcDevice ( > CmdArg |= 1 << (0 * 4); > Status = MmcHost->SendCommand (MmcHost, MMC_CMD6, CmdArg); > if (EFI_ERROR (Status)) { > - DEBUG ((EFI_D_ERROR, "%a(MMC_CMD6): Error and Status = %r\n", Status)); > + DEBUG ((DEBUG_ERROR, "%a (MMC_CMD6): Error and Status = %r\n", __FUNCTION__, Status)); > return Status; > } else { > Status = MmcHost->ReadBlockData (MmcHost, 0, 64, Buffer); > if (EFI_ERROR (Status)) { > - DEBUG ((EFI_D_ERROR, "%a(MMC_CMD6): ReadBlockData Error and Status = %r\n", Status)); > + DEBUG ((DEBUG_ERROR, "%a (MMC_CMD6): ReadBlockData Error and Status = %r\n", __FUNCTION__, Status)); > return Status; > } > } > @@ -459,20 +459,20 @@ InitializeSdMmcDevice ( > CmdArg = MmcHostInstance->CardInfo.RCA << 16; > Status = MmcHost->SendCommand (MmcHost, MMC_CMD55, CmdArg); > if (EFI_ERROR (Status)) { > - DEBUG ((EFI_D_ERROR, "%a(MMC_CMD55): Error and Status = %r\n", Status)); > + DEBUG ((DEBUG_ERROR, "%a (MMC_CMD55): Error and Status = %r\n", __FUNCTION__, Status)); > return Status; > } > /* Width: 4 */ > Status = MmcHost->SendCommand (MmcHost, MMC_CMD6, 2); > if (EFI_ERROR (Status)) { > - DEBUG ((EFI_D_ERROR, "%a(MMC_CMD6): Error and Status = %r\n", Status)); > + DEBUG ((DEBUG_ERROR, "%a (MMC_CMD6): Error and Status = %r\n", __FUNCTION__, Status)); > return Status; > } > } > if (MMC_HOST_HAS_SETIOS(MmcHost)) { > Status = MmcHost->SetIos (MmcHost, 26 * 1000 * 1000, 4, EMMCBACKWARD); > if (EFI_ERROR (Status)) { > - DEBUG ((EFI_D_ERROR, "%a(SetIos): Error and Status = %r\n", Status)); > + DEBUG ((DEBUG_ERROR, "%a (SetIos): Error and Status = %r\n", __FUNCTION__, Status)); > return Status; > } > } > -- > 1.9.1 >