From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wr0-x22f.google.com (mail-wr0-x22f.google.com [IPv6:2a00:1450:400c:c0c::22f]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 2257E21CEB0FD for ; Thu, 7 Sep 2017 09:36:24 -0700 (PDT) Received: by mail-wr0-x22f.google.com with SMTP id v109so496276wrc.1 for ; Thu, 07 Sep 2017 09:39:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=bArArmR6PmaqfySQ5yF2ms+4HMs99RguQTXlGrjgcMw=; b=N+0LcEgKSuwpIGjkz6UyfVrGk1P3fCZl/8znWPxpZrHceIt5bp2yKtSM68ey8Y2/y/ 9HMt6STPb2Lm/81JSKDJgX5Ff1OpBSFvTPYSmLynfnJH5nkKU6Qzpw3NsiHgmISOhm72 /9wX/W32SoiEhLLOg8hDJf7dngh9enQKb/k7Y= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=bArArmR6PmaqfySQ5yF2ms+4HMs99RguQTXlGrjgcMw=; b=Cq5/u6iv8mH+qDP5rUfPXXcW90/JzW4T+yuKJbaUDn2zpEw2iEwOVFjmzZAbyqpuow f0lER3ga302F+dvg/vTn/8X4Vdp8RRCReaAAqTTJKrYs1rJN21hvNgYj87XhB+ne1iYE D6JKoaAja33df3piowhzfalsxJ3fsVl84R0ktG2PhNO/JvNikC25pHD4ON7gvDcINPkx ry8tl1P/CZT/K+s6d/wbpfAq7+/m3klXWooF6j5ZVYy4A56azcXZhpoMHUywd4+r57z1 l2F7qNwa30HvIwtOYMWQOTmUZw7sRwsfWf0pCubysOfaOnqt9JIvIknKyGMIew9yOnoB bzFw== X-Gm-Message-State: AHPjjUjbaloh0UKSQNHiJZg57CWJO++r/hE1I9hVefTb5xViSjPAXgA6 nSxVbmgG7ynW0lvRdW3c+A== X-Google-Smtp-Source: ADKCNb5fDSsPSKwxFp3NI5Fp75Ec0HaDvanK4V9y3Ty+7CrZaMsAL1DKG5v5el1vzNGX1IzcLBixDg== X-Received: by 10.223.187.5 with SMTP id r5mr2333782wrg.73.1504802353751; Thu, 07 Sep 2017 09:39:13 -0700 (PDT) Received: from bivouac.eciton.net (bivouac.eciton.net. [2a00:1098:0:86:1000:23:0:2]) by smtp.gmail.com with ESMTPSA id s126sm43149wmd.46.2017.09.07.09.39.12 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 07 Sep 2017 09:39:12 -0700 (PDT) Date: Thu, 7 Sep 2017 17:39:11 +0100 From: Leif Lindholm To: Meenakshi Aggarwal Cc: "jun.nie@linaro.org" , "haojian.zhuang@linaro.org" , "edk2-devel@lists.01.org" Message-ID: <20170907163911.jyojs7vmaop56k6p@bivouac.eciton.net> References: <1504793873-13078-1-git-send-email-meenakshi.aggarwal@nxp.com> <20170907143640.skmrf57m62iq5sti@bivouac.eciton.net> MIME-Version: 1.0 In-Reply-To: User-Agent: NeoMutt/20170113 (1.7.2) Subject: Re: [PATCH v3 1/2] MMC : Added missing __FUNCTION__ macro. X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 07 Sep 2017 16:36:24 -0000 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Thanks! For the series: Reviewed-by: Leif Lindholm Pushed as c50596a701..ea21f1d98d / Leif On Thu, Sep 07, 2017 at 03:19:34PM +0000, Meenakshi Aggarwal wrote: > Hi Leif, > > Yes, I agree to contribute under TianoCore Contribution Agreement 1.1 > > Thanks, > Meenakshi > > > -----Original Message----- > > From: Leif Lindholm [mailto:leif.lindholm@linaro.org] > > Sent: Thursday, September 07, 2017 8:07 PM > > To: Meenakshi Aggarwal > > Cc: jun.nie@linaro.org; haojian.zhuang@linaro.org; edk2-devel@lists.01.org > > Subject: Re: [PATCH v3 1/2] MMC : Added missing __FUNCTION__ macro. > > > > On Thu, Sep 07, 2017 at 07:47:52PM +0530, Meenakshi Aggarwal wrote: > > > We want to print name of the function resulted in error, but > > > __FUNCTION__ macro was missing. > > > > > > Contributed-under: TianoCore Contribution Agreement 1.0 > > > Signed-off-by: Meenakshi Aggarwal > > > > Like for 2/2, you appear to have left out edk2-devel@lists.01.org in this > > submission (added). > > > > Like for 2/2, happy to push this if you can confirm you are contributing under > > TianoCore Contribution Agreement 1.1. > > > > / > > Leif > > > > > --- > > > EmbeddedPkg/Universal/MmcDxe/MmcIdentification.c | 14 +++++++----- > > -- > > > 1 file changed, 7 insertions(+), 7 deletions(-) > > > > > > diff --git a/EmbeddedPkg/Universal/MmcDxe/MmcIdentification.c > > > b/EmbeddedPkg/Universal/MmcDxe/MmcIdentification.c > > > index 7f74c54..27e4444 100644 > > > --- a/EmbeddedPkg/Universal/MmcDxe/MmcIdentification.c > > > +++ b/EmbeddedPkg/Universal/MmcDxe/MmcIdentification.c > > > @@ -388,12 +388,12 @@ InitializeSdMmcDevice ( > > > > > > Status = MmcHost->SendCommand (MmcHost, MMC_CMD55, CmdArg); > > > if (EFI_ERROR (Status)) { > > > - DEBUG ((EFI_D_ERROR, "%a(MMC_CMD55): Error and Status = %r\n", > > Status)); > > > + DEBUG ((DEBUG_ERROR, "%a (MMC_CMD55): Error and Status = %r\n", > > > + __FUNCTION__, Status)); > > > return Status; > > > } > > > Status = MmcHost->ReceiveResponse (MmcHost, > > MMC_RESPONSE_TYPE_R1, Response); > > > if (EFI_ERROR (Status)) { > > > - DEBUG ((EFI_D_ERROR, "%a(MMC_CMD55): Error and Status = %r\n", > > Status)); > > > + DEBUG ((DEBUG_ERROR, "%a (MMC_CMD55): Error and Status = %r\n", > > > + __FUNCTION__, Status)); > > > return Status; > > > } > > > if ((Response[0] & MMC_STATUS_APP_CMD) == 0) { @@ -445,12 +445,12 > > > @@ InitializeSdMmcDevice ( > > > CmdArg |= 1 << (0 * 4); > > > Status = MmcHost->SendCommand (MmcHost, MMC_CMD6, CmdArg); > > > if (EFI_ERROR (Status)) { > > > - DEBUG ((EFI_D_ERROR, "%a(MMC_CMD6): Error and Status = %r\n", > > Status)); > > > + DEBUG ((DEBUG_ERROR, "%a (MMC_CMD6): Error and Status = %r\n", > > > + __FUNCTION__, Status)); > > > return Status; > > > } else { > > > Status = MmcHost->ReadBlockData (MmcHost, 0, 64, Buffer); > > > if (EFI_ERROR (Status)) { > > > - DEBUG ((EFI_D_ERROR, "%a(MMC_CMD6): ReadBlockData Error and > > Status = %r\n", Status)); > > > + DEBUG ((DEBUG_ERROR, "%a (MMC_CMD6): ReadBlockData Error > > and > > > + Status = %r\n", __FUNCTION__, Status)); > > > return Status; > > > } > > > } > > > @@ -459,20 +459,20 @@ InitializeSdMmcDevice ( > > > CmdArg = MmcHostInstance->CardInfo.RCA << 16; > > > Status = MmcHost->SendCommand (MmcHost, MMC_CMD55, CmdArg); > > > if (EFI_ERROR (Status)) { > > > - DEBUG ((EFI_D_ERROR, "%a(MMC_CMD55): Error and Status = %r\n", > > Status)); > > > + DEBUG ((DEBUG_ERROR, "%a (MMC_CMD55): Error and Status = > > %r\n", > > > + __FUNCTION__, Status)); > > > return Status; > > > } > > > /* Width: 4 */ > > > Status = MmcHost->SendCommand (MmcHost, MMC_CMD6, 2); > > > if (EFI_ERROR (Status)) { > > > - DEBUG ((EFI_D_ERROR, "%a(MMC_CMD6): Error and Status = %r\n", > > Status)); > > > + DEBUG ((DEBUG_ERROR, "%a (MMC_CMD6): Error and Status = %r\n", > > > + __FUNCTION__, Status)); > > > return Status; > > > } > > > } > > > if (MMC_HOST_HAS_SETIOS(MmcHost)) { > > > Status = MmcHost->SetIos (MmcHost, 26 * 1000 * 1000, 4, > > EMMCBACKWARD); > > > if (EFI_ERROR (Status)) { > > > - DEBUG ((EFI_D_ERROR, "%a(SetIos): Error and Status = %r\n", Status)); > > > + DEBUG ((DEBUG_ERROR, "%a (SetIos): Error and Status = %r\n", > > > + __FUNCTION__, Status)); > > > return Status; > > > } > > > } > > > -- > > > 1.9.1 > > >