public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: Ruiyu Ni <ruiyu.ni@intel.com>
To: edk2-devel@lists.01.org
Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org>,
	Benjamin Herrenschmidt <benh@au1.ibm.com>,
	Andrew Fish <afish@apple.com>, Dong Wei <Dong.Wei@arm.com>,
	Laszlo Ersek <lersek@redhat.com>,
	Bartosz Szczepanek <bsz@semihalf.com>
Subject: [PATCH] MdeModulePkg/PciBusDxe: GetBarAttributes() returns Host address
Date: Mon, 11 Sep 2017 13:01:21 +0800	[thread overview]
Message-ID: <20170911050121.85708-1-ruiyu.ni@intel.com> (raw)

Per the UEFI Spec, GetBarAttributes() should return the Host address.
But current implementation returns the address read from the BAR,
which is the Device address.
Per the description of AddressTranslationOffset in ACPI spec:
"For bridges that translate addresses across the bridge, this is the
offset that must be added to the address on the secondary side to
obtain the address on the primary side."
HostAddress = DeviceAddress + AddressTranslationOffset.

Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Ruiyu Ni <ruiyu.ni@intel.com>
Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org>
Cc: Benjamin Herrenschmidt <benh@au1.ibm.com>
Cc: Andrew Fish <afish@apple.com>
Cc: Dong Wei <Dong.Wei@arm.com>
Cc: Laszlo Ersek <lersek@redhat.com>
Cc: Bartosz Szczepanek <bsz@semihalf.com>
---
 MdeModulePkg/Bus/Pci/PciBusDxe/PciIo.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/MdeModulePkg/Bus/Pci/PciBusDxe/PciIo.c b/MdeModulePkg/Bus/Pci/PciBusDxe/PciIo.c
index cc7125e4fc..852d35d710 100644
--- a/MdeModulePkg/Bus/Pci/PciBusDxe/PciIo.c
+++ b/MdeModulePkg/Bus/Pci/PciBusDxe/PciIo.c
@@ -1955,7 +1955,7 @@ PciIoGetBarAttributes (
     End->Checksum = 0;
 
     //
-    // Get the Address Translation Offset
+    // Get the Address Translation Offset and convert the Device address to Host address.
     //
     if (Descriptor->ResType == ACPI_ADDRESS_SPACE_TYPE_MEM) {
       Descriptor->AddrTranslationOffset = GetMmioAddressTranslationOffset (
@@ -1967,6 +1967,7 @@ PciIoGetBarAttributes (
         FreePool (Descriptor);
         return EFI_UNSUPPORTED;
       }
+      Descriptor->AddrRangeMin += Descriptor->AddrTranslationOffset;
     }
   }
 
-- 
2.12.2.windows.2



             reply	other threads:[~2017-09-11  4:58 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-09-11  5:01 Ruiyu Ni [this message]
2017-09-11  6:46 ` [PATCH] MdeModulePkg/PciBusDxe: GetBarAttributes() returns Host address Laszlo Ersek
2017-09-12  4:32   ` Ard Biesheuvel
2017-09-12  5:01   ` Ni, Ruiyu
2017-09-12  6:44     ` Ard Biesheuvel
2017-09-12  8:40       ` Laszlo Ersek
2017-09-12 15:49         ` Ard Biesheuvel
2017-09-12 16:15           ` Laszlo Ersek
     [not found]             ` <1505259457.12628.157.camel@au1.ibm.com>
2017-09-13  3:07               ` Ni, Ruiyu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170911050121.85708-1-ruiyu.ni@intel.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox