From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-x231.google.com (mail-wm0-x231.google.com [IPv6:2a00:1450:400c:c09::231]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 7D95221E87977 for ; Mon, 11 Sep 2017 07:45:51 -0700 (PDT) Received: by mail-wm0-x231.google.com with SMTP id i189so41678071wmf.1 for ; Mon, 11 Sep 2017 07:48:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=dVj0QuhZw+6jGLfj4bikasLTActjsEYh6GrSu/td+Eo=; b=hj7Uy8ofPqzq427qOIY6Ufm2xE22MuQ1YzWKt4sg5HNkketawgvu7tZ1BnDL598eOo ceEZWniWfTgDdRHxBvni9rRQcMmxrwUG2NAJRh867P1uLWRFbbXFJFisCEGYHQ4Ce4zQ 8XIpWXtwneOtZkK2cJgu76L8qConEvBu0AnvQ= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=dVj0QuhZw+6jGLfj4bikasLTActjsEYh6GrSu/td+Eo=; b=rBg4jK0A+1JCTOIiPW2jhAWPwuQOc/+sc8F/ISSonVm509oQFEyo+tpcYFEMgIu6ID 9QvMzWIOn9219Qb6bqrhoWI0nGzCeZDzVoHT+/wT7a8fRPipzi+NB6yuGaYT9i5HGshJ Tv8zEsZ1lNzgNNrwhGy+1Oc9O46W6PTEGLpxoGdih7u2wkp/7zmz8BiO6HP8McEnWrZS iiV7x5iex175c2NLgy6Lu/XEAVQ7+dYnEENr3bycH/M4NoyaCLmC2pEbovNEYIn1qt5k jo3UeNBNcQVvtKgelMhTefJ9h0i2JCwyFy6iVTrp4ZS4MbLHCMn6CgKDXzxSVsjFtJ4j mLhQ== X-Gm-Message-State: AHPjjUh4vZoOrejB25tW7oU4gkYl77MxkinMeZRAzD5s51kz0x/O09c1 2p3r73UZUHnXgHg6pReJo+6NEeP3MZE= X-Google-Smtp-Source: AOwi7QBk4pQ2XLXTXVk8mLTRfZxlQfkV4ir2STuLeA4n9IwU4vcNCWbpa1dEGJblKM6PxS45F5Q8qA== X-Received: by 10.28.206.10 with SMTP id e10mr7826442wmg.63.1505141325739; Mon, 11 Sep 2017 07:48:45 -0700 (PDT) Received: from bivouac.eciton.net (bivouac.eciton.net. [2a00:1098:0:86:1000:23:0:2]) by smtp.gmail.com with ESMTPSA id l15sm12130614wmd.23.2017.09.11.07.48.44 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 11 Sep 2017 07:48:44 -0700 (PDT) Date: Mon, 11 Sep 2017 15:48:43 +0100 From: Leif Lindholm To: Ard Biesheuvel Cc: edk2-devel@lists.01.org, methavanitpong.pipat@socionext.com, masahisa.kojima@linaro.org, masami.hiramatsu@linaro.org Message-ID: <20170911144843.nulec5x773nkxhde@bivouac.eciton.net> References: <20170908182315.9591-1-ard.biesheuvel@linaro.org> <20170908182315.9591-8-ard.biesheuvel@linaro.org> MIME-Version: 1.0 In-Reply-To: <20170908182315.9591-8-ard.biesheuvel@linaro.org> User-Agent: NeoMutt/20170113 (1.7.2) Subject: Re: [PATCH edk2-platforms 07/14] Platform/SynquacerEvalBoard: add PCI support X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 11 Sep 2017 14:45:51 -0000 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Fri, Sep 08, 2017 at 07:23:08PM +0100, Ard Biesheuvel wrote: > Wire up the various drivers and libraries for the SynquacerEvalBoard > platform. Also enable the usual PCI suspects: XHCI, SATA and NVME, > and the various bus, partition and file system drivers that we need > to make use of PCIe devices. If you're folding ChaosKey driver in here (as you are) it deserves a mention in the commit message. > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Ard Biesheuvel > --- > Platform/Socionext/SynquacerEvalBoard/SynquacerEvalBoard.dsc | 49 ++++++++++++++++++++ > Platform/Socionext/SynquacerEvalBoard/SynquacerEvalBoard.fdf | 38 +++++++++++++++ > 2 files changed, 87 insertions(+) > > diff --git a/Platform/Socionext/SynquacerEvalBoard/SynquacerEvalBoard.dsc b/Platform/Socionext/SynquacerEvalBoard/SynquacerEvalBoard.dsc > index 2a9a0037dcda..aea39b46d91b 100644 > --- a/Platform/Socionext/SynquacerEvalBoard/SynquacerEvalBoard.dsc > +++ b/Platform/Socionext/SynquacerEvalBoard/SynquacerEvalBoard.dsc > @@ -100,6 +100,7 @@ > DxeServicesLib|MdePkg/Library/DxeServicesLib/DxeServicesLib.inf > SortLib|MdeModulePkg/Library/UefiSortLib/UefiSortLib.inf > UefiUsbLib|MdePkg/Library/UefiUsbLib/UefiUsbLib.inf > + UefiScsiLib|MdePkg/Library/UefiScsiLib/UefiScsiLib.inf > > # BDS Libraries > UefiBootManagerLib|MdeModulePkg/Library/UefiBootManagerLib/UefiBootManagerLib.inf > @@ -148,6 +149,12 @@ > SecurityManagementLib|MdeModulePkg/Library/DxeSecurityManagementLib/DxeSecurityManagementLib.inf > PerformanceLib|MdeModulePkg/Library/DxePerformanceLib/DxePerformanceLib.inf > > + # > + # PCI > + # > + PciSegmentLib|Silicon/Socionext/Synquacer/Library/SynquacerPciSegmentLib/SynquacerPciSegmentLib.inf > + PciHostBridgeLib|Silicon/Socionext/Synquacer/Library/SynquacerPciHostBridgeLib/SynquacerPciHostBridgeLib.inf > + > [LibraryClasses.common.UEFI_APPLICATION] > PerformanceLib|MdeModulePkg/Library/DxePerformanceLib/DxePerformanceLib.inf > HiiLib|MdeModulePkg/Library/UefiHiiLib/UefiHiiLib.inf > @@ -184,6 +191,7 @@ > gArmTokenSpaceGuid.PcdSystemMemoryBase|0x80000000 > gArmTokenSpaceGuid.PcdSystemMemorySize|0x7F000000 > gEmbeddedTokenSpaceGuid.PcdPrePiCpuMemorySize|40 > + gEmbeddedTokenSpaceGuid.PcdPrePiCpuIoSize|24 > > # Ashbrook 12-Cluster profile > gArmPlatformTokenSpaceGuid.PcdCoreCount|2 > @@ -392,3 +400,44 @@ > NULL|MdeModulePkg/Library/BootManagerUiLib/BootManagerUiLib.inf > NULL|MdeModulePkg/Library/BootMaintenanceManagerUiLib/BootMaintenanceManagerUiLib.inf > } > + > + # > + # PCI > + # > + Silicon/Socionext/Synquacer/Drivers/SynquacerPciCpuIo2dxe/SynquacerPciCpuIo2Dxe.inf > + MdeModulePkg/Bus/Pci/PciHostBridgeDxe/PciHostBridgeDxe.inf { > + > + gEfiMdePkgTokenSpaceGuid.PcdDebugPrintErrorLevel|0x8010004F > + } > + MdeModulePkg/Bus/Pci/PciBusDxe/PciBusDxe.inf > + MdeModulePkg/Bus/Pci/NvmExpressDxe/NvmExpressDxe.inf > + > + # > + # AHCI Support > + # > + MdeModulePkg/Bus/Pci/SataControllerDxe/SataControllerDxe.inf > + MdeModulePkg/Bus/Ata/AtaAtapiPassThru/AtaAtapiPassThru.inf > + MdeModulePkg/Bus/Ata/AtaBusDxe/AtaBusDxe.inf > + MdeModulePkg/Bus/Scsi/ScsiBusDxe/ScsiBusDxe.inf > + MdeModulePkg/Bus/Scsi/ScsiDiskDxe/ScsiDiskDxe.inf > + > + # > + # USB > + # > + MdeModulePkg/Bus/Pci/XhciDxe/XhciDxe.inf > + MdeModulePkg/Bus/Usb/UsbBusDxe/UsbBusDxe.inf > + MdeModulePkg/Bus/Usb/UsbMassStorageDxe/UsbMassStorageDxe.inf > + MdeModulePkg/Bus/Usb/UsbKbDxe/UsbKbDxe.inf Is there a good reason for leaving out Uhci/Ehci? / Leif > + > + # > + # FAT filesystem + GPT/MBR partitioning > + # > + MdeModulePkg/Universal/Disk/DiskIoDxe/DiskIoDxe.inf > + MdeModulePkg/Universal/Disk/PartitionDxe/PartitionDxe.inf > + MdeModulePkg/Universal/Disk/UnicodeCollation/EnglishDxe/EnglishDxe.inf > + FatPkg/EnhancedFatDxe/Fat.inf > + > + # > + # RNG > + # > + Silicon/Openmoko/ChaosKeyDxe/ChaosKeyDxe.inf > diff --git a/Platform/Socionext/SynquacerEvalBoard/SynquacerEvalBoard.fdf b/Platform/Socionext/SynquacerEvalBoard/SynquacerEvalBoard.fdf > index 6c00e16b169e..befad354918e 100644 > --- a/Platform/Socionext/SynquacerEvalBoard/SynquacerEvalBoard.fdf > +++ b/Platform/Socionext/SynquacerEvalBoard/SynquacerEvalBoard.fdf > @@ -128,6 +128,44 @@ READ_LOCK_STATUS = TRUE > INF MdeModulePkg/Universal/BdsDxe/BdsDxe.inf > INF MdeModulePkg/Application/UiApp/UiApp.inf > > + # > + # PCI > + # > + INF Silicon/Socionext/Synquacer/Drivers/SynquacerPciCpuIo2dxe/SynquacerPciCpuIo2Dxe.inf > + INF MdeModulePkg/Bus/Pci/PciHostBridgeDxe/PciHostBridgeDxe.inf > + INF MdeModulePkg/Bus/Pci/PciBusDxe/PciBusDxe.inf > + INF MdeModulePkg/Bus/Pci/NvmExpressDxe/NvmExpressDxe.inf > + > + # > + # AHCI Support > + # > + INF MdeModulePkg/Bus/Pci/SataControllerDxe/SataControllerDxe.inf > + INF MdeModulePkg/Bus/Ata/AtaAtapiPassThru/AtaAtapiPassThru.inf > + INF MdeModulePkg/Bus/Ata/AtaBusDxe/AtaBusDxe.inf > + INF MdeModulePkg/Bus/Scsi/ScsiBusDxe/ScsiBusDxe.inf > + INF MdeModulePkg/Bus/Scsi/ScsiDiskDxe/ScsiDiskDxe.inf > + > + # > + # USB > + # > + INF MdeModulePkg/Bus/Pci/XhciDxe/XhciDxe.inf > + INF MdeModulePkg/Bus/Usb/UsbBusDxe/UsbBusDxe.inf > + INF MdeModulePkg/Bus/Usb/UsbMassStorageDxe/UsbMassStorageDxe.inf > + INF MdeModulePkg/Bus/Usb/UsbKbDxe/UsbKbDxe.inf > + > + # > + # FAT filesystem + GPT/MBR partitioning > + # > + INF MdeModulePkg/Universal/Disk/DiskIoDxe/DiskIoDxe.inf > + INF MdeModulePkg/Universal/Disk/PartitionDxe/PartitionDxe.inf > + INF MdeModulePkg/Universal/Disk/UnicodeCollation/EnglishDxe/EnglishDxe.inf > + INF FatPkg/EnhancedFatDxe/Fat.inf > + > + # > + # RNG > + # > + INF Silicon/Openmoko/ChaosKeyDxe/ChaosKeyDxe.inf > + > [FV.FVMAIN_COMPACT] > FvAlignment = 8 > ERASE_POLARITY = 1 > -- > 2.11.0 >