From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from cam-smtp0.cambridge.arm.com (fw-tnat.cambridge.arm.com [217.140.96.140]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id B0E9521D492EF for ; Wed, 13 Sep 2017 11:13:31 -0700 (PDT) Received: from E111747.Emea.Arm.com (e111747.emea.arm.com [10.1.26.71]) by cam-smtp0.cambridge.arm.com (8.13.8/8.13.8) with ESMTP id v8DIGQUA023888; Wed, 13 Sep 2017 19:16:27 +0100 From: evan.lloyd@arm.com To: edk2-devel@lists.01.org Cc: Ard Biesheuvel , Leif Lindholm , Matteo Carlini , nd@arm.com Date: Wed, 13 Sep 2017 19:16:20 +0100 Message-Id: <20170913181621.45384-2-evan.lloyd@arm.com> X-Mailer: git-send-email 2.14.1 In-Reply-To: <20170913181621.45384-1-evan.lloyd@arm.com> References: <20170913181621.45384-1-evan.lloyd@arm.com> Subject: [PATCH 1/2] ArmPlatformPkg: Juno networking build option X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 13 Sep 2017 18:13:32 -0000 From: Sami When network functionality is not required, the boot process is impeded by redundant network timeouts. Moreover Juno is a mobile platform so it makes sense to have an option to disable the (ethernet) networking support. We therefore introduce the DISABLE_NETWORK build option. By default ArmJunoDxe configures the MAC address. This is redundant when networking is disabled, so the MAC Address configuration is removed when the DISABLE_NETWORK build option is defined. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Sami Mujawar Signed-off-by: Evan Lloyd --- ArmPlatformPkg/ArmJunoPkg/Drivers/ArmJunoDxe/ArmJunoDxe.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/ArmPlatformPkg/ArmJunoPkg/Drivers/ArmJunoDxe/ArmJunoDxe.c b/ArmPlatformPkg/ArmJunoPkg/Drivers/ArmJunoDxe/ArmJunoDxe.c index 18491c7378523f365644658c270de95e711c5ac1..456e21ba47db7ec440ac1ef5554eccd5e4d2bcf9 100644 --- a/ArmPlatformPkg/ArmJunoPkg/Drivers/ArmJunoDxe/ArmJunoDxe.c +++ b/ArmPlatformPkg/ArmJunoPkg/Drivers/ArmJunoDxe/ArmJunoDxe.c @@ -1,6 +1,6 @@ /** @file * -* Copyright (c) 2013-2015, ARM Limited. All rights reserved. +* Copyright (c) 2013-2017, ARM Limited. All rights reserved. * * This program and the accompanying materials * are licensed and made available under the terms and conditions of the BSD License @@ -71,6 +71,7 @@ STATIC CONST EFI_PCI_ROOT_BRIDGE_DEVICE_PATH mPciRootComplexDevicePath = { EFI_EVENT mAcpiRegistration = NULL; +#ifndef DISABLE_NETWORK /** This function reads PCI ID of the controller. @@ -355,6 +356,7 @@ ArmJunoSetNicMacAddress () return EFI_SUCCESS; } +#endif /** Notification function of the event defined as belonging to the @@ -395,10 +397,12 @@ OnEndOfDxe ( Status = gBS->ConnectController (Handle, NULL, PciRootComplexDevicePath, FALSE); ASSERT_EFI_ERROR (Status); +#ifndef DISABLE_NETWORK Status = ArmJunoSetNicMacAddress (); if (EFI_ERROR (Status)) { DEBUG ((DEBUG_ERROR, "ArmJunoDxe: Failed to set Marvell Yukon NIC MAC address\n")); } +#endif } EFI_STATUS -- Guid("CE165669-3EF3-493F-B85D-6190EE5B9759")