From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 9602E21E87993 for ; Wed, 13 Sep 2017 19:40:56 -0700 (PDT) Received: from orsmga005.jf.intel.com ([10.7.209.41]) by fmsmga104.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 13 Sep 2017 19:43:54 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.42,390,1500966000"; d="scan'208";a="148970061" Received: from cchiu4-mobl1.gar.corp.intel.com ([10.5.240.32]) by orsmga005.jf.intel.com with ESMTP; 13 Sep 2017 19:43:53 -0700 From: "Chasel, Chiu" To: edk2-devel@lists.01.org Cc: Jiewen Yao , Chasel Chiu Date: Thu, 14 Sep 2017 10:43:30 +0800 Message-Id: <20170914024330.8032-1-chasel.chiu@intel.com> X-Mailer: git-send-email 2.13.3.windows.1 Subject: [PATCH] IntelFsp2Pkg-Tools: GenCfgOpt.py shouldn't include specific UPD name X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 14 Sep 2017 02:40:56 -0000 PcdSerialIoUartDebugEnable UPD is platform specific and should not be included in generic GenCfgOpt.py script. Remove this and platform DSC should control the default value instead. Cc: Jiewen Yao Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Chasel Chiu --- IntelFsp2Pkg/Tools/GenCfgOpt.py | 12 ------------ 1 file changed, 12 deletions(-) diff --git a/IntelFsp2Pkg/Tools/GenCfgOpt.py b/IntelFsp2Pkg/Tools/GenCfgOpt.py index 6dc1b10b34..c9b7bc5373 100644 --- a/IntelFsp2Pkg/Tools/GenCfgOpt.py +++ b/IntelFsp2Pkg/Tools/GenCfgOpt.py @@ -289,7 +289,6 @@ class CGenCfgOpt: def __init__(self): self.Debug = False self.Error = '' - self.ReleaseMode = True self._GlobalDataDef = """ GlobalDataDef @@ -318,13 +317,6 @@ EndList self._FvDir = '' self._MapVer = 0 - def ParseBuildMode (self, OutputStr): - if "RELEASE_" in OutputStr: - self.ReleaseMode = True - if "DEBUG_" in OutputStr: - self.ReleaseMode = False - return - def ParseMacros (self, MacroDefStr): # ['-DABC=1', '-D', 'CFG_DEBUG=1', '-D', 'CFG_OUTDIR=Build'] self._MacroDict = {} @@ -815,9 +807,6 @@ EndList TxtFd.write("%s.UnusedUpdSpace%d|%s0x%04X|0x%04X|{0}\n" % (Item['space'], SpaceIdx, Default, NextOffset - StartAddr, Offset - NextOffset)) SpaceIdx = SpaceIdx + 1 NextOffset = Offset + Item['length'] - if Item['cname'] == 'PcdSerialIoUartDebugEnable': - if self.ReleaseMode == False: - Item['value'] = 0x01 TxtFd.write("%s.%s|%s0x%04X|%s|%s\n" % (Item['space'],Item['cname'],Default,Item['offset'] - StartAddr,Item['length'],Item['value'])) TxtFd.close() return 0 @@ -1437,7 +1426,6 @@ def Main(): print "ERROR: Macro parsing failed !" return 3 - GenCfgOpt.ParseBuildMode(sys.argv[3]) FvDir = sys.argv[3] if not os.path.exists(FvDir): os.makedirs(FvDir) -- 2.13.3.windows.1