[PATCH 0/2] OvmfPkg/VirtioNetDxe: update TechNotes, log message at ExitBootServices

[PATCH 0/2] OvmfPkg/VirtioNetDxe: update TechNotes, log message at ExitBootServices

[Laszlo Ersek]

Repo:   https://github.com/lersek/edk2.git
Branch: vnet_technotes_exitboot_after_map

Cc: Brijesh Singh <brijesh.singh@amd.com>
Cc: Jordan Justen <jordan.l.justen@intel.com>

Laszlo Ersek (2):
  OvmfPkg/VirtioNetDxe: document Rx/Tx allocs and mappings on
    Init/Shutdown
  OvmfPkg/VirtioNetDxe: log debug message in VirtioNetExitBoot()

 OvmfPkg/VirtioNetDxe/TechNotes.txt | 12 ++++++++----
 OvmfPkg/VirtioNetDxe/Events.c      |  1 +
 2 files changed, 9 insertions(+), 4 deletions(-)

-- 
2.14.1.3.gb7cf6e02401b

[PATCH 1/2] OvmfPkg/VirtioNetDxe: document Rx/Tx allocs and mappings on Init/Shutdown

[Laszlo Ersek]

Document the following actions on the

  EfiSimpleNetworkStarted <-> EfiSimpleNetworkInitialized

state transitions:

* from commit 46b11f00ac70 ("OvmfPkg/VirtioNetDxe: alloc RxBuf using
  AllocateSharedPages()", 2017-09-14):

  VirtioNetInitRx ->
  { VirtIo->AllocateSharedPages, VirtioMapAllBytesInSharedBuffer }

  VirtioNetShutdownRx ->
  { VirtIo->UnmapSharedBuffer, VirtIo->FreeSharedPages }

* from commit 891f016c1b99 ("OvmfPkg/VirtioNetDxe: dynamically alloc
  transmit header", 2017-09-14):

  VirtioNetInitTx ->
  { VirtIo->AllocateSharedPages, VirtioMapAllBytesInSharedBuffer }

  VirtioNetShutdownTx ->
  { VirtIo->UnmapSharedBuffer, VirtIo->FreeSharedPages }

Cc: Brijesh Singh <brijesh.singh@amd.com>
Cc: Jordan Justen <jordan.l.justen@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Laszlo Ersek <lersek@redhat.com>
---
 OvmfPkg/VirtioNetDxe/TechNotes.txt | 12 ++++++++----
 1 file changed, 8 insertions(+), 4 deletions(-)

diff --git a/OvmfPkg/VirtioNetDxe/TechNotes.txt b/OvmfPkg/VirtioNetDxe/TechNotes.txt
index 40a22f66dc22..cd38750a4afb 100644
--- a/OvmfPkg/VirtioNetDxe/TechNotes.txt
+++ b/OvmfPkg/VirtioNetDxe/TechNotes.txt
@@ -69,10 +69,14 @@ faithfully indented) that implement the transition.
   [SnpInitialize.c]            |  | [SnpShutdown.c]
   VirtioNetInitialize          |  | VirtioNetShutdown
     VirtioNetInitRing {Rx, Tx} |  |   VirtioNetShutdownRx [SnpSharedHelpers.c]
-      VirtioRingInit           |  |   VirtioNetShutdownTx [SnpSharedHelpers.c]
-      VirtioRingMap            |  |   VirtioNetUninitRing [SnpSharedHelpers.c]
-    VirtioNetInitTx            |  |                       {Tx, Rx}
-    VirtioNetInitRx            |  |     VirtIo->UnmapSharedBuffer
+      VirtioRingInit           |  |     VirtIo->UnmapSharedBuffer
+      VirtioRingMap            |  |     VirtIo->FreeSharedPages
+    VirtioNetInitTx            |  |   VirtioNetShutdownTx [SnpSharedHelpers.c]
+      VirtIo->AllocateShare... |  |     VirtIo->UnmapSharedBuffer
+      VirtioMapAllBytesInSh... |  |     VirtIo->FreeSharedPages
+    VirtioNetInitRx            |  |   VirtioNetUninitRing [SnpSharedHelpers.c]
+      VirtIo->AllocateShare... |  |                       {Tx, Rx}
+      VirtioMapAllBytesInSh... |  |     VirtIo->UnmapSharedBuffer
                                |  |     VirtioRingUninit
                                v  |
                   +-----------------------------+
-- 
2.14.1.3.gb7cf6e02401b

[PATCH 2/2] OvmfPkg/VirtioNetDxe: log debug message in VirtioNetExitBoot()

[Laszlo Ersek]

The other four virtio device drivers (VirtioBlkDxe, VirtioGpuDxe,
VirtioRngDxe, VirtioScsiDxe) log such messages at this point; follow suit.

Cc: Brijesh Singh <brijesh.singh@amd.com>
Cc: Jordan Justen <jordan.l.justen@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Laszlo Ersek <lersek@redhat.com>
---
 OvmfPkg/VirtioNetDxe/Events.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/OvmfPkg/VirtioNetDxe/Events.c b/OvmfPkg/VirtioNetDxe/Events.c
index 5be1af6ffbee..c79bae9c35e1 100644
--- a/OvmfPkg/VirtioNetDxe/Events.c
+++ b/OvmfPkg/VirtioNetDxe/Events.c
@@ -84,6 +84,7 @@ VirtioNetExitBoot (
   //
   VNET_DEV *Dev;
 
+  DEBUG ((DEBUG_VERBOSE, "%a: Context=0x%p\n", __FUNCTION__, Context));
   Dev = Context;
   if (Dev->Snm.State == EfiSimpleNetworkInitialized) {
     Dev->VirtIo->SetDeviceStatus (Dev->VirtIo, 0);
-- 
2.14.1.3.gb7cf6e02401b

Re: [PATCH 1/2] OvmfPkg/VirtioNetDxe: document Rx/Tx allocs and mappings on Init/Shutdown

[Brijesh Singh]

On 09/15/2017 03:57 AM, Laszlo Ersek wrote:
> Document the following actions on the
> 
>    EfiSimpleNetworkStarted <-> EfiSimpleNetworkInitialized
> 
> state transitions:
> 
> * from commit 46b11f00ac70 ("OvmfPkg/VirtioNetDxe: alloc RxBuf using
>    AllocateSharedPages()", 2017-09-14):
> 
>    VirtioNetInitRx ->
>    { VirtIo->AllocateSharedPages, VirtioMapAllBytesInSharedBuffer }
> 
>    VirtioNetShutdownRx ->
>    { VirtIo->UnmapSharedBuffer, VirtIo->FreeSharedPages }
> 
> * from commit 891f016c1b99 ("OvmfPkg/VirtioNetDxe: dynamically alloc
>    transmit header", 2017-09-14):
> 
>    VirtioNetInitTx ->
>    { VirtIo->AllocateSharedPages, VirtioMapAllBytesInSharedBuffer }
> 
>    VirtioNetShutdownTx ->
>    { VirtIo->UnmapSharedBuffer, VirtIo->FreeSharedPages }
> 
> Cc: Brijesh Singh <brijesh.singh@amd.com>
> Cc: Jordan Justen <jordan.l.justen@intel.com>
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Laszlo Ersek <lersek@redhat.com>
> ---
>   OvmfPkg/VirtioNetDxe/TechNotes.txt | 12 ++++++++----
>   1 file changed, 8 insertions(+), 4 deletions(-)
> 

Reviewed-by: Brijesh Singh <brijesh.singh@amd.com>

Re: [PATCH 2/2] OvmfPkg/VirtioNetDxe: log debug message in VirtioNetExitBoot()

[Brijesh Singh]

On 09/15/2017 03:57 AM, Laszlo Ersek wrote:
> The other four virtio device drivers (VirtioBlkDxe, VirtioGpuDxe,
> VirtioRngDxe, VirtioScsiDxe) log such messages at this point; follow suit.
> 
> Cc: Brijesh Singh <brijesh.singh@amd.com>
> Cc: Jordan Justen <jordan.l.justen@intel.com>
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Laszlo Ersek <lersek@redhat.com>
> ---
>   OvmfPkg/VirtioNetDxe/Events.c | 1 +
>   1 file changed, 1 insertion(+)
> 

Reviewed-by: Brijesh Singh <brijesh.singh@amd.com>

Re: [PATCH 0/2] OvmfPkg/VirtioNetDxe: update TechNotes, log message at ExitBootServices

[Laszlo Ersek]

On 09/15/17 10:57, Laszlo Ersek wrote:
> Repo:   https://github.com/lersek/edk2.git
> Branch: vnet_technotes_exitboot_after_map
> 
> Cc: Brijesh Singh <brijesh.singh@amd.com>
> Cc: Jordan Justen <jordan.l.justen@intel.com>
> 
> Laszlo Ersek (2):
>   OvmfPkg/VirtioNetDxe: document Rx/Tx allocs and mappings on
>     Init/Shutdown
>   OvmfPkg/VirtioNetDxe: log debug message in VirtioNetExitBoot()
> 
>  OvmfPkg/VirtioNetDxe/TechNotes.txt | 12 ++++++++----
>  OvmfPkg/VirtioNetDxe/Events.c      |  1 +
>  2 files changed, 9 insertions(+), 4 deletions(-)
> 

Commit range f9c59fa44ae2..d83defe0df34.

Thanks!
Laszlo