public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: Leif Lindholm <leif.lindholm@linaro.org>
To: evan.lloyd@arm.com
Cc: edk2-devel@lists.01.org,
	Ard Biesheuvel <ard.biesheuvel@linaro.org>,
	Matteo Carlini <Matteo.Carlini@arm.com>,
	nd@arm.com
Subject: Re: [PATCH 0/2] Options to remove code
Date: Fri, 15 Sep 2017 15:46:50 +0100	[thread overview]
Message-ID: <20170915144649.5rxlocc2xmd2lgsh@bivouac.eciton.net> (raw)
In-Reply-To: <20170913181621.45384-1-evan.lloyd@arm.com>

Hi Evan,

On Wed, Sep 13, 2017 at 07:16:19PM +0100, evan.lloyd@arm.com wrote:
> From: EvanLloyd <evan.lloyd@arm.com>
> 
> There are a number of cases where it is desirable to remove unused code.
> An obvious instance might be on an emulator, where executing irrelevant
> code can add hours to the boot time.  This change enables removal of
> some code that might not be relevant, using build options that can be
> configured in the platform build.

In principle, I'm fine with this change.

However, I would have expected a companion patch to this (for
edk2-platforms) to add a CFLAGS statement to the platform build if
some build option was specified with -D. Or am I missing some way of
doing this directly on the build command line?

Also, this patch by Sami

> Sami (1):
>   ArmPlatformPkg: Juno networking build option

and this patch by Sami

> Sami Mujawar (1):
>   ArmPlatformPkg: Remove DT code when unsupported

have different author names, which also confuses this cover letter
somewhat.

/
    Leif

>  ArmPlatformPkg/ArmJunoPkg/Drivers/ArmJunoDxe/ArmJunoDxe.c | 10 +++++++++-
>  1 file changed, 9 insertions(+), 1 deletion(-)
> 
> -- 
> Guid("CE165669-3EF3-493F-B85D-6190EE5B9759")
> 


      parent reply	other threads:[~2017-09-15 14:43 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-09-13 18:16 [PATCH 0/2] Options to remove code evan.lloyd
2017-09-13 18:16 ` [PATCH 1/2] ArmPlatformPkg: Juno networking build option evan.lloyd
2017-09-13 18:16 ` [PATCH 2/2] ArmPlatformPkg: Remove DT code when unsupported evan.lloyd
2017-09-15 14:46 ` Leif Lindholm [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170915144649.5rxlocc2xmd2lgsh@bivouac.eciton.net \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox