From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-x233.google.com (mail-wm0-x233.google.com [IPv6:2a00:1450:400c:c09::233]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 2661B21E87992 for ; Fri, 15 Sep 2017 07:43:54 -0700 (PDT) Received: by mail-wm0-x233.google.com with SMTP id v142so8904908wmv.5 for ; Fri, 15 Sep 2017 07:46:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=WbhHD7Zbb7CxltNfjGOsXYdgIMhebIyrl7aHda1IGhY=; b=fTccIj0xviVaVk8dxEmn+Ss8iFP9uJZ+DhjgWZhGKjpNve2DgfQobKwf1VepNiMdQM cpRSWfgPK9WE1prHTyAb0aTDVHFN5SdKNcQqGNU6RYYtm9LsGQD7NP/lIcJmsa8cGumh wW6MEzK8PVtlWcdHhmNRjPGgPFHT7mtRbDzv8= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=WbhHD7Zbb7CxltNfjGOsXYdgIMhebIyrl7aHda1IGhY=; b=iZESBvI19TqjpKs9NdCYmUsx/0Q6EvR4SZLOEGl5FqPZXHleuyNyRLU99ZViHMWBSP xXyMnGDugcJrr0ig2ySH//gM9601DrF8HXv7ha+VGDJRM5S09GHXCDqUmiGRPYWiIW1m SyZCyNbNqA2nMpW99Mc2uTF7VXx728Mv2qMlz1mk8hjJGzAky/vK+Ka5P/D8ti1gQ/w0 cfM9uHij0ohousld4MubE/hDUnJAVp/UKi4R+15aQMiMQvRDoJ0X75zbt0BhAIDJ2H9L 7HNo6hdI9XGZwKjeJggnK2/V0NyZO9G+dRophG81p8yiyWSBjCf2IzmCdOJ50dvZI+IS GGmw== X-Gm-Message-State: AHPjjUjgFdeHN/oowNEfKBNlPZTvm1a4E+k9/VCLS44FE5BKNoqCGa5S aZGyLaZLL7PJvzm2 X-Google-Smtp-Source: AOwi7QA/ACpL2JEaMTsDBqlr0SeYKMLt3SL0RL2wwhd+JoXkE3sfFYL7j5jnDwodRz9C9c+jDMm/fw== X-Received: by 10.28.16.16 with SMTP id 16mr3162393wmq.62.1505486812750; Fri, 15 Sep 2017 07:46:52 -0700 (PDT) Received: from bivouac.eciton.net (bivouac.eciton.net. [2a00:1098:0:86:1000:23:0:2]) by smtp.gmail.com with ESMTPSA id d6sm771908wrb.32.2017.09.15.07.46.51 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Fri, 15 Sep 2017 07:46:51 -0700 (PDT) Date: Fri, 15 Sep 2017 15:46:50 +0100 From: Leif Lindholm To: evan.lloyd@arm.com Cc: edk2-devel@lists.01.org, Ard Biesheuvel , Matteo Carlini , nd@arm.com Message-ID: <20170915144649.5rxlocc2xmd2lgsh@bivouac.eciton.net> References: <20170913181621.45384-1-evan.lloyd@arm.com> MIME-Version: 1.0 In-Reply-To: <20170913181621.45384-1-evan.lloyd@arm.com> User-Agent: NeoMutt/20170113 (1.7.2) Subject: Re: [PATCH 0/2] Options to remove code X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 15 Sep 2017 14:43:54 -0000 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Hi Evan, On Wed, Sep 13, 2017 at 07:16:19PM +0100, evan.lloyd@arm.com wrote: > From: EvanLloyd > > There are a number of cases where it is desirable to remove unused code. > An obvious instance might be on an emulator, where executing irrelevant > code can add hours to the boot time. This change enables removal of > some code that might not be relevant, using build options that can be > configured in the platform build. In principle, I'm fine with this change. However, I would have expected a companion patch to this (for edk2-platforms) to add a CFLAGS statement to the platform build if some build option was specified with -D. Or am I missing some way of doing this directly on the build command line? Also, this patch by Sami > Sami (1): > ArmPlatformPkg: Juno networking build option and this patch by Sami > Sami Mujawar (1): > ArmPlatformPkg: Remove DT code when unsupported have different author names, which also confuses this cover letter somewhat. / Leif > ArmPlatformPkg/ArmJunoPkg/Drivers/ArmJunoDxe/ArmJunoDxe.c | 10 +++++++++- > 1 file changed, 9 insertions(+), 1 deletion(-) > > -- > Guid("CE165669-3EF3-493F-B85D-6190EE5B9759") >