public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: Hao Wu <hao.a.wu@intel.com>
To: edk2-devel@lists.01.org
Cc: Hao Wu <hao.a.wu@intel.com>, Steven Shi <steven.shi@intel.com>,
	Star Zeng <star.zeng@intel.com>, Eric Dong <eric.dong@intel.com>
Subject: [PATCH 3/6] MdeModulePkg/Tpl: Fix negative value left shift
Date: Tue, 19 Sep 2017 19:43:48 +0800	[thread overview]
Message-ID: <20170919114351.18448-4-hao.a.wu@intel.com> (raw)
In-Reply-To: <20170919114351.18448-1-hao.a.wu@intel.com>

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=695

Within function CoreRestoreTpl(), left shift a negative value -2 is used
in:
"while (((-2 << NewTpl) & gEventPending) != 0) {"

which involves undefined behavior.

According to the C11 spec, Section 6.5.7:
> 4 The result of E1 << E2 is E1 left-shifted E2 bit positions; vacated
>   bits are filled with zeros. If E1 has an unsigned type, the value
>   of the result is E1 * 2^E2 , reduced modulo one more than the
>   maximum value representable in the result type. If E1 has a signed
>   type and nonnegative value, and E1 * 2^E2 is representable in the
>   result type, then that is the resulting value; otherwise, the
>   behavior is undefined.

This commit explicitly cast '-2' with UINTN to resolve this issue.

Cc: Steven Shi <steven.shi@intel.com>
Cc: Star Zeng <star.zeng@intel.com>
Cc: Eric Dong <eric.dong@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Hao Wu <hao.a.wu@intel.com>
---
 MdeModulePkg/Core/Dxe/Event/Tpl.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/MdeModulePkg/Core/Dxe/Event/Tpl.c b/MdeModulePkg/Core/Dxe/Event/Tpl.c
index 8ad0a33701..8c50f61117 100644
--- a/MdeModulePkg/Core/Dxe/Event/Tpl.c
+++ b/MdeModulePkg/Core/Dxe/Event/Tpl.c
@@ -123,7 +123,7 @@ CoreRestoreTpl (
   //
   // Dispatch any pending events
   //
-  while (((-2 << NewTpl) & gEventPending) != 0) {
+  while (((((UINTN)-2) << NewTpl) & gEventPending) != 0) {
     gEfiCurrentTpl = (UINTN) HighBitSet64 (gEventPending);
     if (gEfiCurrentTpl < TPL_HIGH_LEVEL) {
       CoreSetInterruptState (TRUE);
-- 
2.12.0.windows.1



  parent reply	other threads:[~2017-09-19 11:40 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-09-19 11:43 [PATCH 0/6] Resolve undefined behaviours in left shift OPs Hao Wu
2017-09-19 11:43 ` [PATCH 1/6] MdePkg/PrintLib: Fix possible negative value left shift Hao Wu
2017-09-19 11:43 ` [PATCH 2/6] MdeModulePkg/PrintLib: " Hao Wu
2017-09-19 11:43 ` Hao Wu [this message]
2017-09-19 17:02   ` [PATCH 3/6] MdeModulePkg/Tpl: Fix " Paolo Bonzini
2017-09-21  2:57     ` Zeng, Star
2017-09-21  3:06       ` Wu, Hao A
2017-09-19 11:43 ` [PATCH 4/6] MdeModulePkg/DxeNetLib: " Hao Wu
2017-09-19 17:04   ` Paolo Bonzini
2017-09-21  5:38   ` Wu, Jiaxin
2017-09-19 11:43 ` [PATCH 5/6] MdeModulePkg/Crc32: Fix possible out of range " Hao Wu
2017-09-19 17:05   ` Paolo Bonzini
2017-09-21  1:30     ` Wu, Hao A
2017-09-19 11:43 ` [PATCH 6/6] MdeModulePkg/AtaAtapiPassThru: " Hao Wu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170919114351.18448-4-hao.a.wu@intel.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox