public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: Hao Wu <hao.a.wu@intel.com>
To: edk2-devel@lists.01.org
Cc: Hao Wu <hao.a.wu@intel.com>, Steven Shi <steven.shi@intel.com>,
	Michael Kinney <michael.d.kinney@intel.com>,
	Liming Gao <liming.gao@intel.com>,
	Star Zeng <star.zeng@intel.com>, Eric Dong <eric.dong@intel.com>,
	Fu Siyuan <siyuan.fu@intel.com>, Ye Ting <ting.ye@intel.com>,
	Wu Jiaxin <jiaxin.wu@intel.com>, Qin Long <qin.long@intel.com>,
	Paolo Bonzini <pbonzini@redhat.com>
Subject: [PATCH v2 0/6] Resolve undefined behaviours in left shift OPs
Date: Thu, 21 Sep 2017 14:46:11 +0800	[thread overview]
Message-ID: <20170921064617.2628-1-hao.a.wu@intel.com> (raw)

According to the feebacks from Paolo, the following changes are made in
this version of patch series:
  a. Refine the code logic in Tpl.c to void left shifting the negative
     value. Also makes the code more readable;
  b. Remove the '~' operator before 'Time.Hour' in DxeNetLib.c, since it
     seems like an implementation choice for generating the seed;
  c. Use '1U' instead of '(UINT32)1' in Crc32.c.


V1 history:
The series resolves two kinds of undefined behaviours in left shift
operations:
  a. Left-shifting negative values;
  b. Left-shifting that incurs the result being out of range.

Cc: Steven Shi <steven.shi@intel.com>
Cc: Michael Kinney <michael.d.kinney@intel.com>
Cc: Liming Gao <liming.gao@intel.com>
Cc: Star Zeng <star.zeng@intel.com>
Cc: Eric Dong <eric.dong@intel.com>
Cc: Fu Siyuan <siyuan.fu@intel.com>
Cc: Ye Ting <ting.ye@intel.com>
Cc: Wu Jiaxin <jiaxin.wu@intel.com>
Cc: Qin Long <qin.long@intel.com>
Cc: Paolo Bonzini <pbonzini@redhat.com> 

Hao Wu (6):
  MdePkg/PrintLib: Fix possible negative value left shift
  MdeModulePkg/PrintLib: Fix possible negative value left shift
  MdeModulePkg/Tpl: Fix negative value left shift
  MdeModulePkg/DxeNetLib: Fix negative value left shift
  MdeModulePkg/Crc32: Fix possible out of range left shift
  MdeModulePkg/AtaAtapiPassThru: Fix possible out of range left shift

 MdeModulePkg/Bus/Ata/AtaAtapiPassThru/AhciMode.c          |  4 ++--
 MdeModulePkg/Core/Dxe/Event/Tpl.c                         | 12 +++++++++---
 MdeModulePkg/Core/RuntimeDxe/Crc32.c                      |  6 +++---
 MdeModulePkg/Library/DxeNetLib/DxeNetLib.c                |  2 +-
 MdeModulePkg/Library/DxePrintLibPrint2Protocol/PrintLib.c |  2 +-
 MdePkg/Library/BasePrintLib/PrintLibInternal.c            |  2 +-
 6 files changed, 17 insertions(+), 11 deletions(-)

-- 
2.12.0.windows.1



             reply	other threads:[~2017-09-21  6:43 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-09-21  6:46 Hao Wu [this message]
2017-09-21  6:46 ` [PATCH v2 1/6] MdePkg/PrintLib: Fix possible negative value left shift Hao Wu
2017-09-28  3:58   ` Gao, Liming
2017-09-21  6:46 ` [PATCH v2 2/6] MdeModulePkg/PrintLib: " Hao Wu
2017-09-28  3:58   ` Gao, Liming
2017-09-21  6:46 ` [PATCH v2 3/6] MdeModulePkg/Tpl: Fix " Hao Wu
2017-09-25  6:21   ` Zeng, Star
2017-09-21  6:46 ` [PATCH v2 4/6] MdeModulePkg/DxeNetLib: " Hao Wu
2017-09-25  6:21   ` Zeng, Star
2017-09-21  6:46 ` [PATCH v2 5/6] MdeModulePkg/Crc32: Fix possible out of range " Hao Wu
2017-09-28  3:54   ` Gao, Liming
2017-09-28  3:55     ` Wu, Hao A
2017-09-21  6:46 ` [PATCH v2 6/6] MdeModulePkg/AtaAtapiPassThru: " Hao Wu
2017-09-25  6:24   ` Zeng, Star
2017-09-28  3:56     ` Gao, Liming
2017-09-28  5:13       ` Zeng, Star

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170921064617.2628-1-hao.a.wu@intel.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox