public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
* [PATCH] IntelFsp2Pkg-Tools: Add FixedAtBuild PCD support in GenCfgOpt.py
@ 2017-09-21  7:51 Chasel, Chiu
  2017-09-21  7:55 ` Yao, Jiewen
  0 siblings, 1 reply; 2+ messages in thread
From: Chasel, Chiu @ 2017-09-21  7:51 UTC (permalink / raw)
  To: edk2-devel; +Cc: Jiewen Yao, Maurice, Ma, Chasel Chiu

Platform is eligible to use either PcdsFeatureFlag or
PcdsFixedAtBuild for build configuration and requires
GenCfgOpt.py support.

Cc: Jiewen Yao <Jiewen.yao@intel.com>
Cc: Maurice, Ma <maurice.ma@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Chasel Chiu <chasel.chiu@intel.com>
---
 IntelFsp2Pkg/Tools/GenCfgOpt.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/IntelFsp2Pkg/Tools/GenCfgOpt.py b/IntelFsp2Pkg/Tools/GenCfgOpt.py
index 6dc1b10b34..64e0a3a985 100644
--- a/IntelFsp2Pkg/Tools/GenCfgOpt.py
+++ b/IntelFsp2Pkg/Tools/GenCfgOpt.py
@@ -457,7 +457,7 @@ EndList
                 IsUpdSect = False
                 if  Match.group(1).lower() == "Defines".lower():
                     IsDefSect = True
-                if  Match.group(1).lower() == "PcdsFeatureFlag".lower():
+                if  (Match.group(1).lower() == "PcdsFeatureFlag".lower() or Match.group(1).lower() == "PcdsFixedAtBuild".lower()):
                     IsPcdSect = True
                 elif Match.group(1).lower() == "PcdsDynamicVpd.Upd".lower():
                     ConfigDict = {}
-- 
2.13.3.windows.1



^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] IntelFsp2Pkg-Tools: Add FixedAtBuild PCD support in GenCfgOpt.py
  2017-09-21  7:51 [PATCH] IntelFsp2Pkg-Tools: Add FixedAtBuild PCD support in GenCfgOpt.py Chasel, Chiu
@ 2017-09-21  7:55 ` Yao, Jiewen
  0 siblings, 0 replies; 2+ messages in thread
From: Yao, Jiewen @ 2017-09-21  7:55 UTC (permalink / raw)
  To: Chiu, Chasel, edk2-devel@lists.01.org

Reviewed-by: Jiewen.yao@intel.com

> -----Original Message-----
> From: Chiu, Chasel
> Sent: Thursday, September 21, 2017 3:51 PM
> To: edk2-devel@lists.01.org
> Cc: Yao, Jiewen <jiewen.yao@intel.com>; Maurice; Ma, Maurice
> <maurice.ma@intel.com>; Chiu, Chasel <chasel.chiu@intel.com>
> Subject: [PATCH] IntelFsp2Pkg-Tools: Add FixedAtBuild PCD support in
> GenCfgOpt.py
> 
> Platform is eligible to use either PcdsFeatureFlag or
> PcdsFixedAtBuild for build configuration and requires
> GenCfgOpt.py support.
> 
> Cc: Jiewen Yao <Jiewen.yao@intel.com>
> Cc: Maurice, Ma <maurice.ma@intel.com>
> Contributed-under: TianoCore Contribution Agreement 1.0
> Signed-off-by: Chasel Chiu <chasel.chiu@intel.com>
> ---
>  IntelFsp2Pkg/Tools/GenCfgOpt.py | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/IntelFsp2Pkg/Tools/GenCfgOpt.py
> b/IntelFsp2Pkg/Tools/GenCfgOpt.py
> index 6dc1b10b34..64e0a3a985 100644
> --- a/IntelFsp2Pkg/Tools/GenCfgOpt.py
> +++ b/IntelFsp2Pkg/Tools/GenCfgOpt.py
> @@ -457,7 +457,7 @@ EndList
>                  IsUpdSect = False
>                  if  Match.group(1).lower() == "Defines".lower():
>                      IsDefSect = True
> -                if  Match.group(1).lower() == "PcdsFeatureFlag".lower():
> +                if  (Match.group(1).lower() == "PcdsFeatureFlag".lower() or
> Match.group(1).lower() == "PcdsFixedAtBuild".lower()):
>                      IsPcdSect = True
>                  elif Match.group(1).lower() ==
> "PcdsDynamicVpd.Upd".lower():
>                      ConfigDict = {}
> --
> 2.13.3.windows.1



^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2017-09-21  7:52 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-09-21  7:51 [PATCH] IntelFsp2Pkg-Tools: Add FixedAtBuild PCD support in GenCfgOpt.py Chasel, Chiu
2017-09-21  7:55 ` Yao, Jiewen

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox