From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wr0-x22f.google.com (mail-wr0-x22f.google.com [IPv6:2a00:1450:400c:c0c::22f]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 31A7821E1B747 for ; Thu, 21 Sep 2017 05:46:31 -0700 (PDT) Received: by mail-wr0-x22f.google.com with SMTP id o42so4483987wrb.3 for ; Thu, 21 Sep 2017 05:49:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=G1q4Ktet0Qr+2qF9yfrbCJVqlebSycDLmSufopKFaVs=; b=Qpn7vivQYyNyEQRfEC1jmw6f/D0i9FQ/SRIY5WLp8j++N7crH/FBXCluOtyWZ9ZTFG StTWXJcmWJZwAHlj6Q2BuQ6P6zjN2r7HgalGQk1Wlnyt62uJT6OZKcvOVC+GEkbWk5XA M+atjT8jsSw25XVIjJl37EEBJXmf6VFDmbkFU= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=G1q4Ktet0Qr+2qF9yfrbCJVqlebSycDLmSufopKFaVs=; b=tuRrYO4xipsaI1sEjaZByHpmybxqSbfPLU/eVDuSPuh6DJt0LMoi/zFYFOJHPvVlm7 V62YX2AwqPSGyB87xEnokAxl1ouuUcVw6dIL0K3dnICCGGN7s3ifN22Lbhxm5860/Dfc SLrjwr27DbOf8N+9NPVegdFbyqxOWzYO48GkPiqTCSj7EpCHdvi2+q14qM8/cjlvvMPV eAz+89qkNyKQ0RRQcd+6YppybHbci+yEhtPHnQXsVcP6Fqhf/OWDuLHBjpbeNjhe8bCy h6mD39/bmmzXvmTNZcepW78kMpTsrTE6UaYRU2su560yidS/iU2xL8yRf/q98lDtDoua N/xA== X-Gm-Message-State: AHPjjUgkYUxMnQDQA10f6hzkjg0TYovJrApdn/5cTmJjKSzLCmEC1a8X DevSvfpYWKfdI7DP8XV6T7bTMw== X-Google-Smtp-Source: AOwi7QCR57MHp19WGB8a6Th6hkKlEw9GCVx9S4nGJK3ySYDfrfc00sdlqv8Y//IaLgCnw0eWuTOUPw== X-Received: by 10.223.170.137 with SMTP id h9mr1840795wrc.91.1505998176745; Thu, 21 Sep 2017 05:49:36 -0700 (PDT) Received: from bivouac.eciton.net (bivouac.eciton.net. [2a00:1098:0:86:1000:23:0:2]) by smtp.gmail.com with ESMTPSA id o138sm1539148wmg.36.2017.09.21.05.49.35 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 21 Sep 2017 05:49:35 -0700 (PDT) Date: Thu, 21 Sep 2017 13:49:33 +0100 From: Leif Lindholm To: Heyi Guo Cc: linaro-uefi@lists.linaro.org, edk2-devel@lists.01.org, graeme.gregory@linaro.org, ard.biesheuvel@linaro.org, guoheyi@huawei.com, wanghuiqiang@huawei.com, huangming23@huawei.com, zhangjinsong2@huawei.com, waip23@126.com Message-ID: <20170921124933.72yjtrvqgazfvbjy@bivouac.eciton.net> References: <1505991597-52989-1-git-send-email-heyi.guo@linaro.org> <1505991597-52989-5-git-send-email-heyi.guo@linaro.org> MIME-Version: 1.0 In-Reply-To: <1505991597-52989-5-git-send-email-heyi.guo@linaro.org> User-Agent: NeoMutt/20170113 (1.7.2) Subject: Re: [PATCH edk2-non-osi v3 2/7] Hisilicon/D03/Sas: Add SasPlatform X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 21 Sep 2017 12:46:31 -0000 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Thu, Sep 21, 2017 at 06:59:43PM +0800, Heyi Guo wrote: > Install protocol to enable sas port which is using and > transmit base address info of sas port to SasDriverDxe. > > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Ming Huang On the whole, I'm OK with this - but: 1) This looks like a very simple piece of code, at a low risk to reveal anything confidential about Hisilicon IP. Can this be made open source? > --- > Platform/Hisilicon/D03/Drivers/SasPlatform/SasPlatform.efi | Bin 0 -> 3040 bytes > Platform/Hisilicon/D03/Drivers/SasPlatform/SasPlatform.inf | 24 ++++++++++++++++++++ > 2 files changed, 24 insertions(+) > > diff --git a/Platform/Hisilicon/D03/Drivers/SasPlatform/SasPlatform.efi b/Platform/Hisilicon/D03/Drivers/SasPlatform/SasPlatform.efi > new file mode 100644 > index 0000000..4255641 > Binary files /dev/null and b/Platform/Hisilicon/D03/Drivers/SasPlatform/SasPlatform.efi differ > diff --git a/Platform/Hisilicon/D03/Drivers/SasPlatform/SasPlatform.inf b/Platform/Hisilicon/D03/Drivers/SasPlatform/SasPlatform.inf > new file mode 100644 > index 0000000..636be19 > --- /dev/null > +++ b/Platform/Hisilicon/D03/Drivers/SasPlatform/SasPlatform.inf > @@ -0,0 +1,24 @@ > +#/** @file > +# > +# Copyright (c) 2017, Hisilicon Limited. All rights reserved. > +# Copyright (c) 2017, Linaro Limited. All rights reserved. > +# > +# This program and the accompanying materials > +# are licensed and made available under the terms and conditions of the BSD License > +# which accompanies this distribution. The full text of the license may be found at > +# http://opensource.org/licenses/bsd-license.php > +# > +# THE PROGRAM IS DISTRIBUTED UNDER THE BSD LICENSE ON AN "AS IS" BASIS, > +# WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER EXPRESS OR IMPLIED. > +# > +#**/ > + > +[Defines] > + INF_VERSION = 0x00010019 > + BASE_NAME = SasPlatform > + FILE_GUID = 102D8FC9-20a4-42EB-aC14-1C98BA5b26A4 > + MODULE_TYPE = DXE_DRIVER > + VERSION_STRING = 1.0 > + > +[Binaries] 2) [Binaries.AARCH64] > + PE32|SasPlatform.efi|* > -- > 1.9.1 >