From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-x234.google.com (mail-wm0-x234.google.com [IPv6:2a00:1450:400c:c09::234]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 5998F21E1B74B for ; Thu, 21 Sep 2017 05:48:56 -0700 (PDT) Received: by mail-wm0-x234.google.com with SMTP id r74so1512560wme.4 for ; Thu, 21 Sep 2017 05:52:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=yj2tC7txE+L5BB50CRcbsOHyeSLEnesK+ydKpyqf35Q=; b=RBo77lNcL7Aho5hWJ0AoFsrYlxCauTN8QVRaknIhMEwO9k7zRP6Cih5igkAh3Glk8Q bgsila+4ZdP8FHYMCO9NFnVRKyH3zNohVNnmt+xNn6jrV/noOUyBNWCJwB9hm/bQETGx yoHmvjJNOAX7dsgxaMayxQxvMneXT2TXxIK/E= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=yj2tC7txE+L5BB50CRcbsOHyeSLEnesK+ydKpyqf35Q=; b=bnk1tkOiBNeyUaZZASfXCHFY087UfLf8oemGoDwg2jYZz8t2wi7tO3dCBKTOqVkK7W EdLC60NyoGJ88sirIZaxx81SXmAICBnvXA61khuIoBup66UpYBDJeLMvSlCQFPfh8QSb tsvTnoT61nNgTUGkKRikG+Z02VxgNw8n4B6AcqjlbIVIRwdgUS5LIERw2nJXovr2OfR/ Xzh0qGFOPsPi0dFx5wh4TnTGYRvtadW5xNtDJnPOh3tmTjVAqzk4Ushf90tITHMztBf3 zQsz81WmU1v/YTvno6NDdXJf03r8Bw+FV7CO9gKCLdeX7H2emHp1gzTyJTKL91G6lIDF Mecw== X-Gm-Message-State: AHPjjUixKTNQhZhfabQbDwTq/m+xrtRFOcYNGJ9fPlnFaZcU5n8jTG6L ZW+rcqcOaqweSqjoqmG9aSRecQ== X-Google-Smtp-Source: AOwi7QAbHoq0lB9vgZpM9yCHp8imsBL2ItRB1dh0mGFePUVzZu0E/t93j/8qt5XUHlmRyC65lVi5oA== X-Received: by 10.28.113.28 with SMTP id m28mr835254wmc.141.1505998321814; Thu, 21 Sep 2017 05:52:01 -0700 (PDT) Received: from bivouac.eciton.net (bivouac.eciton.net. [2a00:1098:0:86:1000:23:0:2]) by smtp.gmail.com with ESMTPSA id o21sm1091929wrf.31.2017.09.21.05.51.59 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 21 Sep 2017 05:51:59 -0700 (PDT) Date: Thu, 21 Sep 2017 13:51:58 +0100 From: Leif Lindholm To: Heyi Guo Cc: linaro-uefi@lists.linaro.org, edk2-devel@lists.01.org, graeme.gregory@linaro.org, ard.biesheuvel@linaro.org, guoheyi@huawei.com, wanghuiqiang@huawei.com, huangming23@huawei.com, zhangjinsong2@huawei.com, waip23@126.com Message-ID: <20170921125158.jrpikuv7gxpka35u@bivouac.eciton.net> References: <1505991597-52989-1-git-send-email-heyi.guo@linaro.org> <1505991597-52989-2-git-send-email-heyi.guo@linaro.org> MIME-Version: 1.0 In-Reply-To: <1505991597-52989-2-git-send-email-heyi.guo@linaro.org> User-Agent: NeoMutt/20170113 (1.7.2) Subject: Re: [PATCH edk2-non-osi v3 1/7] Hisilicon/D03/Net: Update Snp driver X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 21 Sep 2017 12:48:56 -0000 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Thu, Sep 21, 2017 at 06:59:40PM +0800, Heyi Guo wrote: > 1. Replace SnpPV660Dxe with SnpPV600Dxe; > 2. Add SnpPlatform: > Install protocol to enable nic port which are using. OK, that sort of explains what it is doing. Let's discuss a bit more during Connect. Two comments below. > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Ming Huang > --- > Platform/Hisilicon/D03/Drivers/Net/SnpPV600Dxe/SnpPV600Dxe.efi | Bin 0 -> 26688 bytes > Platform/Hisilicon/D03/Drivers/Net/SnpPV600Dxe/SnpPV600Dxe.inf | 24 +++++++++++++++++ > Platform/Hisilicon/D03/Drivers/Net/SnpPV660Dxe/SnpPV600Dxe.efi | Bin 56832 -> 0 bytes > Platform/Hisilicon/D03/Drivers/Net/SnpPV660Dxe/SnpPV600Dxe.inf | 27 -------------------- > Platform/Hisilicon/D03/Drivers/Net/SnpPlatform/SnpPlatform.efi | Bin 0 -> 3040 bytes > Platform/Hisilicon/D03/Drivers/Net/SnpPlatform/SnpPlatform.inf | 24 +++++++++++++++++ This SnpPlatform.efi looks like a very simple piece of code. Could it be made open source? > 6 files changed, 48 insertions(+), 27 deletions(-) > > diff --git a/Platform/Hisilicon/D03/Drivers/Net/SnpPV600Dxe/SnpPV600Dxe.efi b/Platform/Hisilicon/D03/Drivers/Net/SnpPV600Dxe/SnpPV600Dxe.efi > new file mode 100644 > index 0000000..8ce6a6d > Binary files /dev/null and b/Platform/Hisilicon/D03/Drivers/Net/SnpPV600Dxe/SnpPV600Dxe.efi differ > diff --git a/Platform/Hisilicon/D03/Drivers/Net/SnpPV600Dxe/SnpPV600Dxe.inf b/Platform/Hisilicon/D03/Drivers/Net/SnpPV600Dxe/SnpPV600Dxe.inf > new file mode 100644 > index 0000000..cd7c724 > --- /dev/null > +++ b/Platform/Hisilicon/D03/Drivers/Net/SnpPV600Dxe/SnpPV600Dxe.inf > @@ -0,0 +1,24 @@ > +#/** @file > +# > +# Copyright (c) 2017, Hisilicon Limited. All rights reserved. > +# Copyright (c) 2017, Linaro Limited. All rights reserved. > +# > +# This program and the accompanying materials > +# are licensed and made available under the terms and conditions of the BSD License > +# which accompanies this distribution. The full text of the license may be found at > +# http://opensource.org/licenses/bsd-license.php > +# > +# THE PROGRAM IS DISTRIBUTED UNDER THE BSD LICENSE ON AN "AS IS" BASIS, > +# WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER EXPRESS OR IMPLIED. > +# > +#**/ > + > +[Defines] > + INF_VERSION = 0x00010019 > + BASE_NAME = SnpPV600Dxe > + FILE_GUID = 3247F15F-3612-4803-BD4E-4104D7EF944A > + MODULE_TYPE = DXE_DRIVER > + VERSION_STRING = 1.0 > + > +[Binaries] > + PE32|SnpPV600Dxe.efi|* > diff --git a/Platform/Hisilicon/D03/Drivers/Net/SnpPV660Dxe/SnpPV600Dxe.efi b/Platform/Hisilicon/D03/Drivers/Net/SnpPV660Dxe/SnpPV600Dxe.efi > deleted file mode 100644 > index eb69403..0000000 > Binary files a/Platform/Hisilicon/D03/Drivers/Net/SnpPV660Dxe/SnpPV600Dxe.efi and /dev/null differ > diff --git a/Platform/Hisilicon/D03/Drivers/Net/SnpPV660Dxe/SnpPV600Dxe.inf b/Platform/Hisilicon/D03/Drivers/Net/SnpPV660Dxe/SnpPV600Dxe.inf > deleted file mode 100644 > index 204ef17..0000000 > --- a/Platform/Hisilicon/D03/Drivers/Net/SnpPV660Dxe/SnpPV600Dxe.inf > +++ /dev/null > @@ -1,27 +0,0 @@ > -#/** @file > -# > -# Copyright (c) 2016, Hisilicon Limited. All rights reserved. > -# Copyright (c) 2016-2017, Linaro Limited. All rights reserved. > -# > -# This program and the accompanying materials > -# are licensed and made available under the terms and conditions of the BSD License > -# which accompanies this distribution. The full text of the license may be found at > -# http://opensource.org/licenses/bsd-license.php > -# > -# THE PROGRAM IS DISTRIBUTED UNDER THE BSD LICENSE ON AN "AS IS" BASIS, > -# WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER EXPRESS OR IMPLIED. > -# > -#**/ > - > -[Defines] > - INF_VERSION = 0x00010005 > - BASE_NAME = SnpPV600Dxe > - FILE_GUID = 92D37768-571C-48d9-BEF5-9744AE2FDAF4 > - MODULE_TYPE = UEFI_DRIVER > - VERSION_STRING = 1.0 > - > - ENTRY_POINT = InitializeSnpPV600Driver > - UNLOAD_IMAGE = SnpPV600Unload > - > -[Binaries] > - PE32|SnpPV600Dxe.efi|* > diff --git a/Platform/Hisilicon/D03/Drivers/Net/SnpPlatform/SnpPlatform.efi b/Platform/Hisilicon/D03/Drivers/Net/SnpPlatform/SnpPlatform.efi > new file mode 100644 > index 0000000..5e7d8bd > Binary files /dev/null and b/Platform/Hisilicon/D03/Drivers/Net/SnpPlatform/SnpPlatform.efi differ > diff --git a/Platform/Hisilicon/D03/Drivers/Net/SnpPlatform/SnpPlatform.inf b/Platform/Hisilicon/D03/Drivers/Net/SnpPlatform/SnpPlatform.inf > new file mode 100644 > index 0000000..fd53a79 > --- /dev/null > +++ b/Platform/Hisilicon/D03/Drivers/Net/SnpPlatform/SnpPlatform.inf > @@ -0,0 +1,24 @@ > +#/** @file > +# > +# Copyright (c) 2017, Hisilicon Limited. All rights reserved. > +# Copyright (c) 2017, Linaro Limited. All rights reserved. > +# > +# This program and the accompanying materials > +# are licensed and made available under the terms and conditions of the BSD License > +# which accompanies this distribution. The full text of the license may be found at > +# http://opensource.org/licenses/bsd-license.php > +# > +# THE PROGRAM IS DISTRIBUTED UNDER THE BSD LICENSE ON AN "AS IS" BASIS, > +# WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER EXPRESS OR IMPLIED. > +# > +#**/ > + > +[Defines] > + INF_VERSION = 0x00010019 > + BASE_NAME = SnpPlatform > + FILE_GUID = 102D8FC9-20A4-42EB-AC14-1C98BA5B17A8 > + MODULE_TYPE = DXE_DRIVER > + VERSION_STRING = 1.0 > + > +[Binaries] [Binaries.AARCH64] / Leif > + PE32|SnpPlatform.efi|* > -- > 1.9.1 >