Re: [PATCH edk2-platforms v3 02/11] Hisilicon/D03: Modify dsc and fdf file

[Leif Lindholm <leif.lindholm@linaro.org>]

On Thu, Sep 21, 2017 at 06:59:42PM +0800, Heyi Guo wrote:
> 1. Add Drivers/SasPlatform;
> 2. Add Drivers/Net/SnpPlatform;
> 
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Ming Huang <huangming23@huawei.com>
> ---
>  Platform/Hisilicon/D03/D03.dsc | 5 -----
>  Platform/Hisilicon/D03/D03.fdf | 5 ++++-
>  2 files changed, 4 insertions(+), 6 deletions(-)
> 
> diff --git a/Platform/Hisilicon/D03/D03.dsc b/Platform/Hisilicon/D03/D03.dsc
> index afea162..7e25ffb 100644
> --- a/Platform/Hisilicon/D03/D03.dsc
> +++ b/Platform/Hisilicon/D03/D03.dsc
> @@ -418,11 +418,6 @@
>  
>    Platform/Hisilicon/D03/Drivers/Ipmi/ipmiInterfaceDxe/IpmiInterfaceDxe.inf
>  
> -  #
> -  #network
> -  #
> -  Platform/Hisilicon/D03/Drivers/Net/SnpPV660Dxe/SnpPV600Dxe.inf
> -
>    MdeModulePkg/Universal/Network/ArpDxe/ArpDxe.inf
>    MdeModulePkg/Universal/Network/Dhcp4Dxe/Dhcp4Dxe.inf
>    MdeModulePkg/Universal/Network/DpcDxe/DpcDxe.inf
> diff --git a/Platform/Hisilicon/D03/D03.fdf b/Platform/Hisilicon/D03/D03.fdf
> index b62b908..b53bdca 100644
> --- a/Platform/Hisilicon/D03/D03.fdf
> +++ b/Platform/Hisilicon/D03/D03.fdf
> @@ -242,7 +242,8 @@ READ_LOCK_STATUS   = TRUE
>    #Network
>    #
>  
> -  INF Platform/Hisilicon/D03/Drivers/Net/SnpPV660Dxe/SnpPV600Dxe.inf
> +  INF Platform/Hisilicon/D03/Drivers/Net/SnpPlatform/SnpPlatform.inf
> +  INF Platform/Hisilicon/D03/Drivers/Net/SnpPV600Dxe/SnpPV600Dxe.inf
>  
>    INF MdeModulePkg/Universal/Network/ArpDxe/ArpDxe.inf
>    INF MdeModulePkg/Universal/Network/Dhcp4Dxe/Dhcp4Dxe.inf
> @@ -271,6 +272,7 @@ READ_LOCK_STATUS   = TRUE
>    #
>    INF Platform/Hisilicon/D03/Drivers/Sm750Dxe/UefiSmi.inf
>  
> +  INF Platform/Hisilicon/D03/Drivers/SasPlatform/SasPlatform.inf
>    INF Platform/Hisilicon/D03/Drivers/Sas/SasDxeDriver.inf
>  
>    #
> @@ -278,6 +280,7 @@ READ_LOCK_STATUS   = TRUE
>    #
>    INF ShellPkg/Application/Shell/Shell.inf
>  
> +

This spurious whitespace change is still here. Please delete for v4.
Other than that, the patch is fine.

/
    Leif

>    #
>    # Bds
>    #
> -- 
> 1.9.1
>