From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-x230.google.com (mail-wm0-x230.google.com [IPv6:2a00:1450:400c:c09::230]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 66FBE21E1B74A for ; Thu, 21 Sep 2017 06:04:50 -0700 (PDT) Received: by mail-wm0-x230.google.com with SMTP id r136so1677625wmf.2 for ; Thu, 21 Sep 2017 06:07:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=v39lnpnkBI8mMegc00wYsya2l/uvGSpF8QKDAC2RCk8=; b=FQ2jr3UHbBWMJi/uu8qrR7clOuqGyeSskjuueRMMDZKqOomcAn76nyVvWSd/MNwGjp mg6W0SAbPYDasq1j89IeZ8yQ3rkEsCCsMyjTBRgsNPl/kHk4iizh6BK4CJZ+te5v0oA8 2ojfQRHaJnnpv8HRGlUt3vaSX/Nm+C6m8oEwg= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=v39lnpnkBI8mMegc00wYsya2l/uvGSpF8QKDAC2RCk8=; b=YMgliTfYzT6WOxw0xw3DqPgEprGLWLjJKL405OEFhn3BFqzlMsPG0bD5h9ybZzZ/60 ZrDZf9jyLQxg9bIUC14rn5bYvEYMQrF1qbi8XYqi8QbBeYJyWgxXu5jlesFwAmLsEriS F4VnkurBnmAlmAejbZkd5FDFpjNBIg8bzhwOnY0SRQ3ouKz1PxbuHO221YVkO7QrM0WR 3FJtDi9Li3umzs8lwDD8b2SGP8gEtM+H0jUL0+QHJuWuntk3VC231DL7E6hIHIFyO4GG mAupjazV0Y8qZwgynyTQo4u+ocFrcpGp2PY3XWEZl9vm7pMsCeSGpiSCYY2dHVKHwwQP 0XiA== X-Gm-Message-State: AHPjjUgIntKG1Z83pOl0wvc4nIPDtMDNrE/i8RUw782yIBBiW3xPK86Z i4ZH0F56sYNY/WNtMvV/2WCxZw== X-Google-Smtp-Source: AOwi7QDQ+OnLuK5tyujrBzhY12EKkUZmoZ6wlutAgPPDBKCiXfy+98LTY1rTADgrckopKK+N2QnG4Q== X-Received: by 10.28.10.145 with SMTP id 139mr1047153wmk.5.1505999275998; Thu, 21 Sep 2017 06:07:55 -0700 (PDT) Received: from bivouac.eciton.net (bivouac.eciton.net. [2a00:1098:0:86:1000:23:0:2]) by smtp.gmail.com with ESMTPSA id t15sm1180921wrb.41.2017.09.21.06.07.54 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 21 Sep 2017 06:07:54 -0700 (PDT) Date: Thu, 21 Sep 2017 14:07:53 +0100 From: Leif Lindholm To: Heyi Guo Cc: linaro-uefi@lists.linaro.org, edk2-devel@lists.01.org, graeme.gregory@linaro.org, ard.biesheuvel@linaro.org, guoheyi@huawei.com, wanghuiqiang@huawei.com, huangming23@huawei.com, zhangjinsong2@huawei.com, waip23@126.com, Chenhui Sun Message-ID: <20170921130753.i4zryrhrkrvnawvo@bivouac.eciton.net> References: <1505991597-52989-1-git-send-email-heyi.guo@linaro.org> <1505991597-52989-16-git-send-email-heyi.guo@linaro.org> MIME-Version: 1.0 In-Reply-To: <1505991597-52989-16-git-send-email-heyi.guo@linaro.org> User-Agent: NeoMutt/20170113 (1.7.2) Subject: Re: [PATCH edk2-platforms v3 08/11] Hisilicon/D03: Disable the function of PerfTuning X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 21 Sep 2017 13:04:50 -0000 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Thu, Sep 21, 2017 at 06:59:54PM +0800, Heyi Guo wrote: > From: Chenhui Sun > > The PerTuning function is not stable, it will cause the > 3008/3108 crash, disable this function first. > > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Chenhui Sun I do not see any of my comments from previous revision addressed, and I received no reply. Feedback was: --- Should this not also delete the PciPerfTuning() function from PcieInitLib.c, and the declaration of gHisiTokenSpaceGuid.PcdIsPciPerfTuningEnable from HisiPkg.dec? --- / Leif > --- > Platform/Hisilicon/D03/D03.dsc | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/Platform/Hisilicon/D03/D03.dsc b/Platform/Hisilicon/D03/D03.dsc > index fca6781..ac880d9 100644 > --- a/Platform/Hisilicon/D03/D03.dsc > +++ b/Platform/Hisilicon/D03/D03.dsc > @@ -112,7 +112,7 @@ > # It could be set FALSE to save size. > gEfiMdeModulePkgTokenSpaceGuid.PcdConOutGopSupport|TRUE > gHisiTokenSpaceGuid.PcdIsItsSupported|TRUE > - gHisiTokenSpaceGuid.PcdIsPciPerfTuningEnable|TRUE > + gHisiTokenSpaceGuid.PcdIsPciPerfTuningEnable|FALSE > > [PcdsFixedAtBuild.common] > gEmbeddedTokenSpaceGuid.PcdEmbeddedPrompt|"D03" > -- > 1.9.1 >