From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wr0-x22d.google.com (mail-wr0-x22d.google.com [IPv6:2a00:1450:400c:c0c::22d]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 6AA0B20945B64 for ; Thu, 21 Sep 2017 06:08:46 -0700 (PDT) Received: by mail-wr0-x22d.google.com with SMTP id k20so4539186wre.4 for ; Thu, 21 Sep 2017 06:11:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=mF6lpUzTWr7m1Ecw06tXbsB2kaPY0tgsKwlWoDrTrb0=; b=j3RBQsxpu8xnunGz3/7PN3c+GI190D8CNxBa4ho//kqkXGXtmulwlL14e5PXzwT9dB eBTNHHX9baT0b1piNWylKlqLPa9pzWXuMLGIUlwJS30fN9bj/wk+TkVXrGR+UM3Ih/Bd wHGVZn+AFdfeY3+5IAp8NVIVaQAsgzvYoIyms= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=mF6lpUzTWr7m1Ecw06tXbsB2kaPY0tgsKwlWoDrTrb0=; b=NGX7lQQu1wInJlQGPMNNdqD3RmLCCeeIPo+pqgPaqRGAIh/PMZ/YIIu+eR3Uk0aD2J mZk3sJ+I1bQalXVoUPfjLXq8mK12cYzAwr4/SFwuAiB9wENeWMWmxcr6wci6+zqJ4NZb bF7UzU37nIGShVgmRcaofUnN8iv/0COjSuAbXnPiTtqCw/5lpftiJOo+qP+D6ShS6ja0 qZ43TjTqm55Jr3h1Fi4hoqycHvQnMDnRul3AzvSLaS5dccCUsfEokC/JcDmtpeUQrxEd Ppact3ak8UGVPUyzvps/hhbSYtnT2Q04OBPmUlsPS4lKH7ub64PjGxZDNmJK+WlXUARv etcQ== X-Gm-Message-State: AHPjjUjdkgmzHRjKrM+863PHrDbouFfXtJYFXzjozPRqH0Q/g+mYI8sd bb98elTOIgflwge1iAXD4smpxw== X-Google-Smtp-Source: AOwi7QC4owbD2h7cs3Tef3Jw6kutt+QQoFrolAMNhgY3kl8v6sOWb2QPnFYis1zDqgLRiAm2SBUKYg== X-Received: by 10.223.156.129 with SMTP id d1mr2058698wre.166.1505999512003; Thu, 21 Sep 2017 06:11:52 -0700 (PDT) Received: from bivouac.eciton.net (bivouac.eciton.net. [2a00:1098:0:86:1000:23:0:2]) by smtp.gmail.com with ESMTPSA id u33sm1601974wrc.91.2017.09.21.06.11.50 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 21 Sep 2017 06:11:50 -0700 (PDT) Date: Thu, 21 Sep 2017 14:11:49 +0100 From: Leif Lindholm To: Heyi Guo Cc: linaro-uefi@lists.linaro.org, edk2-devel@lists.01.org, graeme.gregory@linaro.org, ard.biesheuvel@linaro.org, guoheyi@huawei.com, wanghuiqiang@huawei.com, huangming23@huawei.com, zhangjinsong2@huawei.com, waip23@126.com, Ming Huang Message-ID: <20170921131149.agfl765b57zosh7s@bivouac.eciton.net> References: <1505991597-52989-1-git-send-email-heyi.guo@linaro.org> <1505991597-52989-17-git-send-email-heyi.guo@linaro.org> MIME-Version: 1.0 In-Reply-To: <1505991597-52989-17-git-send-email-heyi.guo@linaro.org> User-Agent: NeoMutt/20170113 (1.7.2) Subject: Re: [PATCH edk2-platforms v3 09/11] D05/ACPI: Disable D05 SAS0 and SAS2 X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 21 Sep 2017 13:08:46 -0000 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Thu, Sep 21, 2017 at 06:59:55PM +0800, Heyi Guo wrote: > From: Ming Huang Can you ensure all "From: " tags use the proper huawei.com addresses? Signed-off-by below is already correct. Also, since you are sending these patches out, you should also add your "Signed-off-by:" below that of the patch author. (Please double check this on other patches where I have missed it.) Apart from that, this patch is fine. / Leif > > There are no interface from SAS0 and SAS2 controller on D05, > so SAS0 and SAS2 can't be use. > > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Ming Huang > --- > Silicon/Hisilicon/Hi1616/D05AcpiTables/Dsdt/D05Sas.asl | 10 ++++++++++ > 1 file changed, 10 insertions(+) > > diff --git a/Silicon/Hisilicon/Hi1616/D05AcpiTables/Dsdt/D05Sas.asl b/Silicon/Hisilicon/Hi1616/D05AcpiTables/Dsdt/D05Sas.asl > index 93beb95..6455130 100644 > --- a/Silicon/Hisilicon/Hi1616/D05AcpiTables/Dsdt/D05Sas.asl > +++ b/Silicon/Hisilicon/Hi1616/D05AcpiTables/Dsdt/D05Sas.asl > @@ -88,6 +88,11 @@ Scope(_SB) > Store(0x7ffff, CLK) > Sleep(1) > } > + > + Method (_STA, 0, NotSerialized) > + { > + Return (0x0) > + } > } > > Device(SAS1) { > @@ -239,6 +244,11 @@ Scope(_SB) > Store(0x7ffff, CLK) > Sleep(1) > } > + > + Method (_STA, 0, NotSerialized) > + { > + Return (0x0) > + } > } > > } > -- > 1.9.1 >