From: Leif Lindholm <leif.lindholm@linaro.org>
To: evan.lloyd@arm.com
Cc: edk2-devel@lists.01.org,
Ard Biesheuvel <ard.biesheuvel@linaro.org>,
Matteo Carlini <Matteo.Carlini@arm.com>,
nd@arm.com, Arvind Chauhan <Arvind.Chauhan@arm.com>,
Daniil Egranov <Daniil.Egranov@arm.com>,
Thomas Panakamattam Abraham <thomas.abraham@arm.com>
Subject: Re: [PATCH 0/4] [PATCH 0/5] Add HardwareInterrupt2 for ARM
Date: Thu, 21 Sep 2017 18:56:02 +0100 [thread overview]
Message-ID: <20170921175602.2rjg3osgzll5dlhr@bivouac.eciton.net> (raw)
In-Reply-To: <20170921162345.11724-1-evan.lloyd@arm.com>
On Thu, Sep 21, 2017 at 05:23:40PM +0100, evan.lloyd@arm.com wrote:
> From: EvanLloyd <evan.lloyd@arm.com>
>
> This v4 series of patches corrects a problem detected on the ARM Juno
> platform that is actually generic (at least to ARM GIC platforms).
> The HardwareInterrupt protocol had no means of handling characteristics
> like Edge/Level triggered and polarity.
>
> A new HardwareInterrupt2 protocol (provided by Ard) is added, and code
> changed to utilise the new capabilities.
>
> The code is available for examination on Github at:
> https://github.com/EvanLloyd/tianocore/tree/376_irqtype_v4
>
> v4 responds to further comments from maintainers, being mainly
> cosmetic changes.
>
> Note: Significant defects exist in the (original) Watchdog handling,
> and a new patch will follow.
If you let me move that | before pushing, I'm happy with this set.
Arvind, Daniil, Thomas - any comments?
/
Leif
> Ard Biesheuvel (3):
> EmbeddedPkg: Introduce HardwareInterrupt2 protocol
> ArmPkg/ArmGicDxe: Expose HardwareInterrupt2 protocol
> ArmPkg/GenericWatchdogDxe: Set Watchdog interrupt type
>
> Evan Lloyd (1):
> ArmPkg: Tidy GIC code before changes.
>
> EmbeddedPkg/EmbeddedPkg.dec | 1 +
> ArmPkg/Drivers/ArmGic/ArmGicDxe.inf | 3 +-
> ArmPkg/Drivers/GenericWatchdogDxe/GenericWatchdogDxe.inf | 6 +-
> ArmPkg/Drivers/ArmGic/ArmGicDxe.h | 31 ++-
> ArmPkg/Include/Library/ArmGicLib.h | 34 +--
> EmbeddedPkg/Include/Protocol/HardwareInterrupt2.h | 182 ++++++++++++++++
> ArmPkg/Drivers/ArmGic/ArmGicCommonDxe.c | 76 +++++--
> ArmPkg/Drivers/ArmGic/ArmGicLib.c | 73 +++++--
> ArmPkg/Drivers/ArmGic/GicV2/ArmGicV2Dxe.c | 195 ++++++++++++++---
> ArmPkg/Drivers/ArmGic/GicV3/ArmGicV3Dxe.c | 218 +++++++++++++++++---
> ArmPkg/Drivers/GenericWatchdogDxe/GenericWatchdogDxe.c | 146 +++++++------
> 11 files changed, 779 insertions(+), 186 deletions(-)
> create mode 100644 EmbeddedPkg/Include/Protocol/HardwareInterrupt2.h
>
> --
> Guid("CE165669-3EF3-493F-B85D-6190EE5B9759")
>
next prev parent reply other threads:[~2017-09-21 17:52 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-21 16:23 [PATCH 0/4] [PATCH 0/5] Add HardwareInterrupt2 for ARM evan.lloyd
2017-09-21 16:23 ` [PATCH 1/4] ArmPkg: Tidy GIC code before changes evan.lloyd
2017-09-21 16:23 ` [PATCH 2/4] EmbeddedPkg: Introduce HardwareInterrupt2 protocol evan.lloyd
2017-09-21 16:23 ` [PATCH 3/4] ArmPkg/ArmGicDxe: Expose " evan.lloyd
2017-10-05 20:15 ` Leif Lindholm
2017-10-05 20:15 ` Ard Biesheuvel
2017-10-05 20:25 ` Leif Lindholm
2017-09-21 16:23 ` [PATCH 4/4] ArmPkg/GenericWatchdogDxe: Set Watchdog interrupt type evan.lloyd
2017-09-21 17:56 ` Leif Lindholm [this message]
2017-09-21 18:39 ` [PATCH 0/4] [PATCH 0/5] Add HardwareInterrupt2 for ARM Evan Lloyd
2017-09-21 19:15 ` Andrew Fish
2017-09-21 20:53 ` Evan Lloyd
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170921175602.2rjg3osgzll5dlhr@bivouac.eciton.net \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox