From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-x22b.google.com (mail-wm0-x22b.google.com [IPv6:2a00:1450:400c:c09::22b]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id E974220945B83 for ; Thu, 21 Sep 2017 10:52:59 -0700 (PDT) Received: by mail-wm0-x22b.google.com with SMTP id q124so4065871wmb.0 for ; Thu, 21 Sep 2017 10:56:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=DSjialnv97CrAuJdSuGHuhUKPLMDyD6nhA5AgL3mHYc=; b=Gwn2voZt/aN02+Wnt0suukudd0AprTHzGZm/O6/PCdaWPhuy9ybJdid60W7FWdLXrm OmRNF9zUQ0dPEs8ho/Z8CWzhsvkSS7SmSTwwby7JIfCWiARwXXYy7R16fVGXyn0DLw0S QaRm2qW1NisYNOviOZZqJ+l5BzQP1xuL2fq1M= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=DSjialnv97CrAuJdSuGHuhUKPLMDyD6nhA5AgL3mHYc=; b=i2tIaTOagm1OkZGyTnn0WYHmyZEAgCu1MlDd2Qa5jKwhesAT0GGNm2Hw4AjVQL/fIR JEGIxl1PBJQAuwkwuw+7fHhZ8jEvVIT82ispPqii3geKz5SLhbzAr45TjfVhyGEJYUJ0 qYcoPbkFCxgoKuROkerPHVN7hyHZt9wG+MC5eyzDxcHNmDCOrliJ10fgedzIMW58eBO0 ZdpyKi2iFJ/Z6HdhhEGaqla3TaBQXUBEdw+Hjm6GxNmO/pHXImBJf6iev6zH9gQmNHvQ R48r52yBw7Z4IUtpIBEn+87oUDQJpR/hPhMHFuWeat9oY22Ruar+PQ1y/35Iaooe/Htj ooAA== X-Gm-Message-State: AHPjjUi2RhOuFWay3N12hzZjcve3nZ16l8QxgH/EhY4vmnj3cufVz9R3 OaOmsSrt03r7UhI7EoZ6i8ubOHkqpyA= X-Google-Smtp-Source: AOwi7QBTd25E0Lka+SYA3KrleT3yRKbxHWkM4XaRa+tQdIG+diTz0acEodsoAh413JKGSTF3C+GZiQ== X-Received: by 10.28.23.76 with SMTP id 73mr1927602wmx.70.1506016565620; Thu, 21 Sep 2017 10:56:05 -0700 (PDT) Received: from bivouac.eciton.net (bivouac.eciton.net. [2a00:1098:0:86:1000:23:0:2]) by smtp.gmail.com with ESMTPSA id z108sm2551037wrc.49.2017.09.21.10.56.04 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 21 Sep 2017 10:56:04 -0700 (PDT) Date: Thu, 21 Sep 2017 18:56:02 +0100 From: Leif Lindholm To: evan.lloyd@arm.com Cc: edk2-devel@lists.01.org, Ard Biesheuvel , Matteo Carlini , nd@arm.com, Arvind Chauhan , Daniil Egranov , Thomas Panakamattam Abraham Message-ID: <20170921175602.2rjg3osgzll5dlhr@bivouac.eciton.net> References: <20170921162345.11724-1-evan.lloyd@arm.com> MIME-Version: 1.0 In-Reply-To: <20170921162345.11724-1-evan.lloyd@arm.com> User-Agent: NeoMutt/20170113 (1.7.2) Subject: Re: [PATCH 0/4] [PATCH 0/5] Add HardwareInterrupt2 for ARM X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 21 Sep 2017 17:53:00 -0000 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Thu, Sep 21, 2017 at 05:23:40PM +0100, evan.lloyd@arm.com wrote: > From: EvanLloyd > > This v4 series of patches corrects a problem detected on the ARM Juno > platform that is actually generic (at least to ARM GIC platforms). > The HardwareInterrupt protocol had no means of handling characteristics > like Edge/Level triggered and polarity. > > A new HardwareInterrupt2 protocol (provided by Ard) is added, and code > changed to utilise the new capabilities. > > The code is available for examination on Github at: > https://github.com/EvanLloyd/tianocore/tree/376_irqtype_v4 > > v4 responds to further comments from maintainers, being mainly > cosmetic changes. > > Note: Significant defects exist in the (original) Watchdog handling, > and a new patch will follow. If you let me move that | before pushing, I'm happy with this set. Arvind, Daniil, Thomas - any comments? / Leif > Ard Biesheuvel (3): > EmbeddedPkg: Introduce HardwareInterrupt2 protocol > ArmPkg/ArmGicDxe: Expose HardwareInterrupt2 protocol > ArmPkg/GenericWatchdogDxe: Set Watchdog interrupt type > > Evan Lloyd (1): > ArmPkg: Tidy GIC code before changes. > > EmbeddedPkg/EmbeddedPkg.dec | 1 + > ArmPkg/Drivers/ArmGic/ArmGicDxe.inf | 3 +- > ArmPkg/Drivers/GenericWatchdogDxe/GenericWatchdogDxe.inf | 6 +- > ArmPkg/Drivers/ArmGic/ArmGicDxe.h | 31 ++- > ArmPkg/Include/Library/ArmGicLib.h | 34 +-- > EmbeddedPkg/Include/Protocol/HardwareInterrupt2.h | 182 ++++++++++++++++ > ArmPkg/Drivers/ArmGic/ArmGicCommonDxe.c | 76 +++++-- > ArmPkg/Drivers/ArmGic/ArmGicLib.c | 73 +++++-- > ArmPkg/Drivers/ArmGic/GicV2/ArmGicV2Dxe.c | 195 ++++++++++++++--- > ArmPkg/Drivers/ArmGic/GicV3/ArmGicV3Dxe.c | 218 +++++++++++++++++--- > ArmPkg/Drivers/GenericWatchdogDxe/GenericWatchdogDxe.c | 146 +++++++------ > 11 files changed, 779 insertions(+), 186 deletions(-) > create mode 100644 EmbeddedPkg/Include/Protocol/HardwareInterrupt2.h > > -- > Guid("CE165669-3EF3-493F-B85D-6190EE5B9759") >