Re: 答复: [PATCH edk2-non-osi v3 6/7] Hisilicon/D05: Update binary file

[Leif Lindholm <leif.lindholm@linaro.org>]

On Fri, Sep 22, 2017 at 09:36:48AM +0000, Huangming (Mark) wrote:
> See below reply please
> 
> -----邮件原件-----
> 发件人: Leif Lindholm [mailto:leif.lindholm@linaro.org] 
> 发送时间: 2017年9月21日 21:00
> 收件人: Heyi Guo <heyi.guo@linaro.org>
> 抄送: linaro-uefi@lists.linaro.org; edk2-devel@lists.01.org; graeme.gregory@linaro.org; ard.biesheuvel@linaro.org; Guoheyi <guoheyi@huawei.com>; wanghuiqiang <wanghuiqiang@huawei.com>; Huangming (Mark) <huangming23@huawei.com>; zhangjinsong (A) <zhangjinsong2@huawei.com>; waip23@126.com
> 主题: Re: [PATCH edk2-non-osi v3 6/7] Hisilicon/D05: Update binary file
> 
> On Thu, Sep 21, 2017 at 06:59:51PM +0800, Heyi Guo wrote:
> > Fix bug 3061: D05(before EC) boot hangs at "Need Reset";
> > 
> > Update binary file for edk2 upgrade.
> >   1. Replace UncachedMemoryAllocationLib with DmaLib;
> >   2. Remove ArmCpuLib dependenc;
> >   3. Remove ConvertToPhysicalAddress;
> > 
> > Contributed-under: TianoCore Contribution Agreement 1.1
> > Signed-off-by: Ming Huang <huangming23@huawei.com>
> > ---
> >  Platform/Hisilicon/D05/Drivers/GetInfoFromBmc/GetInfoFromBmc.efi                       | Bin 19552 -> 5024 bytes
> >  Platform/Hisilicon/D05/Drivers/Ipmi/IpmiInterfaceDxe/IpmiInterfaceDxe.efi              | Bin 25696 -> 7680 bytes
> >  Platform/Hisilicon/D05/Drivers/Ipmi/IpmiInterfacePei/IpmiInterfacePei.efi              | Bin 22528 -> 5344 bytes
> >  Platform/Hisilicon/D05/Drivers/IpmiMiscOpDxe/IpmiMiscOp.efi                            | Bin 23136 -> 5280 bytes
> >  Platform/Hisilicon/D05/Drivers/IpmiWatchdogDxe/IpmiWatchdogDxe.efi                     | Bin 15968 -> 2592 bytes
> >  Platform/Hisilicon/D05/Drivers/OhciDxe/NativeOhci.efi                                  | Bin 48000 -> 23328 bytes
> >  Platform/Hisilicon/D05/Drivers/ReportPciePlugDidVidToBmc/ReportPciePlugDidVidToBmc.efi | Bin 21536 -> 4032 bytes
> >  Platform/Hisilicon/D05/Drivers/SFC/SFCDriver.efi                                       | Bin 262144 -> 262144 bytes
> >  Platform/Hisilicon/D05/Drivers/Sas/SasDriverDxe.efi                                    | Bin 230912 -> 116288 bytes
> >  Platform/Hisilicon/D05/Drivers/Sm750Dxe/SmiGraphicsOutput.efi                          | Bin 35904 -> 18592 bytes
> >  Platform/Hisilicon/D05/Drivers/TransferSmbiosInfo/TransSmbiosInfo.efi                  | Bin 16576 -> 4288 bytes
> >  Platform/Hisilicon/D05/Library/OemAddressMapD05/OemAddressMapD05.lib                   | Bin 42136 -> 52968 bytes
> >  Platform/Hisilicon/D05/MemoryInitPei/MemoryInit.efi                                    | Bin 273312 -> 152576 bytes
> 
> >  Platform/Hisilicon/D05/Sec/FVMAIN_SEC.Fv                                               | Bin 262144 -> 262144 bytes
> >  Platform/Hisilicon/D05/bl1.bin                                                         | Bin 12296 -> 14344 bytes
> >  Platform/Hisilicon/D05/fip.bin                                                         | Bin 41493 -> 41493 bytes
> 
> Like for D03 - I guess this means ARM Trusted Firmware update. Can it be a separate patch and describe the commit hash it was produced from?
> -- FVMAIN_SEC.Fv use some edk2 lib, so it is related with edk2 update.
> I will make sepatate patch for Other two bin files.

Understood. Yes, please do so.

> Do you mean that I should add commitId in the separate patch ? like "126aef8"?

Yes, please.

> Does the (bugs.linaro.org) 3061 fix also belong to these files?
> -- Yes

OK, then please delete that note from commit message in this patch and
add it in the new one. Please include the full URL to the bug.

Regards,

Leif