public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: Hao Wu <hao.a.wu@intel.com>
To: edk2-devel@lists.01.org
Cc: Hao Wu <hao.a.wu@intel.com>, Steven Shi <steven.shi@intel.com>,
	Michael Kinney <michael.d.kinney@intel.com>,
	Liming Gao <liming.gao@intel.com>,
	Star Zeng <star.zeng@intel.com>, Eric Dong <eric.dong@intel.com>,
	Fu Siyuan <siyuan.fu@intel.com>, Ye Ting <ting.ye@intel.com>,
	Wu Jiaxin <jiaxin.wu@intel.com>, Qin Long <qin.long@intel.com>,
	Paolo Bonzini <pbonzini@redhat.com>
Subject: [PATCH v3 0/5] Resolve undefined behaviours in left shift OPs
Date: Thu, 28 Sep 2017 12:32:08 +0800	[thread overview]
Message-ID: <20170928043213.20776-1-hao.a.wu@intel.com> (raw)

Based on the feedbacks from Liming, the V3 series drops the patch for
MdeModulePkg/Crc32. Since the left shift operation "1 << Index" will be
removed by an under-reviewing patch series:

[Patch 0/2] Add CalculateCrc32() API in MdePkg BaseLib


V2 history:
According to the feebacks from Paolo, the following changes are made in
this version of patch series:
  a. Refine the code logic in Tpl.c to void left shifting the negative
     value. Also makes the code more readable;
  b. Remove the '~' operator before 'Time.Hour' in DxeNetLib.c, since it
     seems like an implementation choice for generating the seed;
  c. Use '1U' instead of '(UINT32)1' in Crc32.c.


V1 history:
The series resolves two kinds of undefined behaviours in left shift
operations:
  a. Left-shifting negative values;
  b. Left-shifting that incurs the result being out of range.

Cc: Steven Shi <steven.shi@intel.com>
Cc: Michael Kinney <michael.d.kinney@intel.com>
Cc: Liming Gao <liming.gao@intel.com>
Cc: Star Zeng <star.zeng@intel.com>
Cc: Eric Dong <eric.dong@intel.com>
Cc: Fu Siyuan <siyuan.fu@intel.com>
Cc: Ye Ting <ting.ye@intel.com>
Cc: Wu Jiaxin <jiaxin.wu@intel.com>
Cc: Qin Long <qin.long@intel.com>
Cc: Paolo Bonzini <pbonzini@redhat.com> 


Hao Wu (5):
  MdePkg/PrintLib: Fix possible negative value left shift
  MdeModulePkg/PrintLib: Fix possible negative value left shift
  MdeModulePkg/Tpl: Fix negative value left shift
  MdeModulePkg/DxeNetLib: Fix negative value left shift
  MdeModulePkg/AtaAtapiPassThru: Fix possible out of range left shift

 MdeModulePkg/Bus/Ata/AtaAtapiPassThru/AhciMode.c          |  4 ++--
 MdeModulePkg/Core/Dxe/Event/Tpl.c                         | 12 +++++++++---
 MdeModulePkg/Library/DxeNetLib/DxeNetLib.c                |  2 +-
 MdeModulePkg/Library/DxePrintLibPrint2Protocol/PrintLib.c |  2 +-
 MdePkg/Library/BasePrintLib/PrintLibInternal.c            |  2 +-
 5 files changed, 14 insertions(+), 8 deletions(-)

-- 
2.12.0.windows.1



             reply	other threads:[~2017-09-28  4:29 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-09-28  4:32 Hao Wu [this message]
2017-09-28  4:32 ` [PATCH v3 1/5] MdePkg/PrintLib: Fix possible negative value left shift Hao Wu
2017-09-28  4:32 ` [PATCH v3 2/5] MdeModulePkg/PrintLib: " Hao Wu
2017-09-28  4:32 ` [PATCH v3 3/5] MdeModulePkg/Tpl: Fix " Hao Wu
2017-09-28  4:32 ` [PATCH v3 4/5] MdeModulePkg/DxeNetLib: " Hao Wu
2017-09-28  5:42   ` Wu, Jiaxin
2017-09-28  7:21   ` Fu, Siyuan
2017-09-28  7:30   ` Ye, Ting
2017-09-28  4:32 ` [PATCH v3 5/5] MdeModulePkg/AtaAtapiPassThru: Fix possible out of range " Hao Wu
2017-09-28  5:12   ` Zeng, Star

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170928043213.20776-1-hao.a.wu@intel.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox